Fix TestMetricsSnapshot/uptime flakiness on Windows

Simplify uptime calculation to always enforce minimum of 1 second,
even if time.Since returns exactly 0 (can happen on Windows with
coarse timing). This makes the test deterministic.

internal/rpc/metrics.go

@@ -105,10 +105,10 @@ func (m *Metrics) Snapshot(activeConns int) MetricsSnapshot {
 
 	// Compute statistics outside the lock
 	uptime := time.Since(m.startTime)
-	// Round up uptime and enforce minimum of 1 second if any time has passed
+	// Round up uptime and enforce minimum of 1 second
 	// This prevents flaky tests on fast systems (especially Windows VMs)
 	uptimeSeconds := math.Ceil(uptime.Seconds())
-	if uptime > 0 && uptimeSeconds == 0 {
+	if uptimeSeconds == 0 {
 		uptimeSeconds = 1
 	}
 

internal/rpc/metrics_test.go

@@ -135,8 +135,10 @@ func TestMetricsSnapshot(t *testing.T) {
 	})
 
 	t.Run("uptime", func(t *testing.T) {
-		if snapshot.UptimeSeconds <= 0 {
-			t.Error("Expected positive uptime")
+		// The uptime calculation uses math.Ceil and ensures minimum 1 second
+		// if any time has passed. This should always be >= 1.
+		if snapshot.UptimeSeconds < 1 {
+			t.Errorf("Expected uptime >= 1, got %f", snapshot.UptimeSeconds)
 		}
 	})