test(doctor): add tests to restore coverage above 45%

Add tests for doctor package functions after refactor PR #653: - version_test.go: CompareVersions, IsValidSemver, ParseVersionParts - types_test.go: status constants and DoctorCheck struct - installation_test.go: CheckInstallation, CheckMultipleDatabases, CheckPermissions - integrity_test.go: CheckIDFormat, CheckDependencyCycles, CheckTombstones, CheckDeletionsManifest - database_test.go: CheckDatabaseVersion, CheckSchemaCompatibility, CheckDatabaseIntegrity - daemon_test.go: CheckDaemonStatus - git_test.go: CheckGitHooks, CheckMergeDriver, CheckSyncBranchConfig 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-19 17:43:18 -08:00
parent e9be35e374
commit 13a471fe45
7 changed files with 658 additions and 0 deletions
@@ -0,0 +1,131 @@
+package doctor
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+)
+
+func TestCheckInstallation(t *testing.T) {
+	t.Run("missing beads directory", func(t *testing.T) {
+		tmpDir := t.TempDir()
+		check := CheckInstallation(tmpDir)
+
+		if check.Status != StatusError {
+			t.Errorf("expected StatusError, got %s", check.Status)
+		}
+		if check.Name != "Installation" {
+			t.Errorf("expected name 'Installation', got %s", check.Name)
+		}
+	})
+
+	t.Run("beads directory exists", func(t *testing.T) {
+		tmpDir := t.TempDir()
+		beadsDir := filepath.Join(tmpDir, ".beads")
+		if err := os.Mkdir(beadsDir, 0755); err != nil {
+			t.Fatal(err)
+		}
+
+		check := CheckInstallation(tmpDir)
+
+		if check.Status != StatusOK {
+			t.Errorf("expected StatusOK, got %s", check.Status)
+		}
+	})
+}
+
+func TestCheckMultipleDatabases(t *testing.T) {
+	t.Run("no beads directory", func(t *testing.T) {
+		tmpDir := t.TempDir()
+		check := CheckMultipleDatabases(tmpDir)
+
+		if check.Status != StatusOK {
+			t.Errorf("expected StatusOK for missing dir, got %s", check.Status)
+		}
+	})
+
+	t.Run("single database", func(t *testing.T) {
+		tmpDir := t.TempDir()
+		beadsDir := filepath.Join(tmpDir, ".beads")
+		if err := os.Mkdir(beadsDir, 0755); err != nil {
+			t.Fatal(err)
+		}
+		// Create single db file
+		if err := os.WriteFile(filepath.Join(beadsDir, "beads.db"), []byte{}, 0644); err != nil {
+			t.Fatal(err)
+		}
+
+		check := CheckMultipleDatabases(tmpDir)
+
+		if check.Status != StatusOK {
+			t.Errorf("expected StatusOK for single db, got %s", check.Status)
+		}
+	})
+
+	t.Run("multiple databases", func(t *testing.T) {
+		tmpDir := t.TempDir()
+		beadsDir := filepath.Join(tmpDir, ".beads")
+		if err := os.Mkdir(beadsDir, 0755); err != nil {
+			t.Fatal(err)
+		}
+		// Create multiple db files
+		for _, name := range []string{"beads.db", "issues.db", "another.db"} {
+			if err := os.WriteFile(filepath.Join(beadsDir, name), []byte{}, 0644); err != nil {
+				t.Fatal(err)
+			}
+		}
+
+		check := CheckMultipleDatabases(tmpDir)
+
+		if check.Status != StatusWarning {
+			t.Errorf("expected StatusWarning for multiple dbs, got %s", check.Status)
+		}
+	})
+
+	t.Run("backup files ignored", func(t *testing.T) {
+		tmpDir := t.TempDir()
+		beadsDir := filepath.Join(tmpDir, ".beads")
+		if err := os.Mkdir(beadsDir, 0755); err != nil {
+			t.Fatal(err)
+		}
+		// Create one real db and one backup
+		if err := os.WriteFile(filepath.Join(beadsDir, "beads.db"), []byte{}, 0644); err != nil {
+			t.Fatal(err)
+		}
+		if err := os.WriteFile(filepath.Join(beadsDir, "beads.backup.db"), []byte{}, 0644); err != nil {
+			t.Fatal(err)
+		}
+
+		check := CheckMultipleDatabases(tmpDir)
+
+		if check.Status != StatusOK {
+			t.Errorf("expected StatusOK (backup ignored), got %s", check.Status)
+		}
+	})
+}
+
+func TestCheckPermissions(t *testing.T) {
+	t.Run("no beads directory", func(t *testing.T) {
+		tmpDir := t.TempDir()
+		check := CheckPermissions(tmpDir)
+
+		// Should return error when .beads dir doesn't exist (can't write to it)
+		if check.Status != StatusError {
+			t.Errorf("expected StatusError for missing dir, got %s", check.Status)
+		}
+	})
+
+	t.Run("writable directory", func(t *testing.T) {
+		tmpDir := t.TempDir()
+		beadsDir := filepath.Join(tmpDir, ".beads")
+		if err := os.Mkdir(beadsDir, 0755); err != nil {
+			t.Fatal(err)
+		}
+
+		check := CheckPermissions(tmpDir)
+
+		if check.Status != StatusOK {
+			t.Errorf("expected StatusOK for writable dir, got %s", check.Status)
+		}
+	})
+}