johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix remaining test database initialization errors (bd-207)

Browse Source 
Fixed 38 tests failing with 'database not initialized: issue_prefix config is missing' by replacing manual sqlite.New() calls with test helper functions.

Modified files:
- dep_test.go (4 tests)
- merge_test.go (4 tests)
- export_import_test.go (4 instances)
- import_collision_test.go (10 instances)
- import_bug_test.go (1 instance)
- import_collision_regression_test.go (2 instances)
- import_idempotent_test.go (2 instances)
- init_test.go (4 instances)
- integrity_test.go (3 tests)
- main_test.go (multiple tests)

All database initialization errors are now resolved.
Remaining test failures (2) are unrelated to database initialization.

Amp-Thread-ID: https://ampcode.com/threads/T-a6b09458-b899-49eb-9a62-346fa67f62c7
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
2025-10-27 20:00:49 -07:00
parent a6ecc87a09
commit 1e2e066dc4
10 changed files with 82 additions and 391 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
cmd/bd/init_test.go
View File

@@ -7,8 +7,6 @@ import (
"path/filepath"
"strings"
"testing"
"github.com/steveyegge/beads/internal/storage/sqlite"
)
func TestInitCommand(t *testing.T) {
@@ -150,14 +148,15 @@ func TestInitCommand(t *testing.T) {
}
// Verify database has correct prefix
store, err := sqlite.New(dbPath)
// Note: This database was already created by init command, just open it
store, err := openExistingTestDB(t, dbPath)
if err != nil {
t.Fatalf("Failed to open created database: %v", err)
}
defer store.Close()
t.Fatalf("Failed to open database: %v", err)
}
defer store.Close()
ctx := context.Background()
prefix, err := store.GetConfig(ctx, "issue_prefix")
ctx := context.Background()
prefix, err := store.GetConfig(ctx, "issue_prefix")
if err != nil {
t.Fatalf("Failed to get issue prefix from database: %v", err)
}
@@ -221,9 +220,9 @@ func TestInitAlreadyInitialized(t *testing.T) {
// Verify database still works (always beads.db now)
dbPath := filepath.Join(tmpDir, ".beads", "beads.db")
store, err := sqlite.New(dbPath)
store, err := openExistingTestDB(t, dbPath)
if err != nil {
t.Fatalf("Failed to open database after re-init: %v", err)
t.Fatalf("Failed to open database: %v", err)
}
defer store.Close()
@@ -279,7 +278,7 @@ func TestInitWithCustomDBPath(t *testing.T) {
}
// Verify database works
store, err := sqlite.New(customDBPath)
store, err := openExistingTestDB(t, customDBPath)
if err != nil {
t.Fatalf("Failed to open database: %v", err)
}
@@ -320,7 +319,7 @@ func TestInitWithCustomDBPath(t *testing.T) {
}
// Verify database works
store, err := sqlite.New(envDBPath)
store, err := openExistingTestDB(t, envDBPath)
if err != nil {
t.Fatalf("Failed to open database: %v", err)
}