johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix remaining test database initialization errors (bd-207)

Browse Source 
Fixed 38 tests failing with 'database not initialized: issue_prefix config is missing' by replacing manual sqlite.New() calls with test helper functions.

Modified files:
- dep_test.go (4 tests)
- merge_test.go (4 tests)
- export_import_test.go (4 instances)
- import_collision_test.go (10 instances)
- import_bug_test.go (1 instance)
- import_collision_regression_test.go (2 instances)
- import_idempotent_test.go (2 instances)
- init_test.go (4 instances)
- integrity_test.go (3 tests)
- main_test.go (multiple tests)

All database initialization errors are now resolved.
Remaining test failures (2) are unrelated to database initialization.

Amp-Thread-ID: https://ampcode.com/threads/T-a6b09458-b899-49eb-9a62-346fa67f62c7
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
2025-10-27 20:00:49 -07:00
parent a6ecc87a09
commit 1e2e066dc4
10 changed files with 82 additions and 391 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
cmd/bd/integrity_test.go
View File

@@ -6,7 +6,6 @@ import (
"path/filepath"
"testing"
"github.com/steveyegge/beads/internal/storage/sqlite"
"github.com/steveyegge/beads/internal/types"
)
@@ -20,11 +19,7 @@ func TestValidatePreExport(t *testing.T) {
jsonlPath := filepath.Join(tmpDir, "issues.jsonl")
// Create empty database
store, err := sqlite.New(dbPath)
if err != nil {
t.Fatalf("Failed to create store: %v", err)
}
defer store.Close()
store := newTestStore(t, dbPath)
// Create non-empty JSONL file
jsonlContent := `{"id":"bd-1","title":"Test","status":"open","priority":1}
@@ -34,7 +29,7 @@ func TestValidatePreExport(t *testing.T) {
}
// Should fail validation
err = validatePreExport(ctx, store, jsonlPath)
err := validatePreExport(ctx, store, jsonlPath)
if err == nil {
t.Error("Expected error for empty DB over non-empty JSONL, got nil")
}
@@ -47,13 +42,10 @@ func TestValidatePreExport(t *testing.T) {
jsonlPath := filepath.Join(tmpDir, "issues.jsonl")
// Create database with issues
store, err := sqlite.New(dbPath)
if err != nil {
t.Fatalf("Failed to create store: %v", err)
}
defer store.Close()
store := newTestStoreWithPrefix(t, dbPath, "bd")
// Add an issue
ctx := context.Background()
issue := &types.Issue{
ID: "bd-1",
Title: "Test",
@@ -74,7 +66,7 @@ func TestValidatePreExport(t *testing.T) {
}
// Should pass validation
err = validatePreExport(ctx, store, jsonlPath)
err := validatePreExport(ctx, store, jsonlPath)
if err != nil {
t.Errorf("Expected no error, got: %v", err)
}
@@ -87,16 +79,12 @@ func TestValidatePreExport(t *testing.T) {
jsonlPath := filepath.Join(tmpDir, "issues.jsonl")
// Create empty database
store, err := sqlite.New(dbPath)
if err != nil {
t.Fatalf("Failed to create store: %v", err)
}
defer store.Close()
store := newTestStore(t, dbPath)
// JSONL doesn't exist
// Should pass validation (new repo scenario)
err = validatePreExport(ctx, store, jsonlPath)
err := validatePreExport(ctx, store, jsonlPath)
if err != nil {
t.Errorf("Expected no error for empty DB with no JSONL, got: %v", err)
}
@@ -109,11 +97,7 @@ func TestValidatePreExport(t *testing.T) {
jsonlPath := filepath.Join(tmpDir, "issues.jsonl")
// Create empty database
store, err := sqlite.New(dbPath)
if err != nil {
t.Fatalf("Failed to create store: %v", err)
}
defer store.Close()
store := newTestStore(t, dbPath)
// Create corrupt/unreadable JSONL file with content
corruptContent := `{"id":"bd-1","title":INVALID JSON`
@@ -122,7 +106,7 @@ func TestValidatePreExport(t *testing.T) {
}
// Should fail validation (can't verify JSONL content, DB is empty, file has content)
err = validatePreExport(ctx, store, jsonlPath)
err := validatePreExport(ctx, store, jsonlPath)
if err == nil {
t.Error("Expected error for empty DB over unreadable non-empty JSONL, got nil")
}
@@ -153,20 +137,15 @@ func TestValidatePostImport(t *testing.T) {
}
func TestCountDBIssues(t *testing.T) {
ctx := context.Background()
t.Run("count issues in database", func(t *testing.T) {
// Create temp directory
tmpDir := t.TempDir()
dbPath := filepath.Join(tmpDir, "test.db")
// Create database
store, err := sqlite.New(dbPath)
if err != nil {
t.Fatalf("Failed to create store: %v", err)
}
defer store.Close()
store := newTestStoreWithPrefix(t, dbPath, "bd")
ctx := context.Background()
// Initially 0
count, err := countDBIssues(ctx, store)
if err != nil {
@@ -203,20 +182,15 @@ func TestCountDBIssues(t *testing.T) {
}
func TestCheckOrphanedDeps(t *testing.T) {
ctx := context.Background()
t.Run("function executes without error", func(t *testing.T) {
// Create temp directory
tmpDir := t.TempDir()
dbPath := filepath.Join(tmpDir, "test.db")
// Create database
store, err := sqlite.New(dbPath)
if err != nil {
t.Fatalf("Failed to create store: %v", err)
}
defer store.Close()
store := newTestStoreWithPrefix(t, dbPath, "bd")
ctx := context.Background()
// Create two issues
issue1 := &types.Issue{
ID: "bd-1",
@@ -272,12 +246,9 @@ func TestCheckOrphanedDeps(t *testing.T) {
dbPath := filepath.Join(tmpDir, "test.db")
// Create database
store, err := sqlite.New(dbPath)
if err != nil {
t.Fatalf("Failed to create store: %v", err)
}
defer store.Close()
store := newTestStoreWithPrefix(t, dbPath, "bd")
ctx := context.Background()
// Create two issues
issue1 := &types.Issue{
ID: "bd-1",