chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)

- Remove TestFindJSONLPathDefault from .test-skip (now passes)
- Add explanatory comments to 24 ignored error locations in cmd/bd:
  - Cobra flag methods (MarkHidden, MarkRequired, MarkDeprecated)
  - Best-effort cleanup/close operations
  - Process signaling operations

Part of code health review epic bd-tggf.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-22 21:30:57 -08:00
parent fc0b98730a
commit 25061ea9a7
15 changed files with 25 additions and 30 deletions

View File

@@ -70,16 +70,16 @@ func acquireDaemonLock(beadsDir string, dbPath string) (*DaemonLock, error) {
StartedAt: time.Now().UTC(),
}
_ = f.Truncate(0)
_ = f.Truncate(0) // Clear file for fresh write (we hold lock)
_, _ = f.Seek(0, 0)
encoder := json.NewEncoder(f)
encoder.SetIndent("", " ")
_ = encoder.Encode(lockInfo)
_ = f.Sync()
_ = encoder.Encode(lockInfo) // Write can't fail if Truncate succeeded
_ = f.Sync() // Best-effort sync to disk
// Also write PID file for Windows compatibility (can't read locked files on Windows)
pidFile := filepath.Join(beadsDir, "daemon.pid")
_ = os.WriteFile(pidFile, []byte(fmt.Sprintf("%d\n", os.Getpid())), 0600)
_ = os.WriteFile(pidFile, []byte(fmt.Sprintf("%d\n", os.Getpid())), 0600) // Best-effort PID write
return &DaemonLock{file: f, path: lockPath}, nil
}