chore: code health review - test fix and error comments (bd-9g1z, bd-ork0)
- Remove TestFindJSONLPathDefault from .test-skip (now passes) - Add explanatory comments to 24 ignored error locations in cmd/bd: - Cobra flag methods (MarkHidden, MarkRequired, MarkDeprecated) - Best-effort cleanup/close operations - Process signaling operations Part of code health review epic bd-tggf. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -322,7 +322,7 @@ func stopDaemonQuiet(pidFile string) {
|
||||
return
|
||||
}
|
||||
|
||||
_ = sendStopSignal(process)
|
||||
_ = sendStopSignal(process) // Best-effort graceful stop
|
||||
|
||||
// Wait for daemon to stop gracefully
|
||||
for i := 0; i < daemonShutdownAttempts; i++ {
|
||||
@@ -333,7 +333,7 @@ func stopDaemonQuiet(pidFile string) {
|
||||
}
|
||||
|
||||
// Force kill if still running
|
||||
_ = process.Kill()
|
||||
_ = process.Kill() // Best-effort force kill, process may have already exited
|
||||
}
|
||||
|
||||
func removeGitattributesEntry() error {
|
||||
|
||||
Reference in New Issue
Block a user