johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve P2 sync noise and cleanup issues

Browse Source 
- bd-6pni: Auto-filter tombstoned issues with mismatched prefixes during
  import instead of failing. Tombstones from contributor PRs with different
  test prefixes are pollution and safe to ignore.

- bd-ffr9: Stop recreating deletions.jsonl after tombstone migration.
  Added IsTombstoneMigrationComplete() check to all code paths that write
  to the legacy deletions manifest.

- bd-admx: Fix perpetual "JSONL file hash mismatch" warning. Now clears
  both export_hashes AND jsonl_file_hash when mismatch detected, so the
  warning doesn't repeat.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-16 00:55:43 -08:00
parent 88ccce884c
commit 2c86404d65
9 changed files with 341 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
cmd/bd/jsonl_integrity_test.go
View File

@@ -100,12 +100,12 @@ func TestJSONLIntegrityValidation(t *testing.T) {
if err := os.WriteFile(jsonlPath, []byte(`{"id":"bd-1","title":"Modified"}`+"\n"), 0644); err != nil {
t.Fatalf("failed to modify JSONL: %v", err)
}
// Add an export hash to verify it gets cleared
if err := testStore.SetExportHash(ctx, "bd-1", "dummy-hash"); err != nil {
t.Fatalf("failed to set export hash: %v", err)
}
// Validate should detect mismatch and clear export_hashes
needsFullExport, err := validateJSONLIntegrity(ctx, jsonlPath)
if err != nil {
@@ -114,7 +114,7 @@ func TestJSONLIntegrityValidation(t *testing.T) {
if !needsFullExport {
t.Fatalf("expected needsFullExport=true after clearing export_hashes")
}
// Verify export_hashes were cleared
hash, err := testStore.GetExportHash(ctx, "bd-1")
if err != nil {
@@ -123,6 +123,15 @@ func TestJSONLIntegrityValidation(t *testing.T) {
if hash != "" {
t.Fatalf("expected export hash to be cleared, got %q", hash)
}
// Verify jsonl_file_hash was also cleared (bd-admx fix)
fileHash, err := testStore.GetJSONLFileHash(ctx)
if err != nil {
t.Fatalf("failed to get JSONL file hash: %v", err)
}
if fileHash != "" {
t.Fatalf("expected jsonl_file_hash to be cleared to prevent perpetual warnings, got %q", fileHash)
}
})
// Test 3: Missing JSONL file
@@ -131,17 +140,17 @@ func TestJSONLIntegrityValidation(t *testing.T) {
if err := testStore.SetJSONLFileHash(ctx, "some-hash"); err != nil {
t.Fatalf("failed to set JSONL file hash: %v", err)
}
// Add an export hash
if err := testStore.SetExportHash(ctx, "bd-1", "dummy-hash"); err != nil {
t.Fatalf("failed to set export hash: %v", err)
}
// Remove JSONL file
if err := os.Remove(jsonlPath); err != nil {
t.Fatalf("failed to remove JSONL: %v", err)
}
// Validate should detect missing file and clear export_hashes
needsFullExport, err := validateJSONLIntegrity(ctx, jsonlPath)
if err != nil {
@@ -150,7 +159,7 @@ func TestJSONLIntegrityValidation(t *testing.T) {
if !needsFullExport {
t.Fatalf("expected needsFullExport=true after clearing export_hashes")
}
// Verify export_hashes were cleared
hash, err := testStore.GetExportHash(ctx, "bd-1")
if err != nil {
@@ -159,6 +168,15 @@ func TestJSONLIntegrityValidation(t *testing.T) {
if hash != "" {
t.Fatalf("expected export hash to be cleared, got %q", hash)
}
// Verify jsonl_file_hash was also cleared (bd-admx fix)
fileHash, err := testStore.GetJSONLFileHash(ctx)
if err != nil {
t.Fatalf("failed to get JSONL file hash: %v", err)
}
if fileHash != "" {
t.Fatalf("expected jsonl_file_hash to be cleared to prevent perpetual warnings, got %q", fileHash)
}
})
}