fix: resolve P2 sync noise and cleanup issues
- bd-6pni: Auto-filter tombstoned issues with mismatched prefixes during import instead of failing. Tombstones from contributor PRs with different test prefixes are pollution and safe to ignore. - bd-ffr9: Stop recreating deletions.jsonl after tombstone migration. Added IsTombstoneMigrationComplete() check to all code paths that write to the legacy deletions manifest. - bd-admx: Fix perpetual "JSONL file hash mismatch" warning. Now clears both export_hashes AND jsonl_file_hash when mismatch detected, so the warning doesn't repeat. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -181,6 +181,17 @@ func DefaultPath(beadsDir string) string {
|
||||
return filepath.Join(beadsDir, "deletions.jsonl")
|
||||
}
|
||||
|
||||
// IsTombstoneMigrationComplete checks if the tombstone migration has been completed.
|
||||
// After running `bd migrate-tombstones`, the deletions.jsonl file is archived to
|
||||
// deletions.jsonl.migrated. This function checks for that marker file.
|
||||
// When migration is complete, new deletion records should NOT be written to
|
||||
// deletions.jsonl (bd-ffr9).
|
||||
func IsTombstoneMigrationComplete(beadsDir string) bool {
|
||||
migratedPath := filepath.Join(beadsDir, "deletions.jsonl.migrated")
|
||||
_, err := os.Stat(migratedPath)
|
||||
return err == nil
|
||||
}
|
||||
|
||||
// Count returns the number of lines in the deletions manifest.
|
||||
// This is a fast operation that doesn't parse JSON, just counts lines.
|
||||
// Returns 0 if the file doesn't exist or is empty.
|
||||
|
||||
@@ -290,6 +290,38 @@ func TestDefaultPath(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestIsTombstoneMigrationComplete(t *testing.T) {
|
||||
t.Run("no migrated file", func(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
if IsTombstoneMigrationComplete(tmpDir) {
|
||||
t.Error("expected false when no .migrated file exists")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("migrated file exists", func(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
migratedPath := filepath.Join(tmpDir, "deletions.jsonl.migrated")
|
||||
if err := os.WriteFile(migratedPath, []byte("{}"), 0644); err != nil {
|
||||
t.Fatalf("failed to create migrated file: %v", err)
|
||||
}
|
||||
if !IsTombstoneMigrationComplete(tmpDir) {
|
||||
t.Error("expected true when .migrated file exists")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("deletions.jsonl exists without migrated", func(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
deletionsPath := filepath.Join(tmpDir, "deletions.jsonl")
|
||||
if err := os.WriteFile(deletionsPath, []byte("{}"), 0644); err != nil {
|
||||
t.Fatalf("failed to create deletions file: %v", err)
|
||||
}
|
||||
// Should return false because the .migrated marker doesn't exist
|
||||
if IsTombstoneMigrationComplete(tmpDir) {
|
||||
t.Error("expected false when only deletions.jsonl exists (not migrated)")
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func TestLoadDeletions_EmptyLines(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
path := filepath.Join(tmpDir, "deletions.jsonl")
|
||||
|
||||
@@ -180,7 +180,8 @@ func ImportIssues(ctx context.Context, dbPath string, store storage.Storage, iss
|
||||
}
|
||||
|
||||
// Check and handle prefix mismatches
|
||||
if err := handlePrefixMismatch(ctx, sqliteStore, issues, opts, result); err != nil {
|
||||
issues, err = handlePrefixMismatch(ctx, sqliteStore, issues, opts, result)
|
||||
if err != nil {
|
||||
return result, err
|
||||
}
|
||||
|
||||
@@ -258,48 +259,90 @@ func getOrCreateStore(ctx context.Context, dbPath string, store storage.Storage)
|
||||
return sqliteStore, true, nil
|
||||
}
|
||||
|
||||
// handlePrefixMismatch checks and handles prefix mismatches
|
||||
func handlePrefixMismatch(ctx context.Context, sqliteStore *sqlite.SQLiteStorage, issues []*types.Issue, opts Options, result *Result) error {
|
||||
// handlePrefixMismatch checks and handles prefix mismatches.
|
||||
// Returns a filtered issues slice with tombstoned issues having wrong prefixes removed (bd-6pni).
|
||||
func handlePrefixMismatch(ctx context.Context, sqliteStore *sqlite.SQLiteStorage, issues []*types.Issue, opts Options, result *Result) ([]*types.Issue, error) {
|
||||
configuredPrefix, err := sqliteStore.GetConfig(ctx, "issue_prefix")
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to get configured prefix: %w", err)
|
||||
return nil, fmt.Errorf("failed to get configured prefix: %w", err)
|
||||
}
|
||||
|
||||
// Only validate prefixes if a prefix is configured
|
||||
if strings.TrimSpace(configuredPrefix) == "" {
|
||||
if opts.RenameOnImport {
|
||||
return fmt.Errorf("cannot rename: issue_prefix not configured in database")
|
||||
return nil, fmt.Errorf("cannot rename: issue_prefix not configured in database")
|
||||
}
|
||||
return nil
|
||||
return issues, nil
|
||||
}
|
||||
|
||||
result.ExpectedPrefix = configuredPrefix
|
||||
|
||||
// Analyze prefixes in imported issues
|
||||
// Track tombstones separately - they don't count as "real" mismatches (bd-6pni)
|
||||
tombstoneMismatchPrefixes := make(map[string]int)
|
||||
nonTombstoneMismatchCount := 0
|
||||
|
||||
// Also track which tombstones have wrong prefixes for filtering
|
||||
var filteredIssues []*types.Issue
|
||||
var tombstonesToRemove []string
|
||||
|
||||
for _, issue := range issues {
|
||||
prefix := utils.ExtractIssuePrefix(issue.ID)
|
||||
if prefix != configuredPrefix {
|
||||
result.PrefixMismatch = true
|
||||
result.MismatchPrefixes[prefix]++
|
||||
if issue.IsTombstone() {
|
||||
tombstoneMismatchPrefixes[prefix]++
|
||||
tombstonesToRemove = append(tombstonesToRemove, issue.ID)
|
||||
// Don't add to filtered list - we'll remove these
|
||||
} else {
|
||||
result.PrefixMismatch = true
|
||||
result.MismatchPrefixes[prefix]++
|
||||
nonTombstoneMismatchCount++
|
||||
filteredIssues = append(filteredIssues, issue)
|
||||
}
|
||||
} else {
|
||||
// Correct prefix - keep the issue
|
||||
filteredIssues = append(filteredIssues, issue)
|
||||
}
|
||||
}
|
||||
|
||||
// If prefix mismatch detected and not handling it, return error or warning
|
||||
if result.PrefixMismatch && !opts.RenameOnImport && !opts.DryRun && !opts.SkipPrefixValidation {
|
||||
return fmt.Errorf("prefix mismatch detected: database uses '%s-' but found issues with prefixes: %v (use --rename-on-import to automatically fix)", configuredPrefix, GetPrefixList(result.MismatchPrefixes))
|
||||
// bd-6pni: If ALL mismatched prefix issues are tombstones, they're just pollution
|
||||
// from contributor PRs that used different test prefixes. These are safe to remove.
|
||||
if nonTombstoneMismatchCount == 0 && len(tombstoneMismatchPrefixes) > 0 {
|
||||
// Log that we're ignoring tombstoned mismatches
|
||||
var tombstonePrefixList []string
|
||||
for prefix, count := range tombstoneMismatchPrefixes {
|
||||
tombstonePrefixList = append(tombstonePrefixList, fmt.Sprintf("%s- (%d tombstones)", prefix, count))
|
||||
}
|
||||
fmt.Fprintf(os.Stderr, "Ignoring prefix mismatches (all are tombstones): %v\n", tombstonePrefixList)
|
||||
// Clear mismatch flags - no real issues to worry about
|
||||
result.PrefixMismatch = false
|
||||
result.MismatchPrefixes = make(map[string]int)
|
||||
// Return filtered list without the tombstones
|
||||
return filteredIssues, nil
|
||||
}
|
||||
|
||||
// If there are non-tombstone mismatches, we need to include all issues (tombstones too)
|
||||
// but still report the error for non-tombstones
|
||||
if result.PrefixMismatch {
|
||||
// If not handling the mismatch, return error
|
||||
if !opts.RenameOnImport && !opts.DryRun && !opts.SkipPrefixValidation {
|
||||
return nil, fmt.Errorf("prefix mismatch detected: database uses '%s-' but found issues with prefixes: %v (use --rename-on-import to automatically fix)", configuredPrefix, GetPrefixList(result.MismatchPrefixes))
|
||||
}
|
||||
}
|
||||
|
||||
// Handle rename-on-import if requested
|
||||
if result.PrefixMismatch && opts.RenameOnImport && !opts.DryRun {
|
||||
if err := RenameImportedIssuePrefixes(issues, configuredPrefix); err != nil {
|
||||
return fmt.Errorf("failed to rename prefixes: %w", err)
|
||||
return nil, fmt.Errorf("failed to rename prefixes: %w", err)
|
||||
}
|
||||
// After renaming, clear the mismatch flags since we fixed them
|
||||
result.PrefixMismatch = false
|
||||
result.MismatchPrefixes = make(map[string]int)
|
||||
return issues, nil
|
||||
}
|
||||
|
||||
return nil
|
||||
// Return original issues if no filtering needed
|
||||
return issues, nil
|
||||
}
|
||||
|
||||
// detectUpdates detects same-ID scenarios (which are updates with hash IDs, not collisions)
|
||||
@@ -1034,14 +1077,17 @@ func purgeDeletedIssues(ctx context.Context, sqliteStore *sqlite.SQLiteStorage,
|
||||
}
|
||||
|
||||
// Backfill the deletions manifest (self-healing)
|
||||
backfillRecord := deletions.DeletionRecord{
|
||||
ID: id,
|
||||
Timestamp: time.Now().UTC(),
|
||||
Actor: "git-history-backfill",
|
||||
Reason: "recovered from git history (pruned from manifest)",
|
||||
}
|
||||
if err := deletions.AppendDeletion(deletionsPath, backfillRecord); err != nil {
|
||||
fmt.Fprintf(os.Stderr, "Warning: failed to backfill deletion record for %s: %v\n", id, err)
|
||||
// bd-ffr9: Skip writing to deletions.jsonl if tombstone migration is complete
|
||||
if !deletions.IsTombstoneMigrationComplete(beadsDir) {
|
||||
backfillRecord := deletions.DeletionRecord{
|
||||
ID: id,
|
||||
Timestamp: time.Now().UTC(),
|
||||
Actor: "git-history-backfill",
|
||||
Reason: "recovered from git history (pruned from manifest)",
|
||||
}
|
||||
if err := deletions.AppendDeletion(deletionsPath, backfillRecord); err != nil {
|
||||
fmt.Fprintf(os.Stderr, "Warning: failed to backfill deletion record for %s: %v\n", id, err)
|
||||
}
|
||||
}
|
||||
|
||||
// Convert to tombstone (bd-dve)
|
||||
|
||||
@@ -1596,3 +1596,143 @@ func TestImportCrossPrefixContentMatch(t *testing.T) {
|
||||
t.Error("Cross-prefix issue beta-xyz789 should NOT be created in the database")
|
||||
}
|
||||
}
|
||||
|
||||
// TestImportTombstonePrefixMismatch tests that tombstoned issues with different prefixes
|
||||
// don't block import (bd-6pni). This handles pollution from contributor PRs that used
|
||||
// different test prefixes - these tombstones are safe to ignore.
|
||||
func TestImportTombstonePrefixMismatch(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
|
||||
tmpDB := t.TempDir() + "/test.db"
|
||||
store, err := sqlite.New(context.Background(), tmpDB)
|
||||
if err != nil {
|
||||
t.Fatalf("Failed to create store: %v", err)
|
||||
}
|
||||
defer store.Close()
|
||||
|
||||
// Configure database with "bd" prefix
|
||||
if err := store.SetConfig(ctx, "issue_prefix", "bd"); err != nil {
|
||||
t.Fatalf("Failed to set prefix: %v", err)
|
||||
}
|
||||
|
||||
// Create tombstoned issues with WRONG prefixes (simulating pollution)
|
||||
deletedAt := time.Now().Add(-time.Hour)
|
||||
issues := []*types.Issue{
|
||||
// Normal issue with correct prefix
|
||||
{
|
||||
ID: "bd-good1",
|
||||
Title: "Good issue",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
},
|
||||
// Tombstone with wrong prefix "beads"
|
||||
{
|
||||
ID: "beads-old1",
|
||||
Title: "(deleted)",
|
||||
Status: types.StatusTombstone,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
DeletedAt: &deletedAt,
|
||||
DeletedBy: "cleanup",
|
||||
DeleteReason: "test cleanup",
|
||||
},
|
||||
// Tombstone with wrong prefix "test"
|
||||
{
|
||||
ID: "test-old2",
|
||||
Title: "(deleted)",
|
||||
Status: types.StatusTombstone,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
DeletedAt: &deletedAt,
|
||||
DeletedBy: "cleanup",
|
||||
DeleteReason: "test cleanup",
|
||||
},
|
||||
}
|
||||
|
||||
// Import should succeed - tombstones with wrong prefixes should be ignored
|
||||
result, err := ImportIssues(ctx, tmpDB, store, issues, Options{})
|
||||
if err != nil {
|
||||
t.Fatalf("Import should succeed when all mismatched prefixes are tombstones: %v", err)
|
||||
}
|
||||
|
||||
// Should have created the good issue
|
||||
// Tombstones with wrong prefixes are skipped (cross-prefix content match logic)
|
||||
if result.Created < 1 {
|
||||
t.Errorf("Expected at least 1 created issue, got %d", result.Created)
|
||||
}
|
||||
|
||||
// PrefixMismatch should be false because all mismatches were tombstones
|
||||
if result.PrefixMismatch {
|
||||
t.Error("PrefixMismatch should be false when all mismatched prefixes are tombstones")
|
||||
}
|
||||
|
||||
// Verify the good issue was imported
|
||||
goodIssue, err := store.GetIssue(ctx, "bd-good1")
|
||||
if err != nil {
|
||||
t.Fatalf("Failed to get good issue: %v", err)
|
||||
}
|
||||
if goodIssue.Title != "Good issue" {
|
||||
t.Errorf("Expected title 'Good issue', got %q", goodIssue.Title)
|
||||
}
|
||||
}
|
||||
|
||||
// TestImportMixedPrefixMismatch tests that import fails when there are non-tombstone
|
||||
// issues with wrong prefixes, even if some tombstones also have wrong prefixes.
|
||||
func TestImportMixedPrefixMismatch(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
|
||||
tmpDB := t.TempDir() + "/test.db"
|
||||
store, err := sqlite.New(context.Background(), tmpDB)
|
||||
if err != nil {
|
||||
t.Fatalf("Failed to create store: %v", err)
|
||||
}
|
||||
defer store.Close()
|
||||
|
||||
// Configure database with "bd" prefix
|
||||
if err := store.SetConfig(ctx, "issue_prefix", "bd"); err != nil {
|
||||
t.Fatalf("Failed to set prefix: %v", err)
|
||||
}
|
||||
|
||||
deletedAt := time.Now().Add(-time.Hour)
|
||||
issues := []*types.Issue{
|
||||
// Normal issue with correct prefix
|
||||
{
|
||||
ID: "bd-good1",
|
||||
Title: "Good issue",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
},
|
||||
// Tombstone with wrong prefix (should be ignored)
|
||||
{
|
||||
ID: "beads-old1",
|
||||
Title: "(deleted)",
|
||||
Status: types.StatusTombstone,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
DeletedAt: &deletedAt,
|
||||
DeletedBy: "cleanup",
|
||||
DeleteReason: "test cleanup",
|
||||
},
|
||||
// NON-tombstone with wrong prefix (should cause error)
|
||||
{
|
||||
ID: "other-bad1",
|
||||
Title: "Bad issue with wrong prefix",
|
||||
Status: types.StatusOpen,
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
},
|
||||
}
|
||||
|
||||
// Import should fail due to the non-tombstone with wrong prefix
|
||||
_, err = ImportIssues(ctx, tmpDB, store, issues, Options{})
|
||||
if err == nil {
|
||||
t.Fatal("Import should fail when there are non-tombstone issues with wrong prefixes")
|
||||
}
|
||||
|
||||
// Error message should mention prefix mismatch
|
||||
if !strings.Contains(err.Error(), "prefix mismatch") {
|
||||
t.Errorf("Error should mention prefix mismatch, got: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user