Fix code review issues bd-19 through bd-23

- bd-19: Fix import zero-value field handling using JSON presence detection
- bd-20: Add --strict flag for dependency import failures
- bd-21: Simplify getNextID SQL query (reduce params from 4 to 2)
- bd-22: Add validation/warning for malformed issue IDs
- bd-23: Optimize export dependency queries (fix N+1 problem)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-10-12 15:30:11 -07:00
parent f048602d9f
commit 3440899850
6 changed files with 111 additions and 25 deletions

View File

@@ -48,14 +48,14 @@ Output to stdout by default, or use -o flag for file output.`,
return issues[i].ID < issues[j].ID
})
// Populate dependencies for each issue
// Populate dependencies for all issues in one query (avoids N+1 problem)
allDeps, err := store.GetAllDependencyRecords(ctx)
if err != nil {
fmt.Fprintf(os.Stderr, "Error getting dependencies: %v\n", err)
os.Exit(1)
}
for _, issue := range issues {
deps, err := store.GetDependencyRecords(ctx, issue.ID)
if err != nil {
fmt.Fprintf(os.Stderr, "Error getting dependencies for %s: %v\n", issue.ID, err)
os.Exit(1)
}
issue.Dependencies = deps
issue.Dependencies = allDeps[issue.ID]
}
// Open output