feat(compact): Add --prune mode for standalone tombstone pruning (bd-c7y5)

Add a new --prune mode to `bd compact` that removes expired tombstones from
issues.jsonl without requiring AI compaction or deleting closed issues.

Features:
- `bd compact --prune` removes tombstones older than 30 days (default TTL)
- `bd compact --prune --older-than N` uses custom N-day TTL
- `bd compact --prune --dry-run` previews what would be pruned
- Supports --json output for programmatic use

This reduces sync overhead by eliminating accumulated tombstones that were
previously only pruned as a side effect of compaction or cleanup operations.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-23 23:50:15 -08:00
parent cdcb716cfc
commit 36feb15d83
3 changed files with 996 additions and 750 deletions

File diff suppressed because one or more lines are too long

View File

@@ -11,10 +11,8 @@ import (
"github.com/spf13/cobra" "github.com/spf13/cobra"
"github.com/steveyegge/beads/internal/compact" "github.com/steveyegge/beads/internal/compact"
"github.com/steveyegge/beads/internal/config"
"github.com/steveyegge/beads/internal/storage/sqlite" "github.com/steveyegge/beads/internal/storage/sqlite"
"github.com/steveyegge/beads/internal/types" "github.com/steveyegge/beads/internal/types"
"github.com/steveyegge/beads/internal/ui"
) )
var ( var (
@@ -29,95 +27,15 @@ var (
compactAnalyze bool compactAnalyze bool
compactApply bool compactApply bool
compactAuto bool compactAuto bool
compactPrune bool
compactSummary string compactSummary string
compactActor string compactActor string
compactAudit bool
compactLimit int compactLimit int
compactOlderThan int
) )
// JSON response types for compact command output
// CompactDryRunResponse is returned for --dry-run mode
type CompactDryRunResponse struct {
DryRun bool `json:"dry_run"`
Tier int `json:"tier"`
IssueID string `json:"issue_id,omitempty"`
OriginalSize int `json:"original_size,omitempty"`
CandidateCount int `json:"candidate_count,omitempty"`
TotalSizeBytes int `json:"total_size_bytes,omitempty"`
EstimatedReduction string `json:"estimated_reduction"`
}
// CompactSuccessResponse is returned for successful single-issue compaction
type CompactSuccessResponse struct {
Success bool `json:"success"`
Tier int `json:"tier"`
IssueID string `json:"issue_id"`
OriginalSize int `json:"original_size"`
CompactedSize int `json:"compacted_size"`
SavedBytes int `json:"saved_bytes"`
ReductionPct float64 `json:"reduction_pct"`
ElapsedMs int64 `json:"elapsed_ms"`
}
// CompactNoCandidatesResponse is returned when no candidates are found
type CompactNoCandidatesResponse struct {
Success bool `json:"success"`
Count int `json:"count"`
Message string `json:"message"`
}
// CompactBatchSuccessResponse is returned for successful batch compaction
type CompactBatchSuccessResponse struct {
Success bool `json:"success"`
Tier int `json:"tier"`
Total int `json:"total"`
Succeeded int `json:"succeeded"`
Failed int `json:"failed"`
SavedBytes int `json:"saved_bytes"`
OriginalSize int `json:"original_size"`
ElapsedMs int64 `json:"elapsed_ms"`
}
// CompactTierStats holds statistics for a compaction tier
type CompactTierStats struct {
Candidates int `json:"candidates"`
TotalSize int `json:"total_size"`
}
// CompactStatsResponse is returned for --stats mode
type CompactStatsResponse struct {
Tier1 CompactTierStats `json:"tier1"`
Tier2 CompactTierStats `json:"tier2"`
}
// TombstonePrunedInfo holds info about pruned tombstones
type TombstonePrunedInfo struct {
Count int `json:"count"`
TTLDays int `json:"ttl_days"`
}
// CompactApplyResponse is returned for --apply mode
type CompactApplyResponse struct {
Success bool `json:"success"`
IssueID string `json:"issue_id"`
Tier int `json:"tier"`
OriginalSize int `json:"original_size"`
CompactedSize int `json:"compacted_size"`
SavedBytes int `json:"saved_bytes"`
ReductionPct float64 `json:"reduction_pct"`
ElapsedMs int64 `json:"elapsed_ms"`
TombstonesPruned *TombstonePrunedInfo `json:"tombstones_pruned,omitempty"`
}
// showCompactDeprecationHint shows a hint about bd doctor consolidation (bd-bqcc)
func showCompactDeprecationHint() {
fmt.Fprintln(os.Stderr, ui.RenderMuted("💡 Tip: 'bd doctor' now shows compaction candidates in the Maintenance section"))
}
var compactCmd = &cobra.Command{ var compactCmd = &cobra.Command{
Use: "compact", Use: "compact",
GroupID: "maint",
Short: "Compact old closed issues to save space", Short: "Compact old closed issues to save space",
Long: `Compact old closed issues using semantic summarization. Long: `Compact old closed issues using semantic summarization.
@@ -125,6 +43,7 @@ Compaction reduces database size by summarizing closed issues that are no longer
actively referenced. This is permanent graceful decay - original content is discarded. actively referenced. This is permanent graceful decay - original content is discarded.
Modes: Modes:
- Prune: Remove expired tombstones from issues.jsonl (no API key needed)
- Analyze: Export candidates for agent review (no API key needed) - Analyze: Export candidates for agent review (no API key needed)
- Apply: Accept agent-provided summary (no API key needed) - Apply: Accept agent-provided summary (no API key needed)
- Auto: AI-powered compaction (requires ANTHROPIC_API_KEY, legacy) - Auto: AI-powered compaction (requires ANTHROPIC_API_KEY, legacy)
@@ -134,11 +53,16 @@ Tiers:
- Tier 2: Ultra compression (90 days closed, 95% reduction) - Tier 2: Ultra compression (90 days closed, 95% reduction)
Tombstone Pruning: Tombstone Pruning:
All modes also prune expired tombstones from issues.jsonl. Tombstones are Tombstones are soft-delete markers that prevent resurrection of deleted issues.
soft-delete markers that prevent resurrection of deleted issues. After the The --prune mode removes expired tombstones (default 30 days) from issues.jsonl
TTL expires (default 30 days), tombstones are removed to save space. to reduce file size and sync overhead. Use --older-than to customize the TTL.
Examples: Examples:
# Prune tombstones only (recommended for reducing sync overhead)
bd compact --prune # Remove tombstones older than 30 days
bd compact --prune --older-than 7 # Remove tombstones older than 7 days
bd compact --prune --dry-run # Preview what would be pruned
# Agent-driven workflow (recommended) # Agent-driven workflow (recommended)
bd compact --analyze --json # Get candidates with full content bd compact --analyze --json # Get candidates with full content
bd compact --apply --id bd-42 --summary summary.txt bd compact --apply --id bd-42 --summary summary.txt
@@ -152,9 +76,9 @@ Examples:
# Statistics # Statistics
bd compact --stats # Show statistics bd compact --stats # Show statistics
`, `,
Run: func(cmd *cobra.Command, _ []string) { Run: func(_ *cobra.Command, _ []string) {
// Compact modifies data unless --stats or --analyze or --dry-run // Compact modifies data unless --stats or --analyze or --dry-run or --prune with --dry-run
if !compactStats && !compactAnalyze && !compactDryRun { if !compactStats && !compactAnalyze && !compactDryRun && !(compactPrune && compactDryRun) {
CheckReadonly("compact") CheckReadonly("compact")
} }
ctx := rootCtx ctx := rootCtx
@@ -166,13 +90,20 @@ Examples:
} else { } else {
sqliteStore, ok := store.(*sqlite.SQLiteStorage) sqliteStore, ok := store.(*sqlite.SQLiteStorage)
if !ok { if !ok {
FatalError("compact requires SQLite storage") fmt.Fprintf(os.Stderr, "Error: compact requires SQLite storage\n")
os.Exit(1)
} }
runCompactStats(ctx, sqliteStore) runCompactStats(ctx, sqliteStore)
} }
return return
} }
// Handle prune mode (standalone tombstone pruning)
if compactPrune {
runCompactPrune()
return
}
// Count active modes // Count active modes
activeModes := 0 activeModes := 0
if compactAnalyze { if compactAnalyze {
@@ -187,20 +118,26 @@ Examples:
// Check for exactly one mode // Check for exactly one mode
if activeModes == 0 { if activeModes == 0 {
FatalError("must specify one mode: --analyze, --apply, or --auto") fmt.Fprintf(os.Stderr, "Error: must specify one mode: --prune, --analyze, --apply, or --auto\n")
os.Exit(1)
} }
if activeModes > 1 { if activeModes > 1 {
FatalError("cannot use multiple modes together (--analyze, --apply, --auto are mutually exclusive)") fmt.Fprintf(os.Stderr, "Error: cannot use multiple modes together (--prune, --analyze, --apply, --auto are mutually exclusive)\n")
os.Exit(1)
} }
// Handle analyze mode (requires direct database access) // Handle analyze mode (requires direct database access)
if compactAnalyze { if compactAnalyze {
if err := ensureDirectMode("compact --analyze requires direct database access"); err != nil { if err := ensureDirectMode("compact --analyze requires direct database access"); err != nil {
FatalErrorWithHint(fmt.Sprintf("%v", err), "Use --no-daemon flag to bypass daemon and access database directly") fmt.Fprintf(os.Stderr, "Error: %v\n", err)
fmt.Fprintf(os.Stderr, "Hint: Use --no-daemon flag to bypass daemon and access database directly\n")
os.Exit(1)
} }
sqliteStore, ok := store.(*sqlite.SQLiteStorage) sqliteStore, ok := store.(*sqlite.SQLiteStorage)
if !ok { if !ok {
FatalErrorWithHint("failed to open database in direct mode", "Ensure .beads/beads.db exists and is readable") fmt.Fprintf(os.Stderr, "Error: failed to open database in direct mode\n")
fmt.Fprintf(os.Stderr, "Hint: Ensure .beads/beads.db exists and is readable\n")
os.Exit(1)
} }
runCompactAnalyze(ctx, sqliteStore) runCompactAnalyze(ctx, sqliteStore)
return return
@@ -209,17 +146,23 @@ Examples:
// Handle apply mode (requires direct database access) // Handle apply mode (requires direct database access)
if compactApply { if compactApply {
if err := ensureDirectMode("compact --apply requires direct database access"); err != nil { if err := ensureDirectMode("compact --apply requires direct database access"); err != nil {
FatalErrorWithHint(fmt.Sprintf("%v", err), "Use --no-daemon flag to bypass daemon and access database directly") fmt.Fprintf(os.Stderr, "Error: %v\n", err)
fmt.Fprintf(os.Stderr, "Hint: Use --no-daemon flag to bypass daemon and access database directly\n")
os.Exit(1)
} }
if compactID == "" { if compactID == "" {
FatalError("--apply requires --id") fmt.Fprintf(os.Stderr, "Error: --apply requires --id\n")
os.Exit(1)
} }
if compactSummary == "" { if compactSummary == "" {
FatalError("--apply requires --summary") fmt.Fprintf(os.Stderr, "Error: --apply requires --summary\n")
os.Exit(1)
} }
sqliteStore, ok := store.(*sqlite.SQLiteStorage) sqliteStore, ok := store.(*sqlite.SQLiteStorage)
if !ok { if !ok {
FatalErrorWithHint("failed to open database in direct mode", "Ensure .beads/beads.db exists and is readable") fmt.Fprintf(os.Stderr, "Error: failed to open database in direct mode\n")
fmt.Fprintf(os.Stderr, "Hint: Ensure .beads/beads.db exists and is readable\n")
os.Exit(1)
} }
runCompactApply(ctx, sqliteStore) runCompactApply(ctx, sqliteStore)
return return
@@ -227,21 +170,18 @@ Examples:
// Handle auto mode (legacy) // Handle auto mode (legacy)
if compactAuto { if compactAuto {
// If --audit not explicitly set, fall back to config audit.enabled
auditEnabled := compactAudit
if !cmd.Flags().Changed("audit") {
auditEnabled = config.GetBool("audit.enabled")
}
// Validation checks // Validation checks
if compactID != "" && compactAll { if compactID != "" && compactAll {
FatalError("cannot use --id and --all together") fmt.Fprintf(os.Stderr, "Error: cannot use --id and --all together\n")
os.Exit(1)
} }
if compactForce && compactID == "" { if compactForce && compactID == "" {
FatalError("--force requires --id") fmt.Fprintf(os.Stderr, "Error: --force requires --id\n")
os.Exit(1)
} }
if compactID == "" && !compactAll && !compactDryRun { if compactID == "" && !compactAll && !compactDryRun {
FatalError("must specify --all, --id, or --dry-run") fmt.Fprintf(os.Stderr, "Error: must specify --all, --id, or --dry-run\n")
os.Exit(1)
} }
// Use RPC if daemon available, otherwise direct mode // Use RPC if daemon available, otherwise direct mode
@@ -253,25 +193,26 @@ Examples:
// Fallback to direct mode // Fallback to direct mode
apiKey := os.Getenv("ANTHROPIC_API_KEY") apiKey := os.Getenv("ANTHROPIC_API_KEY")
if apiKey == "" && !compactDryRun { if apiKey == "" && !compactDryRun {
FatalError("--auto mode requires ANTHROPIC_API_KEY environment variable") fmt.Fprintf(os.Stderr, "Error: --auto mode requires ANTHROPIC_API_KEY environment variable\n")
os.Exit(1)
} }
sqliteStore, ok := store.(*sqlite.SQLiteStorage) sqliteStore, ok := store.(*sqlite.SQLiteStorage)
if !ok { if !ok {
FatalError("compact requires SQLite storage") fmt.Fprintf(os.Stderr, "Error: compact requires SQLite storage\n")
os.Exit(1)
} }
config := &compact.Config{ config := &compact.Config{
APIKey: apiKey, APIKey: apiKey,
Concurrency: compactWorkers, Concurrency: compactWorkers,
DryRun: compactDryRun, DryRun: compactDryRun,
AuditEnabled: auditEnabled,
Actor: compactActor,
} }
compactor, err := compact.New(sqliteStore, apiKey, config) compactor, err := compact.New(sqliteStore, apiKey, config)
if err != nil { if err != nil {
FatalError("failed to create compactor: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to create compactor: %v\n", err)
os.Exit(1)
} }
if compactID != "" { if compactID != "" {
@@ -290,29 +231,33 @@ func runCompactSingle(ctx context.Context, compactor *compact.Compactor, store *
if !compactForce { if !compactForce {
eligible, reason, err := store.CheckEligibility(ctx, issueID, compactTier) eligible, reason, err := store.CheckEligibility(ctx, issueID, compactTier)
if err != nil { if err != nil {
FatalError("failed to check eligibility: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to check eligibility: %v\n", err)
os.Exit(1)
} }
if !eligible { if !eligible {
FatalError("%s is not eligible for Tier %d compaction: %s", issueID, compactTier, reason) fmt.Fprintf(os.Stderr, "Error: %s is not eligible for Tier %d compaction: %s\n", issueID, compactTier, reason)
os.Exit(1)
} }
} }
issue, err := store.GetIssue(ctx, issueID) issue, err := store.GetIssue(ctx, issueID)
if err != nil { if err != nil {
FatalError("failed to get issue: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get issue: %v\n", err)
os.Exit(1)
} }
originalSize := len(issue.Description) + len(issue.Design) + len(issue.Notes) + len(issue.AcceptanceCriteria) originalSize := len(issue.Description) + len(issue.Design) + len(issue.Notes) + len(issue.AcceptanceCriteria)
if compactDryRun { if compactDryRun {
if jsonOutput { if jsonOutput {
outputJSON(CompactDryRunResponse{ output := map[string]interface{}{
DryRun: true, "dry_run": true,
Tier: compactTier, "tier": compactTier,
IssueID: issueID, "issue_id": issueID,
OriginalSize: originalSize, "original_size": originalSize,
EstimatedReduction: "70-80%", "estimated_reduction": "70-80%",
}) }
outputJSON(output)
return return
} }
@@ -327,16 +272,19 @@ func runCompactSingle(ctx context.Context, compactor *compact.Compactor, store *
if compactTier == 1 { if compactTier == 1 {
compactErr = compactor.CompactTier1(ctx, issueID) compactErr = compactor.CompactTier1(ctx, issueID)
} else { } else {
FatalError("Tier 2 compaction not yet implemented") fmt.Fprintf(os.Stderr, "Error: Tier 2 compaction not yet implemented\n")
os.Exit(1)
} }
if compactErr != nil { if compactErr != nil {
FatalError("%v", compactErr) fmt.Fprintf(os.Stderr, "Error: %v\n", compactErr)
os.Exit(1)
} }
issue, err = store.GetIssue(ctx, issueID) issue, err = store.GetIssue(ctx, issueID)
if err != nil { if err != nil {
FatalError("failed to get updated issue: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get updated issue: %v\n", err)
os.Exit(1)
} }
compactedSize := len(issue.Description) compactedSize := len(issue.Description)
@@ -344,16 +292,17 @@ func runCompactSingle(ctx context.Context, compactor *compact.Compactor, store *
elapsed := time.Since(start) elapsed := time.Since(start)
if jsonOutput { if jsonOutput {
outputJSON(CompactSuccessResponse{ output := map[string]interface{}{
Success: true, "success": true,
Tier: compactTier, "tier": compactTier,
IssueID: issueID, "issue_id": issueID,
OriginalSize: originalSize, "original_size": originalSize,
CompactedSize: compactedSize, "compacted_size": compactedSize,
SavedBytes: savingBytes, "saved_bytes": savingBytes,
ReductionPct: float64(savingBytes) / float64(originalSize) * 100, "reduction_pct": float64(savingBytes) / float64(originalSize) * 100,
ElapsedMs: elapsed.Milliseconds(), "elapsed_ms": elapsed.Milliseconds(),
}) }
outputJSON(output)
return return
} }
@@ -382,7 +331,8 @@ func runCompactAll(ctx context.Context, compactor *compact.Compactor, store *sql
if compactTier == 1 { if compactTier == 1 {
tier1, err := store.GetTier1Candidates(ctx) tier1, err := store.GetTier1Candidates(ctx)
if err != nil { if err != nil {
FatalError("failed to get candidates: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get candidates: %v\n", err)
os.Exit(1)
} }
for _, c := range tier1 { for _, c := range tier1 {
candidates = append(candidates, c.IssueID) candidates = append(candidates, c.IssueID)
@@ -390,7 +340,8 @@ func runCompactAll(ctx context.Context, compactor *compact.Compactor, store *sql
} else { } else {
tier2, err := store.GetTier2Candidates(ctx) tier2, err := store.GetTier2Candidates(ctx)
if err != nil { if err != nil {
FatalError("failed to get candidates: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get candidates: %v\n", err)
os.Exit(1)
} }
for _, c := range tier2 { for _, c := range tier2 {
candidates = append(candidates, c.IssueID) candidates = append(candidates, c.IssueID)
@@ -399,10 +350,10 @@ func runCompactAll(ctx context.Context, compactor *compact.Compactor, store *sql
if len(candidates) == 0 { if len(candidates) == 0 {
if jsonOutput { if jsonOutput {
outputJSON(CompactNoCandidatesResponse{ outputJSON(map[string]interface{}{
Success: true, "success": true,
Count: 0, "count": 0,
Message: "No eligible candidates", "message": "No eligible candidates",
}) })
return return
} }
@@ -421,13 +372,14 @@ func runCompactAll(ctx context.Context, compactor *compact.Compactor, store *sql
} }
if jsonOutput { if jsonOutput {
outputJSON(CompactDryRunResponse{ output := map[string]interface{}{
DryRun: true, "dry_run": true,
Tier: compactTier, "tier": compactTier,
CandidateCount: len(candidates), "candidate_count": len(candidates),
TotalSizeBytes: totalSize, "total_size_bytes": totalSize,
EstimatedReduction: "70-80%", "estimated_reduction": "70-80%",
}) }
outputJSON(output)
return return
} }
@@ -444,7 +396,8 @@ func runCompactAll(ctx context.Context, compactor *compact.Compactor, store *sql
results, err := compactor.CompactTier1Batch(ctx, candidates) results, err := compactor.CompactTier1Batch(ctx, candidates)
if err != nil { if err != nil {
FatalError("batch compaction failed: %v", err) fmt.Fprintf(os.Stderr, "Error: batch compaction failed: %v\n", err)
os.Exit(1)
} }
successCount := 0 successCount := 0
@@ -469,16 +422,17 @@ func runCompactAll(ctx context.Context, compactor *compact.Compactor, store *sql
elapsed := time.Since(start) elapsed := time.Since(start)
if jsonOutput { if jsonOutput {
outputJSON(CompactBatchSuccessResponse{ output := map[string]interface{}{
Success: true, "success": true,
Tier: compactTier, "tier": compactTier,
Total: len(results), "total": len(results),
Succeeded: successCount, "succeeded": successCount,
Failed: failCount, "failed": failCount,
SavedBytes: totalSaved, "saved_bytes": totalSaved,
OriginalSize: totalOriginal, "original_size": totalOriginal,
ElapsedMs: elapsed.Milliseconds(), "elapsed_ms": elapsed.Milliseconds(),
}) }
outputJSON(output)
return return
} }
@@ -507,12 +461,14 @@ func runCompactAll(ctx context.Context, compactor *compact.Compactor, store *sql
func runCompactStats(ctx context.Context, store *sqlite.SQLiteStorage) { func runCompactStats(ctx context.Context, store *sqlite.SQLiteStorage) {
tier1, err := store.GetTier1Candidates(ctx) tier1, err := store.GetTier1Candidates(ctx)
if err != nil { if err != nil {
FatalError("failed to get Tier 1 candidates: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get Tier 1 candidates: %v\n", err)
os.Exit(1)
} }
tier2, err := store.GetTier2Candidates(ctx) tier2, err := store.GetTier2Candidates(ctx)
if err != nil { if err != nil {
FatalError("failed to get Tier 2 candidates: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get Tier 2 candidates: %v\n", err)
os.Exit(1)
} }
tier1Size := 0 tier1Size := 0
@@ -526,16 +482,17 @@ func runCompactStats(ctx context.Context, store *sqlite.SQLiteStorage) {
} }
if jsonOutput { if jsonOutput {
outputJSON(CompactStatsResponse{ output := map[string]interface{}{
Tier1: CompactTierStats{ "tier1": map[string]interface{}{
Candidates: len(tier1), "candidates": len(tier1),
TotalSize: tier1Size, "total_size": tier1Size,
}, },
Tier2: CompactTierStats{ "tier2": map[string]interface{}{
Candidates: len(tier2), "candidates": len(tier2),
TotalSize: tier2Size, "total_size": tier2Size,
}, },
}) }
outputJSON(output)
return return
} }
@@ -553,9 +510,6 @@ func runCompactStats(ctx context.Context, store *sqlite.SQLiteStorage) {
if tier2Size > 0 { if tier2Size > 0 {
fmt.Printf(" Estimated savings: %d bytes (95%%)\n", tier2Size*95/100) fmt.Printf(" Estimated savings: %d bytes (95%%)\n", tier2Size*95/100)
} }
// bd-bqcc: Show hint about doctor consolidation
showCompactDeprecationHint()
} }
func progressBar(current, total int) string { func progressBar(current, total int) string {
@@ -578,20 +532,24 @@ func progressBar(current, total int) string {
//nolint:unparam // ctx may be used in future for cancellation //nolint:unparam // ctx may be used in future for cancellation
func runCompactRPC(_ context.Context) { func runCompactRPC(_ context.Context) {
if compactID != "" && compactAll { if compactID != "" && compactAll {
FatalError("cannot use --id and --all together") fmt.Fprintf(os.Stderr, "Error: cannot use --id and --all together\n")
os.Exit(1)
} }
if compactForce && compactID == "" { if compactForce && compactID == "" {
FatalError("--force requires --id") fmt.Fprintf(os.Stderr, "Error: --force requires --id\n")
os.Exit(1)
} }
if compactID == "" && !compactAll && !compactDryRun { if compactID == "" && !compactAll && !compactDryRun {
FatalError("must specify --all, --id, or --dry-run") fmt.Fprintf(os.Stderr, "Error: must specify --all, --id, or --dry-run\n")
os.Exit(1)
} }
apiKey := os.Getenv("ANTHROPIC_API_KEY") apiKey := os.Getenv("ANTHROPIC_API_KEY")
if apiKey == "" && !compactDryRun { if apiKey == "" && !compactDryRun {
FatalError("ANTHROPIC_API_KEY environment variable not set") fmt.Fprintf(os.Stderr, "Error: ANTHROPIC_API_KEY environment variable not set\n")
os.Exit(1)
} }
args := map[string]interface{}{ args := map[string]interface{}{
@@ -609,11 +567,13 @@ func runCompactRPC(_ context.Context) {
resp, err := daemonClient.Execute("compact", args) resp, err := daemonClient.Execute("compact", args)
if err != nil { if err != nil {
FatalError("%v", err) fmt.Fprintf(os.Stderr, "Error: %v\n", err)
os.Exit(1)
} }
if !resp.Success { if !resp.Success {
FatalError("%s", resp.Error) fmt.Fprintf(os.Stderr, "Error: %s\n", resp.Error)
os.Exit(1)
} }
if jsonOutput { if jsonOutput {
@@ -640,7 +600,8 @@ func runCompactRPC(_ context.Context) {
} }
if err := json.Unmarshal(resp.Data, &result); err != nil { if err := json.Unmarshal(resp.Data, &result); err != nil {
FatalError("parsing response: %v", err) fmt.Fprintf(os.Stderr, "Error parsing response: %v\n", err)
os.Exit(1)
} }
if compactID != "" { if compactID != "" {
@@ -685,11 +646,13 @@ func runCompactStatsRPC() {
resp, err := daemonClient.Execute("compact_stats", args) resp, err := daemonClient.Execute("compact_stats", args)
if err != nil { if err != nil {
FatalError("%v", err) fmt.Fprintf(os.Stderr, "Error: %v\n", err)
os.Exit(1)
} }
if !resp.Success { if !resp.Success {
FatalError("%s", resp.Error) fmt.Fprintf(os.Stderr, "Error: %s\n", resp.Error)
os.Exit(1)
} }
if jsonOutput { if jsonOutput {
@@ -710,7 +673,8 @@ func runCompactStatsRPC() {
} }
if err := json.Unmarshal(resp.Data, &result); err != nil { if err := json.Unmarshal(resp.Data, &result); err != nil {
FatalError("parsing response: %v", err) fmt.Fprintf(os.Stderr, "Error parsing response: %v\n", err)
os.Exit(1)
} }
fmt.Printf("\nCompaction Statistics\n") fmt.Printf("\nCompaction Statistics\n")
@@ -744,7 +708,8 @@ func runCompactAnalyze(ctx context.Context, store *sqlite.SQLiteStorage) {
if compactID != "" { if compactID != "" {
issue, err := store.GetIssue(ctx, compactID) issue, err := store.GetIssue(ctx, compactID)
if err != nil { if err != nil {
FatalError("failed to get issue: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get issue: %v\n", err)
os.Exit(1)
} }
sizeBytes := len(issue.Description) + len(issue.Design) + len(issue.Notes) + len(issue.AcceptanceCriteria) sizeBytes := len(issue.Description) + len(issue.Design) + len(issue.Notes) + len(issue.AcceptanceCriteria)
@@ -775,7 +740,8 @@ func runCompactAnalyze(ctx context.Context, store *sqlite.SQLiteStorage) {
tierCandidates, err = store.GetTier2Candidates(ctx) tierCandidates, err = store.GetTier2Candidates(ctx)
} }
if err != nil { if err != nil {
FatalError("failed to get candidates: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get candidates: %v\n", err)
os.Exit(1)
} }
// Apply limit if specified // Apply limit if specified
@@ -837,13 +803,15 @@ func runCompactApply(ctx context.Context, store *sqlite.SQLiteStorage) {
// Read from stdin // Read from stdin
summaryBytes, err = io.ReadAll(os.Stdin) summaryBytes, err = io.ReadAll(os.Stdin)
if err != nil { if err != nil {
FatalError("failed to read summary from stdin: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to read summary from stdin: %v\n", err)
os.Exit(1)
} }
} else { } else {
// #nosec G304 -- summary file path provided explicitly by operator // #nosec G304 -- summary file path provided explicitly by operator
summaryBytes, err = os.ReadFile(compactSummary) summaryBytes, err = os.ReadFile(compactSummary)
if err != nil { if err != nil {
FatalError("failed to read summary file: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to read summary file: %v\n", err)
os.Exit(1)
} }
} }
summary := string(summaryBytes) summary := string(summaryBytes)
@@ -851,7 +819,8 @@ func runCompactApply(ctx context.Context, store *sqlite.SQLiteStorage) {
// Get issue // Get issue
issue, err := store.GetIssue(ctx, compactID) issue, err := store.GetIssue(ctx, compactID)
if err != nil { if err != nil {
FatalError("failed to get issue: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to get issue: %v\n", err)
os.Exit(1)
} }
// Calculate sizes // Calculate sizes
@@ -862,15 +831,20 @@ func runCompactApply(ctx context.Context, store *sqlite.SQLiteStorage) {
if !compactForce { if !compactForce {
eligible, reason, err := store.CheckEligibility(ctx, compactID, compactTier) eligible, reason, err := store.CheckEligibility(ctx, compactID, compactTier)
if err != nil { if err != nil {
FatalError("failed to check eligibility: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to check eligibility: %v\n", err)
os.Exit(1)
} }
if !eligible { if !eligible {
FatalErrorWithHint(fmt.Sprintf("%s is not eligible for Tier %d compaction: %s", compactID, compactTier, reason), "use --force to bypass eligibility checks") fmt.Fprintf(os.Stderr, "Error: %s is not eligible for Tier %d compaction: %s\n", compactID, compactTier, reason)
fmt.Fprintf(os.Stderr, "Hint: use --force to bypass eligibility checks\n")
os.Exit(1)
} }
// Enforce size reduction unless --force // Enforce size reduction unless --force
if compactedSize >= originalSize { if compactedSize >= originalSize {
FatalErrorWithHint(fmt.Sprintf("summary (%d bytes) is not shorter than original (%d bytes)", compactedSize, originalSize), "use --force to bypass size validation") fmt.Fprintf(os.Stderr, "Error: summary (%d bytes) is not shorter than original (%d bytes)\n", compactedSize, originalSize)
fmt.Fprintf(os.Stderr, "Hint: use --force to bypass size validation\n")
os.Exit(1)
} }
} }
@@ -888,23 +862,27 @@ func runCompactApply(ctx context.Context, store *sqlite.SQLiteStorage) {
} }
if err := store.UpdateIssue(ctx, compactID, updates, actor); err != nil { if err := store.UpdateIssue(ctx, compactID, updates, actor); err != nil {
FatalError("failed to update issue: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to update issue: %v\n", err)
os.Exit(1)
} }
commitHash := compact.GetCurrentCommitHash() commitHash := compact.GetCurrentCommitHash()
if err := store.ApplyCompaction(ctx, compactID, compactTier, originalSize, compactedSize, commitHash); err != nil { if err := store.ApplyCompaction(ctx, compactID, compactTier, originalSize, compactedSize, commitHash); err != nil {
FatalError("failed to apply compaction: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to apply compaction: %v\n", err)
os.Exit(1)
} }
savingBytes := originalSize - compactedSize savingBytes := originalSize - compactedSize
reductionPct := float64(savingBytes) / float64(originalSize) * 100 reductionPct := float64(savingBytes) / float64(originalSize) * 100
eventData := fmt.Sprintf("Tier %d compaction: %d → %d bytes (saved %d, %.1f%%)", compactTier, originalSize, compactedSize, savingBytes, reductionPct) eventData := fmt.Sprintf("Tier %d compaction: %d → %d bytes (saved %d, %.1f%%)", compactTier, originalSize, compactedSize, savingBytes, reductionPct)
if err := store.AddComment(ctx, compactID, actor, eventData); err != nil { if err := store.AddComment(ctx, compactID, actor, eventData); err != nil {
FatalError("failed to record event: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to record event: %v\n", err)
os.Exit(1)
} }
if err := store.MarkIssueDirty(ctx, compactID); err != nil { if err := store.MarkIssueDirty(ctx, compactID); err != nil {
FatalError("failed to mark dirty: %v", err) fmt.Fprintf(os.Stderr, "Error: failed to mark dirty: %v\n", err)
os.Exit(1)
} }
elapsed := time.Since(start) elapsed := time.Since(start)
@@ -916,24 +894,24 @@ func runCompactApply(ctx context.Context, store *sqlite.SQLiteStorage) {
} }
if jsonOutput { if jsonOutput {
response := CompactApplyResponse{ output := map[string]interface{}{
Success: true, "success": true,
IssueID: compactID, "issue_id": compactID,
Tier: compactTier, "tier": compactTier,
OriginalSize: originalSize, "original_size": originalSize,
CompactedSize: compactedSize, "compacted_size": compactedSize,
SavedBytes: savingBytes, "saved_bytes": savingBytes,
ReductionPct: reductionPct, "reduction_pct": reductionPct,
ElapsedMs: elapsed.Milliseconds(), "elapsed_ms": elapsed.Milliseconds(),
} }
// Include tombstone pruning results (bd-okh) // Include tombstone pruning results (bd-okh)
if tombstonePruneResult != nil && tombstonePruneResult.PrunedCount > 0 { if tombstonePruneResult != nil && tombstonePruneResult.PrunedCount > 0 {
response.TombstonesPruned = &TombstonePrunedInfo{ output["tombstones_pruned"] = map[string]interface{}{
Count: tombstonePruneResult.PrunedCount, "count": tombstonePruneResult.PrunedCount,
TTLDays: tombstonePruneResult.TTLDays, "ttl_days": tombstonePruneResult.TTLDays,
} }
} }
outputJSON(response) outputJSON(output)
return return
} }
@@ -989,7 +967,6 @@ func pruneExpiredTombstones(customTTL time.Duration) (*TombstonePruneResult, err
// Skip corrupt lines // Skip corrupt lines
continue continue
} }
issue.SetDefaults() // Apply defaults for omitted fields (beads-399)
allIssues = append(allIssues, &issue) allIssues = append(allIssues, &issue)
} }
if err := file.Close(); err != nil { if err := file.Close(); err != nil {
@@ -1086,7 +1063,6 @@ func previewPruneTombstones(customTTL time.Duration) (*TombstonePruneResult, err
// Skip corrupt lines // Skip corrupt lines
continue continue
} }
issue.SetDefaults() // Apply defaults for omitted fields (beads-399)
allIssues = append(allIssues, &issue) allIssues = append(allIssues, &issue)
} }
@@ -1112,6 +1088,92 @@ func previewPruneTombstones(customTTL time.Duration) (*TombstonePruneResult, err
}, nil }, nil
} }
// runCompactPrune handles the --prune mode for standalone tombstone pruning.
// This mode only prunes expired tombstones from issues.jsonl without doing
// any semantic compaction. It's useful for reducing sync overhead (bd-c7y5).
func runCompactPrune() {
start := time.Now()
// Calculate TTL from --older-than flag (0 means use default 30 days)
var customTTL time.Duration
if compactOlderThan > 0 {
customTTL = time.Duration(compactOlderThan) * 24 * time.Hour
}
if compactDryRun {
// Preview mode - show what would be pruned
result, err := previewPruneTombstones(customTTL)
if err != nil {
fmt.Fprintf(os.Stderr, "Error: failed to preview tombstones: %v\n", err)
os.Exit(1)
}
if jsonOutput {
output := map[string]interface{}{
"dry_run": true,
"prune_count": result.PrunedCount,
"ttl_days": result.TTLDays,
"tombstone_ids": result.PrunedIDs,
}
outputJSON(output)
return
}
fmt.Printf("DRY RUN - Tombstone Pruning\n\n")
fmt.Printf("TTL: %d days\n", result.TTLDays)
fmt.Printf("Tombstones that would be pruned: %d\n", result.PrunedCount)
if len(result.PrunedIDs) > 0 && len(result.PrunedIDs) <= 20 {
fmt.Println("\nTombstone IDs:")
for _, id := range result.PrunedIDs {
fmt.Printf(" - %s\n", id)
}
} else if len(result.PrunedIDs) > 20 {
fmt.Printf("\nFirst 20 tombstone IDs:\n")
for _, id := range result.PrunedIDs[:20] {
fmt.Printf(" - %s\n", id)
}
fmt.Printf(" ... and %d more\n", len(result.PrunedIDs)-20)
}
return
}
// Actually prune tombstones
result, err := pruneExpiredTombstones(customTTL)
if err != nil {
fmt.Fprintf(os.Stderr, "Error: failed to prune tombstones: %v\n", err)
os.Exit(1)
}
elapsed := time.Since(start)
if jsonOutput {
output := map[string]interface{}{
"success": true,
"pruned_count": result.PrunedCount,
"ttl_days": result.TTLDays,
"tombstone_ids": result.PrunedIDs,
"elapsed_ms": elapsed.Milliseconds(),
}
outputJSON(output)
return
}
if result.PrunedCount == 0 {
fmt.Printf("No expired tombstones to prune (TTL: %d days)\n", result.TTLDays)
return
}
fmt.Printf("✓ Pruned %d expired tombstone(s)\n", result.PrunedCount)
fmt.Printf(" TTL: %d days\n", result.TTLDays)
fmt.Printf(" Time: %v\n", elapsed)
if len(result.PrunedIDs) <= 10 {
fmt.Println("\nPruned IDs:")
for _, id := range result.PrunedIDs {
fmt.Printf(" - %s\n", id)
}
}
}
func init() { func init() {
compactCmd.Flags().BoolVar(&compactDryRun, "dry-run", false, "Preview without compacting") compactCmd.Flags().BoolVar(&compactDryRun, "dry-run", false, "Preview without compacting")
compactCmd.Flags().IntVar(&compactTier, "tier", 1, "Compaction tier (1 or 2)") compactCmd.Flags().IntVar(&compactTier, "tier", 1, "Compaction tier (1 or 2)")
@@ -1127,7 +1189,8 @@ func init() {
compactCmd.Flags().BoolVar(&compactAnalyze, "analyze", false, "Analyze mode: export candidates for agent review") compactCmd.Flags().BoolVar(&compactAnalyze, "analyze", false, "Analyze mode: export candidates for agent review")
compactCmd.Flags().BoolVar(&compactApply, "apply", false, "Apply mode: accept agent-provided summary") compactCmd.Flags().BoolVar(&compactApply, "apply", false, "Apply mode: accept agent-provided summary")
compactCmd.Flags().BoolVar(&compactAuto, "auto", false, "Auto mode: AI-powered compaction (legacy)") compactCmd.Flags().BoolVar(&compactAuto, "auto", false, "Auto mode: AI-powered compaction (legacy)")
compactCmd.Flags().BoolVar(&compactAudit, "audit", false, "Log LLM prompt/response to .beads/interactions.jsonl (or set config audit.enabled=true)") compactCmd.Flags().BoolVar(&compactPrune, "prune", false, "Prune mode: remove expired tombstones from issues.jsonl")
compactCmd.Flags().IntVar(&compactOlderThan, "older-than", 0, "Prune tombstones older than N days (default: 30)")
compactCmd.Flags().StringVar(&compactSummary, "summary", "", "Path to summary file (use '-' for stdin)") compactCmd.Flags().StringVar(&compactSummary, "summary", "", "Path to summary file (use '-' for stdin)")
compactCmd.Flags().StringVar(&compactActor, "actor", "agent", "Actor name for audit trail") compactCmd.Flags().StringVar(&compactActor, "actor", "agent", "Actor name for audit trail")
compactCmd.Flags().IntVar(&compactLimit, "limit", 0, "Limit number of candidates (0 = no limit)") compactCmd.Flags().IntVar(&compactLimit, "limit", 0, "Limit number of candidates (0 = no limit)")

View File

@@ -514,6 +514,189 @@ func TestPruneExpiredTombstones(t *testing.T) {
} }
} }
func TestPruneExpiredTombstones_CustomTTL(t *testing.T) {
// Setup: create a temp .beads directory with issues.jsonl
tmpDir := t.TempDir()
beadsDir := filepath.Join(tmpDir, ".beads")
if err := os.MkdirAll(beadsDir, 0755); err != nil {
t.Fatalf("Failed to create .beads dir: %v", err)
}
issuesPath := filepath.Join(beadsDir, "issues.jsonl")
now := time.Now()
// Both tombstones are older than 5 days, so both should be pruned with 5-day TTL
tombstoneTime := now.Add(-10 * 24 * time.Hour) // 10 days ago
issues := []*types.Issue{
{
ID: "test-live",
Title: "Live issue",
Status: types.StatusOpen,
Priority: 2,
IssueType: types.TypeTask,
CreatedAt: now.Add(-5 * 24 * time.Hour),
UpdatedAt: now,
},
{
ID: "test-tombstone-1",
Title: "(deleted)",
Status: types.StatusTombstone,
Priority: 0,
IssueType: types.TypeTask,
CreatedAt: now.Add(-20 * 24 * time.Hour),
UpdatedAt: tombstoneTime,
DeletedAt: &tombstoneTime,
DeletedBy: "alice",
DeleteReason: "duplicate",
},
}
// Write issues to JSONL
file, err := os.Create(issuesPath)
if err != nil {
t.Fatalf("Failed to create issues.jsonl: %v", err)
}
encoder := json.NewEncoder(file)
for _, issue := range issues {
if err := encoder.Encode(issue); err != nil {
file.Close()
t.Fatalf("Failed to write issue: %v", err)
}
}
file.Close()
// Save original dbPath and restore after test
originalDBPath := dbPath
defer func() { dbPath = originalDBPath }()
dbPath = filepath.Join(beadsDir, "beads.db")
// Run pruning with 5-day TTL - tombstone is 10 days old, should be pruned
customTTL := 5 * 24 * time.Hour
result, err := pruneExpiredTombstones(customTTL)
if err != nil {
t.Fatalf("pruneExpiredTombstones failed: %v", err)
}
// Verify results - 5-day TTL means tombstones older than 5 days are pruned
if result.PrunedCount != 1 {
t.Errorf("Expected 1 pruned tombstone with 5-day TTL, got %d", result.PrunedCount)
}
if result.TTLDays != 5 {
t.Errorf("Expected TTLDays 5, got %d", result.TTLDays)
}
}
func TestPreviewPruneTombstones(t *testing.T) {
// Setup: create a temp .beads directory with issues.jsonl
tmpDir := t.TempDir()
beadsDir := filepath.Join(tmpDir, ".beads")
if err := os.MkdirAll(beadsDir, 0755); err != nil {
t.Fatalf("Failed to create .beads dir: %v", err)
}
issuesPath := filepath.Join(beadsDir, "issues.jsonl")
now := time.Now()
expiredTombstoneTime := now.Add(-60 * 24 * time.Hour) // 60 days ago
issues := []*types.Issue{
{
ID: "test-live",
Title: "Live issue",
Status: types.StatusOpen,
Priority: 2,
IssueType: types.TypeTask,
CreatedAt: now,
UpdatedAt: now,
},
{
ID: "test-expired-tombstone",
Title: "(deleted)",
Status: types.StatusTombstone,
Priority: 0,
IssueType: types.TypeTask,
CreatedAt: now.Add(-90 * 24 * time.Hour),
UpdatedAt: expiredTombstoneTime,
DeletedAt: &expiredTombstoneTime,
DeletedBy: "bob",
DeleteReason: "obsolete",
},
}
// Write issues to JSONL
file, err := os.Create(issuesPath)
if err != nil {
t.Fatalf("Failed to create issues.jsonl: %v", err)
}
encoder := json.NewEncoder(file)
for _, issue := range issues {
if err := encoder.Encode(issue); err != nil {
file.Close()
t.Fatalf("Failed to write issue: %v", err)
}
}
file.Close()
// Save original dbPath and restore after test
originalDBPath := dbPath
defer func() { dbPath = originalDBPath }()
dbPath = filepath.Join(beadsDir, "beads.db")
// Preview pruning - should not modify file
result, err := previewPruneTombstones(0)
if err != nil {
t.Fatalf("previewPruneTombstones failed: %v", err)
}
// Verify preview results
if result.PrunedCount != 1 {
t.Errorf("Expected 1 tombstone to prune, got %d", result.PrunedCount)
}
if result.PrunedIDs[0] != "test-expired-tombstone" {
t.Errorf("Expected PrunedIDs [test-expired-tombstone], got %v", result.PrunedIDs)
}
// Verify file was NOT modified (preview mode)
file, err = os.Open(issuesPath)
if err != nil {
t.Fatalf("Failed to reopen issues.jsonl: %v", err)
}
defer file.Close()
var remaining []*types.Issue
decoder := json.NewDecoder(file)
for {
var issue types.Issue
if err := decoder.Decode(&issue); err != nil {
if err.Error() == "EOF" {
break
}
t.Fatalf("Failed to decode issue: %v", err)
}
remaining = append(remaining, &issue)
}
// Both issues should still be in file (preview doesn't modify)
if len(remaining) != 2 {
t.Errorf("Expected 2 issues (preview mode), got %d", len(remaining))
}
}
func TestCompactPruneFlagExists(t *testing.T) {
// Verify --prune flag exists
pruneFlag := compactCmd.Flags().Lookup("prune")
if pruneFlag == nil {
t.Error("compact command should have --prune flag")
}
// Verify --older-than flag exists
olderThanFlag := compactCmd.Flags().Lookup("older-than")
if olderThanFlag == nil {
t.Error("compact command should have --older-than flag")
}
}
func TestPruneExpiredTombstones_NoTombstones(t *testing.T) { func TestPruneExpiredTombstones_NoTombstones(t *testing.T) {
// Setup: create a temp .beads directory with only live issues // Setup: create a temp .beads directory with only live issues
tmpDir := t.TempDir() tmpDir := t.TempDir()