johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use nullish coalescing to fix priority 0 bug display

Browse Source 
Fixes display bug where P0 issues were shown as P2 due to JavaScript treating 0 as falsy. Also adds P0 to the priority filter dropdown.

Changes:
- Replace || with ?? operator for priority defaults in monitor UI
- Add P0 option to priority filter selector

Co-authored-by: Zack Rosen <zjrosen@users.noreply.github.com>
This commit is contained in:
Zack Rosen
2025-11-23 17:58:58 -05:00
committed by GitHub
parent ced8033979
commit 39ef32a9ac
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
examples/monitor-webui/web/index.html
View File

@@ -64,6 +64,7 @@
<div class="filter-group">
<label for="filter-priority">Priority</label>
<select id="filter-priority" multiple>
<option value="0" selected>P0</option>
<option value="1" selected>P1</option>
<option value="2" selected>P2</option>
<option value="3" selected>P3</option>

8
examples/monitor-webui/web/static/js/app.js
View File

@@ -127,18 +127,18 @@ function renderIssues(issues) {
// Render table view
tbody.innerHTML = issues.map(issue => {
const statusClass = 'status-' + (issue.status || 'open').toLowerCase().replace('_', '-');
const priorityClass = 'priority-' + (issue.priority || 2);
return '<tr onclick="showIssueDetail(\'' + issue.id + '\')"><td>' + issue.id + '</td><td>' + issue.title + '</td><td class="' + statusClass + '">' + (issue.status || 'open') + '</td><td class="' + priorityClass + '">P' + (issue.priority || 2) + '</td><td>' + (issue.issue_type || 'task') + '</td><td>' + (issue.assignee || '-') + '</td></tr>';
const priorityClass = 'priority-' + (issue.priority ?? 2);
return '<tr onclick="showIssueDetail(\'' + issue.id + '\')"><td>' + issue.id + '</td><td>' + issue.title + '</td><td class="' + statusClass + '">' + (issue.status || 'open') + '</td><td class="' + priorityClass + '">P' + (issue.priority ?? 2) + '</td><td>' + (issue.issue_type || 'task') + '</td><td>' + (issue.assignee || '-') + '</td></tr>';
}).join('');
// Render card view for mobile
cardView.innerHTML = issues.map(issue => {
const statusClass = 'status-' + (issue.status || 'open').toLowerCase().replace('_', '-');
const priorityClass = 'priority-' + (issue.priority || 2);
const priorityClass = 'priority-' + (issue.priority ?? 2);
let html = '<div class="issue-card" onclick="showIssueDetail(\'' + issue.id + '\')">';
html += '<div class="issue-card-header">';
html += '<span class="issue-card-id">' + issue.id + '</span>';
html += '<span class="' + priorityClass + '">P' + (issue.priority || 2) + '</span>';
html += '<span class="' + priorityClass + '">P' + (issue.priority ?? 2) + '</span>';
html += '</div>';
html += '<h3 class="issue-card-title">' + issue.title + '</h3>';
html += '<div class="issue-card-meta">';