johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix test failures: add missing issue_prefix config and use valid bd- prefixes

Browse Source 
- Add SetConfig('issue_prefix', 'bd') to collision tests (bd-166)
- Update test cases to use 'bd-' prefix instead of invalid custom IDs (bd-177)
- Fixes 5 test failures in TestDetectCollisions, TestScoreCollisions, TestRemapCollisions, TestCreateIssues

All tests now pass.

Amp-Thread-ID: https://ampcode.com/threads/T-b2413b0e-2720-45b1-9b3d-acaa7d4cf9b4
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
2025-10-27 13:11:45 -07:00
parent 228ef67ebf
commit 49dac2b767
3 changed files with 43 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
internal/storage/sqlite/sqlite_test.go
View File

@@ -286,8 +286,8 @@ func (h *createIssuesTestHelper) assertNoAutoGenID(issues []*types.Issue, wantEr
if issue == nil {
continue
}
hasCustomID := issue.ID != "" && (issue.ID == "custom-1" || issue.ID == "custom-2" ||
issue.ID == "duplicate-id" || issue.ID == "existing-id")
hasCustomID := issue.ID != "" && (issue.ID == "bd-100" || issue.ID == "bd-200" ||
issue.ID == "bd-999" || issue.ID == "bd-existing")
if !hasCustomID && issue.ID != "" {
h.t.Errorf("issue %d: ID should not be auto-generated on error, got %s", i, issue.ID)
}
@@ -346,21 +346,21 @@ func TestCreateIssues(t *testing.T) {
},
},
{
name: "mixed ID assignment - explicit and auto-generated",
issues: []*types.Issue{
h.newIssue("custom-1", "Custom ID 1", types.StatusOpen, 1, types.TypeTask, nil),
h.newIssue("", "Auto ID", types.StatusOpen, 1, types.TypeTask, nil),
h.newIssue("custom-2", "Custom ID 2", types.StatusOpen, 1, types.TypeTask, nil),
},
wantErr: false,
checkFunc: func(t *testing.T, h *createIssuesTestHelper, issues []*types.Issue) {
h.assertCount(issues, 3)
h.assertEqual("custom-1", issues[0].ID, "ID")
if issues[1].ID == "" || issues[1].ID == "custom-1" || issues[1].ID == "custom-2" {
t.Errorf("expected auto-generated ID, got %s", issues[1].ID)
}
h.assertEqual("custom-2", issues[2].ID, "ID")
},
name: "mixed ID assignment - explicit and auto-generated",
issues: []*types.Issue{
h.newIssue("bd-100", "Custom ID 1", types.StatusOpen, 1, types.TypeTask, nil),
h.newIssue("", "Auto ID", types.StatusOpen, 1, types.TypeTask, nil),
h.newIssue("bd-200", "Custom ID 2", types.StatusOpen, 1, types.TypeTask, nil),
},
wantErr: false,
checkFunc: func(t *testing.T, h *createIssuesTestHelper, issues []*types.Issue) {
h.assertCount(issues, 3)
h.assertEqual("bd-100", issues[0].ID, "ID")
if issues[1].ID == "" || issues[1].ID == "bd-100" || issues[1].ID == "bd-200" {
t.Errorf("expected auto-generated ID, got %s", issues[1].ID)
}
h.assertEqual("bd-200", issues[2].ID, "ID")
},
},
{
name: "validation error - missing title",
@@ -384,13 +384,13 @@ func TestCreateIssues(t *testing.T) {
checkFunc: func(t *testing.T, h *createIssuesTestHelper, issues []*types.Issue) {},
},
{
name: "duplicate ID error",
issues: []*types.Issue{
h.newIssue("duplicate-id", "First issue", types.StatusOpen, 1, types.TypeTask, nil),
h.newIssue("duplicate-id", "Second issue", types.StatusOpen, 1, types.TypeTask, nil),
},
wantErr: true,
checkFunc: func(t *testing.T, h *createIssuesTestHelper, issues []*types.Issue) {},
name: "duplicate ID error",
issues: []*types.Issue{
h.newIssue("bd-999", "First issue", types.StatusOpen, 1, types.TypeTask, nil),
h.newIssue("bd-999", "Second issue", types.StatusOpen, 1, types.TypeTask, nil),
},
wantErr: true,
checkFunc: func(t *testing.T, h *createIssuesTestHelper, issues []*types.Issue) {},
},
{
name: "closed_at invariant - open status with closed_at",
@@ -506,7 +506,7 @@ func TestCreateIssuesRollback(t *testing.T) {
t.Run("rollback on conflict with existing ID", func(t *testing.T) {
// Create an issue with explicit ID
existingIssue := &types.Issue{
ID: "existing-id",
ID: "bd-existing",
Title: "Existing issue",
Status: types.StatusOpen,
Priority: 1,
@@ -526,7 +526,7 @@ func TestCreateIssuesRollback(t *testing.T) {
IssueType: types.TypeTask,
},
{
ID: "existing-id",
ID: "bd-existing",
Title: "Conflict",
Status: types.StatusOpen,
Priority: 1,