Add unit tests to improve cmd/bd CLI coverage (bd-llfl)

Added 479 lines of new tests:

- utils_unit_test.go: Tests for utility functions (truncateString,
  pluralize, formatTimeAgo, containsLabel, extractIDSuffix, truncate,
  truncateDescription, showCleanupDeprecationHint, clearAutoFlushState)

- hooks_test.go: Tests for FormatHookWarnings, isRebaseInProgress,
  hasBeadsJSONL

- list_test.go: Tests for formatIssueLong, formatIssueCompact

- version_tracking_test.go: Fixed flaky tests by setting BEADS_DIR
  env var to prevent git worktree detection from finding the actual
  .beads directory instead of the temp directory

Coverage increased from 21.6% to 22.0%. The remaining 78% of untested
code involves daemon/RPC operations, command handlers requiring
database/daemon setup, and git operations that would require
integration tests with mocked dependencies.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-30 17:12:57 -08:00
parent def4cf4efa
commit 4ab85eeb9d
4 changed files with 479 additions and 0 deletions

View File

@@ -282,3 +282,120 @@ func TestInstallHooksShared(t *testing.T) {
}
})
}
func TestFormatHookWarnings(t *testing.T) {
tests := []struct {
name string
statuses []HookStatus
want string
}{
{
name: "no issues",
statuses: []HookStatus{{Name: "pre-commit", Installed: true}},
want: "",
},
{
name: "one missing",
statuses: []HookStatus{{Name: "pre-commit", Installed: false}},
want: "⚠️ Git hooks not installed (1 missing)",
},
{
name: "multiple missing",
statuses: []HookStatus{
{Name: "pre-commit", Installed: false},
{Name: "post-merge", Installed: false},
},
want: "⚠️ Git hooks not installed (2 missing)",
},
{
name: "one outdated",
statuses: []HookStatus{{Name: "pre-commit", Installed: true, Outdated: true}},
want: "⚠️ Git hooks are outdated (1 hooks)",
},
{
name: "mixed missing and outdated",
statuses: []HookStatus{
{Name: "pre-commit", Installed: false},
{Name: "post-merge", Installed: true, Outdated: true},
},
want: "⚠️ Git hooks not installed (1 missing)",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := FormatHookWarnings(tt.statuses)
if tt.want == "" && got != "" {
t.Errorf("FormatHookWarnings() = %q, want empty", got)
} else if tt.want != "" && !strContains(got, tt.want) {
t.Errorf("FormatHookWarnings() = %q, want to contain %q", got, tt.want)
}
})
}
}
func strContains(s, substr string) bool {
return len(s) >= len(substr) && (s == substr || len(s) > len(substr) && (s[:len(substr)] == substr || strContains(s[1:], substr)))
}
func TestIsRebaseInProgress(t *testing.T) {
tmpDir := t.TempDir()
t.Chdir(tmpDir)
// Create .git directory
if err := os.MkdirAll(".git", 0755); err != nil {
t.Fatalf("Failed to create .git: %v", err)
}
// Should be false initially
if isRebaseInProgress() {
t.Error("isRebaseInProgress() = true, want false (no rebase marker)")
}
// Create rebase-merge marker
if err := os.MkdirAll(".git/rebase-merge", 0755); err != nil {
t.Fatalf("Failed to create rebase-merge: %v", err)
}
if !isRebaseInProgress() {
t.Error("isRebaseInProgress() = false, want true (rebase-merge exists)")
}
// Remove rebase-merge
if err := os.RemoveAll(".git/rebase-merge"); err != nil {
t.Fatalf("Failed to remove rebase-merge: %v", err)
}
// Create rebase-apply marker
if err := os.MkdirAll(".git/rebase-apply", 0755); err != nil {
t.Fatalf("Failed to create rebase-apply: %v", err)
}
if !isRebaseInProgress() {
t.Error("isRebaseInProgress() = false, want true (rebase-apply exists)")
}
}
func TestHasBeadsJSONL(t *testing.T) {
tmpDir := t.TempDir()
t.Chdir(tmpDir)
// Should be false initially (no .beads directory)
if hasBeadsJSONL() {
t.Error("hasBeadsJSONL() = true, want false (no .beads)")
}
// Create .beads directory without any JSONL files
if err := os.MkdirAll(".beads", 0755); err != nil {
t.Fatalf("Failed to create .beads: %v", err)
}
if hasBeadsJSONL() {
t.Error("hasBeadsJSONL() = true, want false (no JSONL files)")
}
// Create issues.jsonl
if err := os.WriteFile(".beads/issues.jsonl", []byte("{}"), 0644); err != nil {
t.Fatalf("Failed to create issues.jsonl: %v", err)
}
if !hasBeadsJSONL() {
t.Error("hasBeadsJSONL() = false, want true (issues.jsonl exists)")
}
}