Fix all test failures from bd-166 (missing issue_prefix)

Completed bd-167: Fixed all tests that failed with 'database not initialized: issue_prefix config is missing' error.

Changes:
- Created test helper functions in 3 locations:
  * cmd/bd/test_helpers_test.go (already existed)
  * internal/rpc/test_helpers.go (new)
  * internal/storage/sqlite/test_helpers.go (new)

- Updated all affected test files to use newTestStore():
  * cmd/bd: comments, export, git_sync, label, list, reopen, direct_mode
  * internal/rpc: rpc_test, version_test
  * internal/storage/sqlite: sqlite_test, underlying_db_test

- Fixed config test: updated flush-debounce default from 5s to 30s

- Removed unused sqlite imports from test files

All tests now passing 

Also:
- Closed bd-167, bd-170 (cleanup of beads-* duplicates)
- Removed corrupt backup files

Amp-Thread-ID: https://ampcode.com/threads/T-4a8c6002-9384-45b6-81f6-2907d1e4c6c2
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
2025-10-26 22:31:24 -07:00
parent 09e881022e
commit 4ea347e08a
16 changed files with 88 additions and 92 deletions

View File

@@ -45,10 +45,7 @@ func TestGitPullSyncIntegration(t *testing.T) {
}
clone1DBPath := filepath.Join(clone1BeadsDir, "test.db")
clone1Store, err := sqlite.New(clone1DBPath)
if err != nil {
t.Fatalf("Failed to create clone1 database: %v", err)
}
clone1Store := newTestStore(t, clone1DBPath)
defer clone1Store.Close()
ctx := context.Background()
@@ -94,10 +91,7 @@ func TestGitPullSyncIntegration(t *testing.T) {
// Initialize empty database in clone2
clone2BeadsDir := filepath.Join(clone2Dir, ".beads")
clone2DBPath := filepath.Join(clone2BeadsDir, "test.db")
clone2Store, err := sqlite.New(clone2DBPath)
if err != nil {
t.Fatalf("Failed to create clone2 database: %v", err)
}
clone2Store := newTestStore(t, clone2DBPath)
defer clone2Store.Close()
if err := clone2Store.SetMetadata(ctx, "issue_prefix", "test"); err != nil {
@@ -141,10 +135,7 @@ func TestGitPullSyncIntegration(t *testing.T) {
// In real usage, auto-import would trigger on next bd command
// For this test, we'll manually import to simulate that behavior
newStore, err := sqlite.New(clone2DBPath)
if err != nil {
t.Fatalf("Failed to reopen database: %v", err)
}
newStore := newTestStore(t, clone2DBPath)
// Don't defer close - we'll reassign to clone2Store for the next test
// Manually import to simulate auto-import behavior