Context propagation with graceful cancellation (bd-rtp, bd-yb8, bd-2o2)
Complete implementation of signal-aware context propagation for graceful cancellation across all commands and storage operations. Key changes: 1. Signal-aware contexts (bd-rtp): - Added rootCtx/rootCancel in main.go using signal.NotifyContext() - Set up in PersistentPreRun, cancelled in PersistentPostRun - Daemon uses same pattern in runDaemonLoop() - Handles SIGINT/SIGTERM for graceful shutdown 2. Context propagation (bd-yb8): - All commands now use rootCtx instead of context.Background() - sqlite.New() receives context for cancellable operations - Database operations respect context cancellation - Storage layer propagates context through all queries 3. Cancellation tests (bd-2o2): - Added import_cancellation_test.go with comprehensive tests - Added export cancellation test in export_test.go - Tests verify database integrity after cancellation - All cancellation tests passing Fixes applied during review: - Fixed rootCtx lifecycle (removed premature defer from PersistentPreRun) - Fixed test context contamination (reset rootCtx in test cleanup) - Fixed export tests missing context setup Impact: - Pressing Ctrl+C during import/export now cancels gracefully - No database corruption or hanging transactions - Clean shutdown of all operations Tested: - go build ./cmd/bd ✓ - go test ./cmd/bd -run TestImportCancellation ✓ - go test ./cmd/bd -run TestExportCommand ✓ - Manual Ctrl+C testing verified 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"os"
|
||||
"sort"
|
||||
@@ -46,7 +45,7 @@ var configSetCmd = &cobra.Command{
|
||||
key := args[0]
|
||||
value := args[1]
|
||||
|
||||
ctx := context.Background()
|
||||
ctx := rootCtx
|
||||
|
||||
// Special handling for sync.branch to apply validation
|
||||
if strings.TrimSpace(key) == syncbranch.ConfigKey {
|
||||
@@ -85,7 +84,7 @@ var configGetCmd = &cobra.Command{
|
||||
|
||||
key := args[0]
|
||||
|
||||
ctx := context.Background()
|
||||
ctx := rootCtx
|
||||
var value string
|
||||
var err error
|
||||
|
||||
@@ -126,7 +125,7 @@ var configListCmd = &cobra.Command{
|
||||
os.Exit(1)
|
||||
}
|
||||
|
||||
ctx := context.Background()
|
||||
ctx := rootCtx
|
||||
config, err := store.GetAllConfig(ctx)
|
||||
if err != nil {
|
||||
fmt.Fprintf(os.Stderr, "Error listing config: %v\n", err)
|
||||
@@ -170,7 +169,7 @@ var configUnsetCmd = &cobra.Command{
|
||||
|
||||
key := args[0]
|
||||
|
||||
ctx := context.Background()
|
||||
ctx := rootCtx
|
||||
if err := store.DeleteConfig(ctx, key); err != nil {
|
||||
fmt.Fprintf(os.Stderr, "Error deleting config: %v\n", err)
|
||||
os.Exit(1)
|
||||
|
||||
Reference in New Issue
Block a user