johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Context propagation with graceful cancellation (bd-rtp, bd-yb8, bd-2o2)

Browse Source 
Complete implementation of signal-aware context propagation for graceful
cancellation across all commands and storage operations.

Key changes:

1. Signal-aware contexts (bd-rtp):
   - Added rootCtx/rootCancel in main.go using signal.NotifyContext()
   - Set up in PersistentPreRun, cancelled in PersistentPostRun
   - Daemon uses same pattern in runDaemonLoop()
   - Handles SIGINT/SIGTERM for graceful shutdown

2. Context propagation (bd-yb8):
   - All commands now use rootCtx instead of context.Background()
   - sqlite.New() receives context for cancellable operations
   - Database operations respect context cancellation
   - Storage layer propagates context through all queries

3. Cancellation tests (bd-2o2):
   - Added import_cancellation_test.go with comprehensive tests
   - Added export cancellation test in export_test.go
   - Tests verify database integrity after cancellation
   - All cancellation tests passing

Fixes applied during review:
   - Fixed rootCtx lifecycle (removed premature defer from PersistentPreRun)
   - Fixed test context contamination (reset rootCtx in test cleanup)
   - Fixed export tests missing context setup

Impact:
   - Pressing Ctrl+C during import/export now cancels gracefully
   - No database corruption or hanging transactions
   - Clean shutdown of all operations

Tested:
   - go build ./cmd/bd ✓
   - go test ./cmd/bd -run TestImportCancellation ✓
   - go test ./cmd/bd -run TestExportCommand ✓
   - Manual Ctrl+C testing verified

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-11-20 21:57:23 -05:00
parent 91c684cdbe
commit 57253f93a3
72 changed files with 387 additions and 232 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
cmd/bd/migrate.go
View File

@@ -1,7 +1,6 @@
package main
import (
"context"
"database/sql"
"fmt"
"os"
@@ -265,7 +264,7 @@ This command:
// Clean up WAL files before opening to avoid "disk I/O error"
cleanupWALFiles(currentDB.path)
store, err := sqlite.New(currentDB.path)
store, err := sqlite.New(rootCtx, currentDB.path)
if err != nil {
if jsonOutput {
outputJSON(map[string]interface{}{
@@ -278,7 +277,7 @@ This command:
os.Exit(1)
}
ctx := context.Background()
ctx := rootCtx
// Detect and set issue_prefix if missing (fixes GH #201)
prefix, err := store.GetConfig(ctx, "issue_prefix")
@@ -377,7 +376,7 @@ This command:
fmt.Println("\n→ Migrating to hash-based IDs...")
}
store, err := sqlite.New(targetPath)
store, err := sqlite.New(rootCtx, targetPath)
if err != nil {
if jsonOutput {
outputJSON(map[string]interface{}{
@@ -390,7 +389,7 @@ This command:
os.Exit(1)
}
ctx := context.Background()
ctx := rootCtx
issues, err := store.SearchIssues(ctx, "", types.IssueFilter{})
if err != nil {
_ = store.Close()
@@ -605,7 +604,7 @@ func handleUpdateRepoID(dryRun bool, autoYes bool) {
}
// Open database
store, err := sqlite.New(foundDB)
store, err := sqlite.New(rootCtx, foundDB)
if err != nil {
if jsonOutput {
outputJSON(map[string]interface{}{
@@ -620,7 +619,7 @@ func handleUpdateRepoID(dryRun bool, autoYes bool) {
defer func() { _ = store.Close() }()
// Get old repo ID
ctx := context.Background()
ctx := rootCtx
oldRepoID, err := store.GetMetadata(ctx, "repo_id")
if err != nil && err.Error() != "metadata key not found: repo_id" {
if jsonOutput {
@@ -796,7 +795,7 @@ func handleInspect() {
}
// Open database in read-only mode for inspection
store, err := sqlite.New(targetPath)
store, err := sqlite.New(rootCtx, targetPath)
if err != nil {
if jsonOutput {
outputJSON(map[string]interface{}{
@@ -810,7 +809,7 @@ func handleInspect() {
}
defer func() { _ = store.Close() }()
ctx := context.Background()
ctx := rootCtx
// Get current schema version
schemaVersion, err := store.GetMetadata(ctx, "bd_version")
@@ -965,7 +964,7 @@ func handleToSeparateBranch(branch string, dryRun bool) {
}
// Open database
store, err := sqlite.New(targetPath)
store, err := sqlite.New(rootCtx, targetPath)
if err != nil {
if jsonOutput {
outputJSON(map[string]interface{}{
@@ -980,7 +979,7 @@ func handleToSeparateBranch(branch string, dryRun bool) {
defer func() { _ = store.Close() }()
// Get current sync.branch config
ctx := context.Background()
ctx := rootCtx
current, _ := store.GetConfig(ctx, "sync.branch")
// Dry-run mode