fix: remove unused channels in timeout message helpers
The timerChan and timeoutChan variables were created but never read from, causing lint errors. Removed them since we don't need channel synchronization - we only want the timeout to trigger a message, not block anything.
This commit is contained in:
@@ -2157,12 +2157,10 @@ func checkOrphanedChildrenInJSONL(jsonlPath string) (*OrphanedChildren, error) {
|
|||||||
// This helps when git operations hang waiting for credential/browser auth.
|
// This helps when git operations hang waiting for credential/browser auth.
|
||||||
func runGitCmdWithTimeoutMsg(ctx context.Context, cmd *exec.Cmd, cmdName string, timeoutDelay time.Duration) ([]byte, error) {
|
func runGitCmdWithTimeoutMsg(ctx context.Context, cmd *exec.Cmd, cmdName string, timeoutDelay time.Duration) ([]byte, error) {
|
||||||
// Start a timer to print a message if the command takes too long
|
// Start a timer to print a message if the command takes too long
|
||||||
timeoutChan := make(chan struct{}, 1)
|
|
||||||
go func() {
|
go func() {
|
||||||
select {
|
select {
|
||||||
case <-time.After(timeoutDelay):
|
case <-time.After(timeoutDelay):
|
||||||
fmt.Fprintf(os.Stderr, "⏳ %s is taking longer than expected (possibly waiting for authentication). If this hangs, check for a browser auth prompt or run 'git status' in another terminal.\n", cmdName)
|
fmt.Fprintf(os.Stderr, "⏳ %s is taking longer than expected (possibly waiting for authentication). If this hangs, check for a browser auth prompt or run 'git status' in another terminal.\n", cmdName)
|
||||||
timeoutChan <- struct{}{}
|
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
// Context cancelled, don't print message
|
// Context cancelled, don't print message
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -786,12 +786,10 @@ func fetchAndRebaseInWorktree(ctx context.Context, worktreePath, branch, remote
|
|||||||
// Returns: combined output and error from the command
|
// Returns: combined output and error from the command
|
||||||
func runCmdWithTimeoutMessage(ctx context.Context, timeoutMsg string, timeoutDelay time.Duration, cmd *exec.Cmd) ([]byte, error) {
|
func runCmdWithTimeoutMessage(ctx context.Context, timeoutMsg string, timeoutDelay time.Duration, cmd *exec.Cmd) ([]byte, error) {
|
||||||
// Start a timer to print a message if the command takes too long
|
// Start a timer to print a message if the command takes too long
|
||||||
timerChan := make(chan struct{}, 1)
|
|
||||||
go func() {
|
go func() {
|
||||||
select {
|
select {
|
||||||
case <-time.After(timeoutDelay):
|
case <-time.After(timeoutDelay):
|
||||||
fmt.Fprintf(os.Stderr, "⏳ %s\n", timeoutMsg)
|
fmt.Fprintf(os.Stderr, "⏳ %s\n", timeoutMsg)
|
||||||
timerChan <- struct{}{}
|
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
// Context cancelled, don't print message
|
// Context cancelled, don't print message
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user