Add lifecycle management for beads-mcp processes (bd-148)

- Register atexit handler to close daemon connections
- Add signal handlers for SIGTERM/SIGINT for graceful shutdown
- Implement cleanup() to close all daemon client connections
- Track daemon clients globally for cleanup
- Add close() method to BdDaemonClient (no-op since connections are per-request)
- Register client on first use via _get_client()
- Add comprehensive lifecycle tests

This prevents MCP server processes from accumulating without cleanup.
Each tool invocation will now properly clean up on exit.

Amp-Thread-ID: https://ampcode.com/threads/T-05d76b8e-dac9-472b-bfd0-afe10e3457cd
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
2025-10-18 14:27:37 -07:00
parent 0baac7b22c
commit 5e0030d283
6 changed files with 231 additions and 4 deletions

View File

@@ -1,9 +1,12 @@
"""MCP tools for beads issue tracker."""
import os
from typing import Annotated
from typing import Annotated, TYPE_CHECKING
from .bd_client import create_bd_client, BdClientBase, BdError
if TYPE_CHECKING:
from typing import List
from .models import (
AddDependencyParams,
BlockedIssue,
@@ -25,12 +28,28 @@ from .models import (
# Global client instance - initialized on first use
_client: BdClientBase | None = None
_version_checked: bool = False
_client_registered: bool = False
# Default constants
DEFAULT_ISSUE_TYPE: IssueType = "task"
DEFAULT_DEPENDENCY_TYPE: DependencyType = "blocks"
def _register_client_for_cleanup(client: BdClientBase) -> None:
"""Register client with server cleanup system.
This ensures daemon connections are properly closed on server shutdown.
Import is deferred to avoid circular dependency.
"""
try:
from . import server
if hasattr(server, '_daemon_clients'):
server._daemon_clients.append(client)
except (ImportError, AttributeError):
# Server module not available or cleanup not initialized - that's ok
pass
async def _get_client() -> BdClientBase:
"""Get a BdClient instance, creating it on first use.
@@ -43,7 +62,7 @@ async def _get_client() -> BdClientBase:
Raises:
BdError: If bd is not installed or version is incompatible
"""
global _client, _version_checked
global _client, _version_checked, _client_registered
if _client is None:
# Check if daemon should be used (default: yes)
use_daemon = os.environ.get("BEADS_USE_DAEMON", "1") == "1"
@@ -53,6 +72,11 @@ async def _get_client() -> BdClientBase:
prefer_daemon=use_daemon,
working_dir=workspace_root
)
# Register for cleanup on first creation
if not _client_registered:
_register_client_for_cleanup(_client)
_client_registered = True
# Check version once per server lifetime (only for CLI client)
if not _version_checked: