Centralize validation patterns with composable validators (bd-jbqx)

Add composable issue validators to internal/validation package:
- IssueValidator type with Chain() composition function
- Exists(), NotTemplate(), NotPinned(), NotClosed(), NotHooked() validators
- HasStatus(), HasType() for checking allowed values
- ForUpdate(), ForClose(), ForDelete(), ForReopen() convenience chains

Update cmd/bd/show_unit_helpers.go to use centralized validators instead
of duplicated inline validation logic. This enables consistent validation
across all commands with a single source of truth.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-30 15:58:27 -08:00
parent 0f21a80fe0
commit 643a162f0e
3 changed files with 537 additions and 18 deletions

View File

@@ -2,33 +2,29 @@ package main
import (
"context"
"fmt"
"github.com/steveyegge/beads/internal/storage"
"github.com/steveyegge/beads/internal/types"
"github.com/steveyegge/beads/internal/validation"
)
// validateIssueUpdatable checks if an issue can be updated.
// Uses the centralized validation package for consistency.
func validateIssueUpdatable(id string, issue *types.Issue) error {
if issue == nil {
return nil
}
if issue.IsTemplate {
return fmt.Errorf("Error: cannot update template %s: templates are read-only; use 'bd molecule instantiate' to create a work item", id)
}
return nil
// Note: We use NotTemplate() directly instead of ForUpdate() to maintain
// backward compatibility - the original didn't check for nil issues.
return validation.NotTemplate()(id, issue)
}
// validateIssueClosable checks if an issue can be closed.
// Uses the centralized validation package for consistency.
func validateIssueClosable(id string, issue *types.Issue, force bool) error {
if issue == nil {
return nil
}
if issue.IsTemplate {
return fmt.Errorf("Error: cannot close template %s: templates are read-only", id)
}
if !force && issue.Status == types.StatusPinned {
return fmt.Errorf("Error: cannot close pinned issue %s (use --force to override)", id)
}
return nil
// Note: We use individual validators instead of ForClose() to maintain
// backward compatibility - the original didn't check for nil issues.
return validation.Chain(
validation.NotTemplate(),
validation.NotPinned(force),
)(id, issue)
}
func applyLabelUpdates(ctx context.Context, st storage.Storage, issueID, actor string, setLabels, addLabels, removeLabels []string) error {