johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: prevent daemon from exiting when launcher process exits (issue #278)

Browse Source
This commit is contained in:
Charles P. Cross
2025-11-18 18:36:33 -05:00
parent aeea3532cd
commit 68f9bef98c
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cmd/bd/daemon.go
View File

@@ -179,6 +179,19 @@ func init() {
daemonCmd.Flags().BoolVar(&jsonOutput, "json", false, "Output JSON format") daemonCmd.Flags().BoolVar(&jsonOutput, "json", false, "Output JSON format")
rootCmd.AddCommand(daemonCmd) rootCmd.AddCommand(daemonCmd)
} }
// computeDaemonParentPID determines which parent PID the daemon should track.
// When BD_DAEMON_FOREGROUND=1 (used by startDaemon for background CLI launches),
// we return 0 to disable parent tracking, since the short-lived launcher
// process is expected to exit immediately after spawning the daemon.
// In all other cases we track the current OS parent PID.
func computeDaemonParentPID() int {
if os.Getenv("BD_DAEMON_FOREGROUND") == "1" {
// 0 means "not tracked" in checkParentProcessAlive
return 0
}
return os.Getppid()
}
func runDaemonLoop(interval time.Duration, autoCommit, autoPush bool, logPath, pidFile string, global bool) { func runDaemonLoop(interval time.Duration, autoCommit, autoPush bool, logPath, pidFile string, global bool) {
logF, log := setupDaemonLogger(logPath) logF, log := setupDaemonLogger(logPath)
defer func() { _ = logF.Close() }() defer func() { _ = logF.Close() }()
@@ -422,7 +435,7 @@ func runDaemonLoop(interval time.Duration, autoCommit, autoPush bool, logPath, p
doSync() doSync()
// Get parent PID for monitoring (exit if parent dies) // Get parent PID for monitoring (exit if parent dies)
parentPID := os.Getppid() parentPID := computeDaemonParentPID()
log.log("Monitoring parent process (PID %d)", parentPID) log.log("Monitoring parent process (PID %d)", parentPID)
// Choose event loop based on BEADS_DAEMON_MODE // Choose event loop based on BEADS_DAEMON_MODE