johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: rename customID to customTitle in mol bond for consistency (bd-e7ou)

Browse Source 
The --as flag description correctly says "Custom title" but the variable
was named customID and dry-run output said "Custom ID". Fixed for consistency:

- Renamed variable customID -> customTitle
- Changed dry-run output from "Custom ID" to "Custom title"

Closes bd-e7ou
This commit is contained in:
Steve Yegge
2025-12-21 21:18:43 -08:00
parent 98d665c6fd
commit 6a949d91b8
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cmd/bd/mol_bond.go
View File

@@ -67,7 +67,7 @@ func runMolBond(cmd *cobra.Command, args []string) {
} }
bondType, _ := cmd.Flags().GetString("type") bondType, _ := cmd.Flags().GetString("type")
customID, _ := cmd.Flags().GetString("as") customTitle, _ := cmd.Flags().GetString("as")
dryRun, _ := cmd.Flags().GetBool("dry-run") dryRun, _ := cmd.Flags().GetBool("dry-run")
varFlags, _ := cmd.Flags().GetStringSlice("var") varFlags, _ := cmd.Flags().GetStringSlice("var")
@@ -123,8 +123,8 @@ func runMolBond(cmd *cobra.Command, args []string) {
fmt.Printf(" Bond type: %s\n", bondType) fmt.Printf(" Bond type: %s\n", bondType)
if aIsProto && bIsProto { if aIsProto && bIsProto {
fmt.Printf(" Result: compound proto\n") fmt.Printf(" Result: compound proto\n")
if customID != "" { if customTitle != "" {
fmt.Printf(" Custom ID: %s\n", customID) fmt.Printf(" Custom title: %s\n", customTitle)
} }
} else if aIsProto || bIsProto { } else if aIsProto || bIsProto {
fmt.Printf(" Result: spawn proto, attach to molecule\n") fmt.Printf(" Result: spawn proto, attach to molecule\n")
@@ -138,7 +138,7 @@ func runMolBond(cmd *cobra.Command, args []string) {
var result *BondResult var result *BondResult
switch { switch {
case aIsProto && bIsProto: case aIsProto && bIsProto:
result, err = bondProtoProto(ctx, store, issueA, issueB, bondType, customID, actor) result, err = bondProtoProto(ctx, store, issueA, issueB, bondType, customTitle, actor)
case aIsProto && !bIsProto: case aIsProto && !bIsProto:
result, err = bondProtoMol(ctx, store, issueA, issueB, bondType, vars, actor) result, err = bondProtoMol(ctx, store, issueA, issueB, bondType, vars, actor)
case !aIsProto && bIsProto: case !aIsProto && bIsProto:
@@ -186,12 +186,12 @@ func operandType(isProtoIssue bool) string {
} }
// bondProtoProto bonds two protos to create a compound proto // bondProtoProto bonds two protos to create a compound proto
func bondProtoProto(ctx context.Context, s storage.Storage, protoA, protoB *types.Issue, bondType, customID, actorName string) (*BondResult, error) { func bondProtoProto(ctx context.Context, s storage.Storage, protoA, protoB *types.Issue, bondType, customTitle, actorName string) (*BondResult, error) {
// Create compound proto: a new root that references both protos as children // Create compound proto: a new root that references both protos as children
// The compound root will be a new issue that ties them together // The compound root will be a new issue that ties them together
compoundTitle := fmt.Sprintf("Compound: %s + %s", protoA.Title, protoB.Title) compoundTitle := fmt.Sprintf("Compound: %s + %s", protoA.Title, protoB.Title)
if customID != "" { if customTitle != "" {
compoundTitle = customID compoundTitle = customTitle
} }
var compoundID string var compoundID string