johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(create): validate explicit IDs against allowed_prefixes using starts-with matching (#1137)

Browse Source 
When creating issues with explicit IDs like `bd create --id hq-cv-test`,
the prefix validation was failing even when `hq-cv` was in `allowed_prefixes`.

Root cause: `ExtractIssuePrefix("hq-cv-test")` returns `"hq"` (not `"hq-cv"`)
because "test" looks like an English word, causing the algorithm to fall back
to the first hyphen. The validation then checked if `"hq"` was in the allowed
list containing `"hq-cv"` - which failed.

The fix adds `ValidateIDPrefixAllowed()` which validates the full ID using
"starts with" matching (the same approach the importer uses successfully).
This correctly handles multi-hyphen prefixes like `hq-cv-` regardless of
what the suffix looks like.

Fixes #1135

Co-authored-by: Steven Syrek <steven.syrek@deepl.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steven Syrek
2026-01-19 19:08:56 +01:00
committed by GitHub
parent 8e40018701
commit 73d4d5ecb2
3 changed files with 100 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
cmd/bd/create.go
View File

@@ -400,20 +400,15 @@ var createCmd = &cobra.Command{
// Validate explicit ID format if provided
if explicitID != "" {
var requestedPrefix string
var err error
// For agent types, use agent-aware prefix extraction.
// For agent types, use agent-aware validation.
// This fixes the bug where 3-char polecat names like "nux" in
// "nx-nexus-polecat-nux" were incorrectly treated as hash suffixes,
// causing prefix to be extracted as "nx-nexus-polecat" instead of "nx".
// "nx-nexus-polecat-nux" were incorrectly treated as hash suffixes.
if issueType == "agent" {
if err := validation.ValidateAgentID(explicitID); err != nil {
FatalError("invalid agent ID: %v", err)
}
requestedPrefix = validation.ExtractAgentPrefix(explicitID)
} else {
requestedPrefix, err = validation.ValidateIDFormat(explicitID)
_, err := validation.ValidateIDFormat(explicitID)
if err != nil {
FatalError("%v", err)
}
@@ -442,7 +437,10 @@ var createCmd = &cobra.Command{
allowedPrefixes, _ = store.GetConfig(ctx, "allowed_prefixes")
}
if err := validation.ValidatePrefixWithAllowed(requestedPrefix, dbPrefix, allowedPrefixes, forceCreate); err != nil {
// Use ValidateIDPrefixAllowed which handles multi-hyphen prefixes correctly (GH#1135)
// This checks if the ID starts with an allowed prefix, rather than extracting
// the prefix first (which can fail for IDs like "hq-cv-test" where "test" looks like a word)
if err := validation.ValidateIDPrefixAllowed(explicitID, dbPrefix, allowedPrefixes, forceCreate); err != nil {
FatalError("%v", err)
}
}