johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: CI test failures and lint errors

Browse Source 
- Fixed test file naming: issues.jsonl -> beads.jsonl
  - beads_test.go: Update expected path in TestFindJSONLPath
  - internal/beads/beads_test.go: Update TestFindJSONLPathDefault
  - cmd/bd/main_test.go: Update TestAutoFlushJSONLContent

- Fixed lint errors (gosec):
  - G304: Added nosec comments for file operations with user-provided paths
  - G204: Added nosec comment for subprocess with controlled binary path

- Fixed lint errors (errcheck):
  - cmd/bd/test_wait_helper.go: Acknowledge error return values with _
  - cmd/bd/onboard.go: Handle fmt.Fprintf error return

All tests passing locally. All lint checks passing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-11-24 00:21:01 -08:00
parent ed3ddc0053
commit 76e3f27eb0
7 changed files with 28 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
cmd/bd/test_wait_helper.go
View File

@@ -39,27 +39,27 @@ func setupGitRepo(t *testing.T) (repoPath string, cleanup func()) {
// Initialize git repo
if err := exec.Command("git", "init").Run(); err != nil {
os.Chdir(originalWd)
_ = os.Chdir(originalWd)
t.Fatalf("failed to init git repo: %v", err)
}
// Configure git
exec.Command("git", "config", "user.email", "test@test.com").Run()
exec.Command("git", "config", "user.name", "Test User").Run()
_ = exec.Command("git", "config", "user.email", "test@test.com").Run()
_ = exec.Command("git", "config", "user.name", "Test User").Run()
// Create initial commit
if err := os.WriteFile("test.txt", []byte("test"), 0644); err != nil {
os.Chdir(originalWd)
if err := os.WriteFile("test.txt", []byte("test"), 0600); err != nil {
_ = os.Chdir(originalWd)
t.Fatalf("failed to write test file: %v", err)
}
exec.Command("git", "add", "test.txt").Run()
_ = exec.Command("git", "add", "test.txt").Run()
if err := exec.Command("git", "commit", "-m", "initial").Run(); err != nil {
os.Chdir(originalWd)
_ = os.Chdir(originalWd)
t.Fatalf("failed to create initial commit: %v", err)
}
cleanup = func() {
os.Chdir(originalWd)
_ = os.Chdir(originalWd)
}
return tmpDir, cleanup
@@ -82,27 +82,27 @@ func setupGitRepoWithBranch(t *testing.T, branch string) (repoPath string, clean
// Initialize git repo with specific branch
if err := exec.Command("git", "init", "-b", branch).Run(); err != nil {
os.Chdir(originalWd)
_ = os.Chdir(originalWd)
t.Fatalf("failed to init git repo: %v", err)
}
// Configure git
exec.Command("git", "config", "user.email", "test@test.com").Run()
exec.Command("git", "config", "user.name", "Test User").Run()
_ = exec.Command("git", "config", "user.email", "test@test.com").Run()
_ = exec.Command("git", "config", "user.name", "Test User").Run()
// Create initial commit
if err := os.WriteFile("test.txt", []byte("test"), 0644); err != nil {
os.Chdir(originalWd)
if err := os.WriteFile("test.txt", []byte("test"), 0600); err != nil {
_ = os.Chdir(originalWd)
t.Fatalf("failed to write test file: %v", err)
}
exec.Command("git", "add", "test.txt").Run()
_ = exec.Command("git", "add", "test.txt").Run()
if err := exec.Command("git", "commit", "-m", "initial").Run(); err != nil {
os.Chdir(originalWd)
_ = os.Chdir(originalWd)
t.Fatalf("failed to create initial commit: %v", err)
}
cleanup = func() {
os.Chdir(originalWd)
_ = os.Chdir(originalWd)
}
return tmpDir, cleanup
@@ -125,16 +125,16 @@ func setupMinimalGitRepo(t *testing.T) (repoPath string, cleanup func()) {
// Initialize git repo
if err := exec.Command("git", "init").Run(); err != nil {
os.Chdir(originalWd)
_ = os.Chdir(originalWd)
t.Fatalf("failed to init git repo: %v", err)
}
// Configure git
exec.Command("git", "config", "user.email", "test@test.com").Run()
exec.Command("git", "config", "user.name", "Test User").Run()
_ = exec.Command("git", "config", "user.email", "test@test.com").Run()
_ = exec.Command("git", "config", "user.name", "Test User").Run()
cleanup = func() {
os.Chdir(originalWd)
_ = os.Chdir(originalWd)
}
return tmpDir, cleanup