From f032eccbad593130ba8eb64800ac0980cfb2608d Mon Sep 17 00:00:00 2001 From: Steve Yegge Date: Fri, 19 Dec 2025 00:42:35 -0800 Subject: [PATCH] feat(cleanup): protect pinned issues from cleanup/compact (bd-b2k) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add Pinned field to Issue struct and database schema to protect issues from accidental deletion via cleanup or compaction. Changes: - Add Pinned bool field to types.Issue - Create migration 023_pinned_column.go for database schema - Filter out pinned issues in cleanup command before deletion - Add pinned check to GetTier1Candidates and GetTier2Candidates - Add pinned check to CheckEligibility for compaction - Update all SQL queries and scan functions to include pinned field 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- cmd/bd/cleanup.go | 16 ++++++++ internal/storage/sqlite/compact.go | 32 ++++++++++------ internal/storage/sqlite/dependencies.go | 20 ++++++++-- internal/storage/sqlite/issues.go | 22 ++++++++--- internal/storage/sqlite/labels.go | 2 +- internal/storage/sqlite/migrations.go | 2 + .../sqlite/migrations/023_pinned_column.go | 37 +++++++++++++++++++ internal/storage/sqlite/migrations_test.go | 3 +- internal/storage/sqlite/queries.go | 24 +++++++++--- internal/storage/sqlite/ready.go | 12 ++++-- internal/storage/sqlite/schema.go | 2 + internal/storage/sqlite/transaction.go | 12 ++++-- internal/types/types.go | 3 ++ 13 files changed, 152 insertions(+), 35 deletions(-) create mode 100644 internal/storage/sqlite/migrations/023_pinned_column.go diff --git a/cmd/bd/cleanup.go b/cmd/bd/cleanup.go index 5448147c..b3c4d911 100644 --- a/cmd/bd/cleanup.go +++ b/cmd/bd/cleanup.go @@ -126,6 +126,22 @@ SEE ALSO: os.Exit(1) } + // Filter out pinned issues - they are protected from cleanup (bd-b2k) + pinnedCount := 0 + filteredIssues := make([]*types.Issue, 0, len(closedIssues)) + for _, issue := range closedIssues { + if issue.Pinned { + pinnedCount++ + continue + } + filteredIssues = append(filteredIssues, issue) + } + closedIssues = filteredIssues + + if pinnedCount > 0 && !jsonOutput { + fmt.Printf("Skipping %d pinned issue(s) (protected from cleanup)\n", pinnedCount) + } + if len(closedIssues) == 0 { if jsonOutput { result := map[string]interface{}{ diff --git a/internal/storage/sqlite/compact.go b/internal/storage/sqlite/compact.go index fe460480..acac2f04 100644 --- a/internal/storage/sqlite/compact.go +++ b/internal/storage/sqlite/compact.go @@ -47,7 +47,7 @@ func (s *SQLiteStorage) GetTier1Candidates(ctx context.Context) ([]*CompactionCa -- Find all issues that depend on (are blocked by) other issues dependent_tree AS ( -- Base case: direct dependents - SELECT + SELECT d.depends_on_id as issue_id, i.id as dependent_id, i.status as dependent_status, @@ -55,11 +55,11 @@ func (s *SQLiteStorage) GetTier1Candidates(ctx context.Context) ([]*CompactionCa FROM dependencies d JOIN issues i ON d.issue_id = i.id WHERE d.type = 'blocks' - + UNION ALL - + -- Recursive case: parent-child relationships - SELECT + SELECT dt.issue_id, i.id as dependent_id, i.status as dependent_status, @@ -70,20 +70,21 @@ func (s *SQLiteStorage) GetTier1Candidates(ctx context.Context) ([]*CompactionCa WHERE d.type = 'parent-child' AND dt.depth < ? ) - SELECT + SELECT i.id, i.closed_at, COALESCE(i.original_size, LENGTH(i.description) + LENGTH(i.design) + LENGTH(i.notes) + LENGTH(i.acceptance_criteria)) as original_size, 0 as estimated_size, COUNT(DISTINCT dt.dependent_id) as dependent_count FROM issues i - LEFT JOIN dependent_tree dt ON i.id = dt.issue_id + LEFT JOIN dependent_tree dt ON i.id = dt.issue_id AND dt.dependent_status IN ('open', 'in_progress', 'blocked') AND dt.depth <= ? WHERE i.status = 'closed' AND i.closed_at IS NOT NULL AND i.closed_at <= datetime('now', '-' || CAST(? AS INTEGER) || ' days') AND COALESCE(i.compaction_level, 0) = 0 + AND COALESCE(i.pinned, 0) = 0 -- Exclude pinned issues (bd-b2k) AND dt.dependent_id IS NULL -- No open dependents GROUP BY i.id ORDER BY i.closed_at ASC @@ -142,7 +143,7 @@ func (s *SQLiteStorage) GetTier2Candidates(ctx context.Context) ([]*CompactionCa FROM events GROUP BY issue_id ) - SELECT + SELECT i.id, i.closed_at, i.original_size, @@ -154,6 +155,7 @@ func (s *SQLiteStorage) GetTier2Candidates(ctx context.Context) ([]*CompactionCa AND i.closed_at IS NOT NULL AND i.closed_at <= datetime('now', '-' || CAST(? AS INTEGER) || ' days') AND i.compaction_level = 1 + AND COALESCE(i.pinned, 0) = 0 -- Exclude pinned issues (bd-b2k) AND COALESCE(ec.event_count, 0) >= CAST(? AS INTEGER) AND NOT EXISTS ( -- Check for open dependents @@ -196,13 +198,14 @@ func (s *SQLiteStorage) CheckEligibility(ctx context.Context, issueID string, ti var status string var closedAt sql.NullTime var compactionLevel int - + var pinned int + err := s.db.QueryRowContext(ctx, ` - SELECT status, closed_at, COALESCE(compaction_level, 0) + SELECT status, closed_at, COALESCE(compaction_level, 0), COALESCE(pinned, 0) FROM issues WHERE id = ? - `, issueID).Scan(&status, &closedAt, &compactionLevel) - + `, issueID).Scan(&status, &closedAt, &compactionLevel, &pinned) + if err == sql.ErrNoRows { return false, "issue not found", nil } @@ -214,11 +217,16 @@ func (s *SQLiteStorage) CheckEligibility(ctx context.Context, issueID string, ti if status != "closed" { return false, "issue is not closed", nil } - + if !closedAt.Valid { return false, "issue has no closed_at timestamp", nil } + // Pinned issues are protected from compaction (bd-b2k) + if pinned != 0 { + return false, "issue is pinned (protected from compaction)", nil + } + switch tier { case 1: if compactionLevel != 0 { diff --git a/internal/storage/sqlite/dependencies.go b/internal/storage/sqlite/dependencies.go index d55543bf..2e53c991 100644 --- a/internal/storage/sqlite/dependencies.go +++ b/internal/storage/sqlite/dependencies.go @@ -233,7 +233,7 @@ func (s *SQLiteStorage) GetDependenciesWithMetadata(ctx context.Context, issueID i.status, i.priority, i.issue_type, i.assignee, i.estimated_minutes, i.created_at, i.updated_at, i.closed_at, i.external_ref, i.source_repo, i.deleted_at, i.deleted_by, i.delete_reason, i.original_type, - i.sender, i.ephemeral, + i.sender, i.ephemeral, i.pinned, d.type FROM issues i JOIN dependencies d ON i.id = d.depends_on_id @@ -255,7 +255,7 @@ func (s *SQLiteStorage) GetDependentsWithMetadata(ctx context.Context, issueID s i.status, i.priority, i.issue_type, i.assignee, i.estimated_minutes, i.created_at, i.updated_at, i.closed_at, i.external_ref, i.source_repo, i.deleted_at, i.deleted_by, i.delete_reason, i.original_type, - i.sender, i.ephemeral, + i.sender, i.ephemeral, i.pinned, d.type FROM issues i JOIN dependencies d ON i.id = d.issue_id @@ -714,6 +714,8 @@ func (s *SQLiteStorage) scanIssues(ctx context.Context, rows *sql.Rows) ([]*type // Messaging fields (bd-kwro) var sender sql.NullString var ephemeral sql.NullInt64 + // Protection fields (bd-b2k) + var pinned sql.NullInt64 err := rows.Scan( &issue.ID, &contentHash, &issue.Title, &issue.Description, &issue.Design, @@ -721,7 +723,7 @@ func (s *SQLiteStorage) scanIssues(ctx context.Context, rows *sql.Rows) ([]*type &issue.Priority, &issue.IssueType, &assignee, &estimatedMinutes, &issue.CreatedAt, &issue.UpdatedAt, &closedAt, &externalRef, &sourceRepo, &closeReason, &deletedAt, &deletedBy, &deleteReason, &originalType, - &sender, &ephemeral, + &sender, &ephemeral, &pinned, ) if err != nil { return nil, fmt.Errorf("failed to scan issue: %w", err) @@ -766,6 +768,10 @@ func (s *SQLiteStorage) scanIssues(ctx context.Context, rows *sql.Rows) ([]*type if ephemeral.Valid && ephemeral.Int64 != 0 { issue.Ephemeral = true } + // Protection fields (bd-b2k) + if pinned.Valid && pinned.Int64 != 0 { + issue.Pinned = true + } issues = append(issues, &issue) issueIDs = append(issueIDs, issue.ID) @@ -805,6 +811,8 @@ func (s *SQLiteStorage) scanIssuesWithDependencyType(ctx context.Context, rows * // Messaging fields (bd-kwro) var sender sql.NullString var ephemeral sql.NullInt64 + // Protection fields (bd-b2k) + var pinned sql.NullInt64 var depType types.DependencyType err := rows.Scan( @@ -813,7 +821,7 @@ func (s *SQLiteStorage) scanIssuesWithDependencyType(ctx context.Context, rows * &issue.Priority, &issue.IssueType, &assignee, &estimatedMinutes, &issue.CreatedAt, &issue.UpdatedAt, &closedAt, &externalRef, &sourceRepo, &deletedAt, &deletedBy, &deleteReason, &originalType, - &sender, &ephemeral, + &sender, &ephemeral, &pinned, &depType, ) if err != nil { @@ -856,6 +864,10 @@ func (s *SQLiteStorage) scanIssuesWithDependencyType(ctx context.Context, rows * if ephemeral.Valid && ephemeral.Int64 != 0 { issue.Ephemeral = true } + // Protection fields (bd-b2k) + if pinned.Valid && pinned.Int64 != 0 { + issue.Pinned = true + } // Fetch labels for this issue labels, err := s.GetLabels(ctx, issue.ID) diff --git a/internal/storage/sqlite/issues.go b/internal/storage/sqlite/issues.go index 23ec183a..26dce951 100644 --- a/internal/storage/sqlite/issues.go +++ b/internal/storage/sqlite/issues.go @@ -32,14 +32,19 @@ func insertIssue(ctx context.Context, conn *sql.Conn, issue *types.Issue) error ephemeral = 1 } + pinned := 0 + if issue.Pinned { + pinned = 1 + } + _, err := conn.ExecContext(ctx, ` INSERT OR IGNORE INTO issues ( id, content_hash, title, description, design, acceptance_criteria, notes, status, priority, issue_type, assignee, estimated_minutes, created_at, updated_at, closed_at, external_ref, source_repo, close_reason, deleted_at, deleted_by, delete_reason, original_type, - sender, ephemeral - ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) + sender, ephemeral, pinned + ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) `, issue.ID, issue.ContentHash, issue.Title, issue.Description, issue.Design, issue.AcceptanceCriteria, issue.Notes, issue.Status, @@ -47,7 +52,7 @@ func insertIssue(ctx context.Context, conn *sql.Conn, issue *types.Issue) error issue.EstimatedMinutes, issue.CreatedAt, issue.UpdatedAt, issue.ClosedAt, issue.ExternalRef, sourceRepo, issue.CloseReason, issue.DeletedAt, issue.DeletedBy, issue.DeleteReason, issue.OriginalType, - issue.Sender, ephemeral, + issue.Sender, ephemeral, pinned, ) if err != nil { // INSERT OR IGNORE should handle duplicates, but driver may still return error @@ -68,8 +73,8 @@ func insertIssues(ctx context.Context, conn *sql.Conn, issues []*types.Issue) er status, priority, issue_type, assignee, estimated_minutes, created_at, updated_at, closed_at, external_ref, source_repo, close_reason, deleted_at, deleted_by, delete_reason, original_type, - sender, ephemeral - ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) + sender, ephemeral, pinned + ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) `) if err != nil { return fmt.Errorf("failed to prepare statement: %w", err) @@ -87,6 +92,11 @@ func insertIssues(ctx context.Context, conn *sql.Conn, issues []*types.Issue) er ephemeral = 1 } + pinned := 0 + if issue.Pinned { + pinned = 1 + } + _, err = stmt.ExecContext(ctx, issue.ID, issue.ContentHash, issue.Title, issue.Description, issue.Design, issue.AcceptanceCriteria, issue.Notes, issue.Status, @@ -94,7 +104,7 @@ func insertIssues(ctx context.Context, conn *sql.Conn, issues []*types.Issue) er issue.EstimatedMinutes, issue.CreatedAt, issue.UpdatedAt, issue.ClosedAt, issue.ExternalRef, sourceRepo, issue.CloseReason, issue.DeletedAt, issue.DeletedBy, issue.DeleteReason, issue.OriginalType, - issue.Sender, ephemeral, + issue.Sender, ephemeral, pinned, ) if err != nil { // INSERT OR IGNORE should handle duplicates, but driver may still return error diff --git a/internal/storage/sqlite/labels.go b/internal/storage/sqlite/labels.go index cc11ed3c..c07a20b1 100644 --- a/internal/storage/sqlite/labels.go +++ b/internal/storage/sqlite/labels.go @@ -159,7 +159,7 @@ func (s *SQLiteStorage) GetIssuesByLabel(ctx context.Context, label string) ([]* i.status, i.priority, i.issue_type, i.assignee, i.estimated_minutes, i.created_at, i.updated_at, i.closed_at, i.external_ref, i.source_repo, i.close_reason, i.deleted_at, i.deleted_by, i.delete_reason, i.original_type, - i.sender, i.ephemeral + i.sender, i.ephemeral, i.pinned FROM issues i JOIN labels l ON i.id = l.issue_id WHERE l.label = ? diff --git a/internal/storage/sqlite/migrations.go b/internal/storage/sqlite/migrations.go index b84f6409..6530cf26 100644 --- a/internal/storage/sqlite/migrations.go +++ b/internal/storage/sqlite/migrations.go @@ -39,6 +39,7 @@ var migrationsList = []Migration{ {"edge_consolidation", migrations.MigrateEdgeConsolidation}, {"migrate_edge_fields", migrations.MigrateEdgeFields}, {"drop_edge_columns", migrations.MigrateDropEdgeColumns}, + {"pinned_column", migrations.MigratePinnedColumn}, } // MigrationInfo contains metadata about a migration for inspection @@ -85,6 +86,7 @@ func getMigrationDescription(name string) string { "edge_consolidation": "Adds metadata and thread_id columns to dependencies table for edge schema consolidation (Decision 004)", "migrate_edge_fields": "Migrates existing issue fields (replies_to, relates_to, duplicate_of, superseded_by) to dependency edges (Decision 004 Phase 3)", "drop_edge_columns": "Drops deprecated edge columns (replies_to, relates_to, duplicate_of, superseded_by) from issues table (Decision 004 Phase 4)", + "pinned_column": "Adds pinned column to protect issues from cleanup/compact operations (bd-b2k)", } if desc, ok := descriptions[name]; ok { diff --git a/internal/storage/sqlite/migrations/023_pinned_column.go b/internal/storage/sqlite/migrations/023_pinned_column.go new file mode 100644 index 00000000..f2008b9e --- /dev/null +++ b/internal/storage/sqlite/migrations/023_pinned_column.go @@ -0,0 +1,37 @@ +package migrations + +import ( + "database/sql" + "fmt" +) + +// MigratePinnedColumn adds the pinned column to the issues table. +// Pinned issues are protected from cleanup and compaction operations (bd-b2k). +func MigratePinnedColumn(db *sql.DB) error { + var columnExists bool + err := db.QueryRow(` + SELECT COUNT(*) > 0 + FROM pragma_table_info('issues') + WHERE name = 'pinned' + `).Scan(&columnExists) + if err != nil { + return fmt.Errorf("failed to check pinned column: %w", err) + } + + if columnExists { + return nil + } + + _, err = db.Exec(`ALTER TABLE issues ADD COLUMN pinned INTEGER DEFAULT 0`) + if err != nil { + return fmt.Errorf("failed to add pinned column: %w", err) + } + + // Add index for pinned issues (for efficient queries) + _, err = db.Exec(`CREATE INDEX IF NOT EXISTS idx_issues_pinned ON issues(pinned) WHERE pinned = 1`) + if err != nil { + return fmt.Errorf("failed to create pinned index: %w", err) + } + + return nil +} diff --git a/internal/storage/sqlite/migrations_test.go b/internal/storage/sqlite/migrations_test.go index 1e02b3db..88f6da59 100644 --- a/internal/storage/sqlite/migrations_test.go +++ b/internal/storage/sqlite/migrations_test.go @@ -485,13 +485,14 @@ func TestMigrateContentHashColumn(t *testing.T) { original_type TEXT DEFAULT '', sender TEXT DEFAULT '', ephemeral INTEGER DEFAULT 0, + pinned INTEGER DEFAULT 0, replies_to TEXT DEFAULT '', relates_to TEXT DEFAULT '', duplicate_of TEXT DEFAULT '', superseded_by TEXT DEFAULT '', CHECK ((status = 'closed') = (closed_at IS NOT NULL)) ); - INSERT INTO issues SELECT id, title, description, design, acceptance_criteria, notes, status, priority, issue_type, assignee, estimated_minutes, created_at, updated_at, closed_at, external_ref, compaction_level, compacted_at, original_size, compacted_at_commit, source_repo, '', NULL, '', '', '', '', 0, '', '', '', '' FROM issues_backup; + INSERT INTO issues SELECT id, title, description, design, acceptance_criteria, notes, status, priority, issue_type, assignee, estimated_minutes, created_at, updated_at, closed_at, external_ref, compaction_level, compacted_at, original_size, compacted_at_commit, source_repo, '', NULL, '', '', '', '', 0, 0, '', '', '', '' FROM issues_backup; DROP TABLE issues_backup; `) if err != nil { diff --git a/internal/storage/sqlite/queries.go b/internal/storage/sqlite/queries.go index 5939d379..d7b625d0 100644 --- a/internal/storage/sqlite/queries.go +++ b/internal/storage/sqlite/queries.go @@ -248,6 +248,8 @@ func (s *SQLiteStorage) GetIssue(ctx context.Context, id string) (*types.Issue, // Messaging fields (bd-kwro) var sender sql.NullString var ephemeral sql.NullInt64 + // Protection fields (bd-b2k) + var pinned sql.NullInt64 var contentHash sql.NullString var compactedAtCommit sql.NullString @@ -257,7 +259,7 @@ func (s *SQLiteStorage) GetIssue(ctx context.Context, id string) (*types.Issue, created_at, updated_at, closed_at, external_ref, compaction_level, compacted_at, compacted_at_commit, original_size, source_repo, close_reason, deleted_at, deleted_by, delete_reason, original_type, - sender, ephemeral + sender, ephemeral, pinned FROM issues WHERE id = ? `, id).Scan( @@ -267,7 +269,7 @@ func (s *SQLiteStorage) GetIssue(ctx context.Context, id string) (*types.Issue, &issue.CreatedAt, &issue.UpdatedAt, &closedAt, &externalRef, &issue.CompactionLevel, &compactedAt, &compactedAtCommit, &originalSize, &sourceRepo, &closeReason, &deletedAt, &deletedBy, &deleteReason, &originalType, - &sender, &ephemeral, + &sender, &ephemeral, &pinned, ) if err == sql.ErrNoRows { @@ -325,6 +327,10 @@ func (s *SQLiteStorage) GetIssue(ctx context.Context, id string) (*types.Issue, if ephemeral.Valid && ephemeral.Int64 != 0 { issue.Ephemeral = true } + // Protection fields (bd-b2k) + if pinned.Valid && pinned.Int64 != 0 { + issue.Pinned = true + } // Fetch labels for this issue labels, err := s.GetLabels(ctx, issue.ID) @@ -431,6 +437,8 @@ func (s *SQLiteStorage) GetIssueByExternalRef(ctx context.Context, externalRef s // Messaging fields (bd-kwro) var sender sql.NullString var ephemeral sql.NullInt64 + // Protection fields (bd-b2k) + var pinned sql.NullInt64 err := s.db.QueryRowContext(ctx, ` SELECT id, content_hash, title, description, design, acceptance_criteria, notes, @@ -438,7 +446,7 @@ func (s *SQLiteStorage) GetIssueByExternalRef(ctx context.Context, externalRef s created_at, updated_at, closed_at, external_ref, compaction_level, compacted_at, compacted_at_commit, original_size, source_repo, close_reason, deleted_at, deleted_by, delete_reason, original_type, - sender, ephemeral + sender, ephemeral, pinned FROM issues WHERE external_ref = ? `, externalRef).Scan( @@ -448,7 +456,7 @@ func (s *SQLiteStorage) GetIssueByExternalRef(ctx context.Context, externalRef s &issue.CreatedAt, &issue.UpdatedAt, &closedAt, &externalRefCol, &issue.CompactionLevel, &compactedAt, &compactedAtCommit, &originalSize, &sourceRepo, &closeReason, &deletedAt, &deletedBy, &deleteReason, &originalType, - &sender, &ephemeral, + &sender, &ephemeral, &pinned, ) if err == sql.ErrNoRows { @@ -506,6 +514,10 @@ func (s *SQLiteStorage) GetIssueByExternalRef(ctx context.Context, externalRef s if ephemeral.Valid && ephemeral.Int64 != 0 { issue.Ephemeral = true } + // Protection fields (bd-b2k) + if pinned.Valid && pinned.Int64 != 0 { + issue.Pinned = true + } // Fetch labels for this issue labels, err := s.GetLabels(ctx, issue.ID) @@ -536,6 +548,8 @@ var allowedUpdateFields = map[string]bool{ "ephemeral": true, // NOTE: replies_to, relates_to, duplicate_of, superseded_by removed per Decision 004 // Use AddDependency() to create graph edges instead + // Protection fields (bd-b2k) + "pinned": true, } // validatePriority validates a priority value @@ -1564,7 +1578,7 @@ func (s *SQLiteStorage) SearchIssues(ctx context.Context, query string, filter t status, priority, issue_type, assignee, estimated_minutes, created_at, updated_at, closed_at, external_ref, source_repo, close_reason, deleted_at, deleted_by, delete_reason, original_type, - sender, ephemeral + sender, ephemeral, pinned FROM issues %s ORDER BY priority ASC, created_at DESC diff --git a/internal/storage/sqlite/ready.go b/internal/storage/sqlite/ready.go index 17a16b64..ef270435 100644 --- a/internal/storage/sqlite/ready.go +++ b/internal/storage/sqlite/ready.go @@ -101,7 +101,7 @@ func (s *SQLiteStorage) GetReadyWork(ctx context.Context, filter types.WorkFilte i.status, i.priority, i.issue_type, i.assignee, i.estimated_minutes, i.created_at, i.updated_at, i.closed_at, i.external_ref, i.source_repo, i.close_reason, i.deleted_at, i.deleted_by, i.delete_reason, i.original_type, - i.sender, i.ephemeral + i.sender, i.ephemeral, i.pinned FROM issues i WHERE %s AND NOT EXISTS ( @@ -130,7 +130,7 @@ func (s *SQLiteStorage) GetStaleIssues(ctx context.Context, filter types.StaleFi created_at, updated_at, closed_at, external_ref, source_repo, compaction_level, compacted_at, compacted_at_commit, original_size, close_reason, deleted_at, deleted_by, delete_reason, original_type, - sender, ephemeral + sender, ephemeral, pinned FROM issues WHERE status != 'closed' AND datetime(updated_at) < datetime('now', '-' || ? || ' days') @@ -179,6 +179,8 @@ func (s *SQLiteStorage) GetStaleIssues(ctx context.Context, filter types.StaleFi // Messaging fields (bd-kwro) var sender sql.NullString var ephemeral sql.NullInt64 + // Protection fields (bd-b2k) + var pinned sql.NullInt64 err := rows.Scan( &issue.ID, &contentHash, &issue.Title, &issue.Description, &issue.Design, @@ -187,7 +189,7 @@ func (s *SQLiteStorage) GetStaleIssues(ctx context.Context, filter types.StaleFi &issue.CreatedAt, &issue.UpdatedAt, &closedAt, &externalRef, &sourceRepo, &compactionLevel, &compactedAt, &compactedAtCommit, &originalSize, &closeReason, &deletedAt, &deletedBy, &deleteReason, &originalType, - &sender, &ephemeral, + &sender, &ephemeral, &pinned, ) if err != nil { return nil, fmt.Errorf("failed to scan stale issue: %w", err) @@ -244,6 +246,10 @@ func (s *SQLiteStorage) GetStaleIssues(ctx context.Context, filter types.StaleFi if ephemeral.Valid && ephemeral.Int64 != 0 { issue.Ephemeral = true } + // Protection fields (bd-b2k) + if pinned.Valid && pinned.Int64 != 0 { + issue.Pinned = true + } issues = append(issues, &issue) } diff --git a/internal/storage/sqlite/schema.go b/internal/storage/sqlite/schema.go index 750e3c33..d879f709 100644 --- a/internal/storage/sqlite/schema.go +++ b/internal/storage/sqlite/schema.go @@ -32,6 +32,8 @@ CREATE TABLE IF NOT EXISTS issues ( ephemeral INTEGER DEFAULT 0, -- NOTE: replies_to, relates_to, duplicate_of, superseded_by removed per Decision 004 -- These relationships are now stored in the dependencies table + -- Protection fields (bd-b2k) + pinned INTEGER DEFAULT 0, CHECK ((status = 'closed') = (closed_at IS NOT NULL)) ); diff --git a/internal/storage/sqlite/transaction.go b/internal/storage/sqlite/transaction.go index abfa933d..89873011 100644 --- a/internal/storage/sqlite/transaction.go +++ b/internal/storage/sqlite/transaction.go @@ -306,7 +306,7 @@ func (t *sqliteTxStorage) GetIssue(ctx context.Context, id string) (*types.Issue created_at, updated_at, closed_at, external_ref, compaction_level, compacted_at, compacted_at_commit, original_size, source_repo, close_reason, deleted_at, deleted_by, delete_reason, original_type, - sender, ephemeral + sender, ephemeral, pinned FROM issues WHERE id = ? `, id) @@ -1098,7 +1098,7 @@ func (t *sqliteTxStorage) SearchIssues(ctx context.Context, query string, filter created_at, updated_at, closed_at, external_ref, compaction_level, compacted_at, compacted_at_commit, original_size, source_repo, close_reason, deleted_at, deleted_by, delete_reason, original_type, - sender, ephemeral + sender, ephemeral, pinned FROM issues %s ORDER BY priority ASC, created_at DESC @@ -1141,6 +1141,8 @@ func scanIssueRow(row scanner) (*types.Issue, error) { // Messaging fields (bd-kwro) var sender sql.NullString var ephemeral sql.NullInt64 + // Protection fields (bd-b2k) + var pinned sql.NullInt64 err := row.Scan( &issue.ID, &contentHash, &issue.Title, &issue.Description, &issue.Design, @@ -1149,7 +1151,7 @@ func scanIssueRow(row scanner) (*types.Issue, error) { &issue.CreatedAt, &issue.UpdatedAt, &closedAt, &externalRef, &issue.CompactionLevel, &compactedAt, &compactedAtCommit, &originalSize, &sourceRepo, &closeReason, &deletedAt, &deletedBy, &deleteReason, &originalType, - &sender, &ephemeral, + &sender, &ephemeral, &pinned, ) if err != nil { return nil, fmt.Errorf("failed to scan issue: %w", err) @@ -1203,6 +1205,10 @@ func scanIssueRow(row scanner) (*types.Issue, error) { if ephemeral.Valid && ephemeral.Int64 != 0 { issue.Ephemeral = true } + // Protection fields (bd-b2k) + if pinned.Valid && pinned.Int64 != 0 { + issue.Pinned = true + } return &issue, nil } diff --git a/internal/types/types.go b/internal/types/types.go index a87c00ea..7e14dc4d 100644 --- a/internal/types/types.go +++ b/internal/types/types.go @@ -45,6 +45,9 @@ type Issue struct { Ephemeral bool `json:"ephemeral,omitempty"` // Can be bulk-deleted when closed // NOTE: RepliesTo, RelatesTo, DuplicateOf, SupersededBy moved to dependencies table // per Decision 004 (Edge Schema Consolidation). Use dependency API instead. + + // Protection fields (bd-b2k): prevent accidental deletion + Pinned bool `json:"pinned,omitempty"` // If true, protected from cleanup/compact } // ComputeContentHash creates a deterministic hash of the issue's content.