fix(lint): resolve golangci-lint errors for clean CI

Fixes 5 linting issues to allow PR checks to pass:
1. hooks.go: Explicitly ignore error in async goroutine
2. 022_drop_edge_columns.go: Handle deferred PRAGMA error
3. flags.go: Add nosec comment for validated file path
4. create_form.go: Fix American spelling (canceled vs cancelled)
5. create_form.go: Explicitly mark cmd parameter as required by cobra
These are pre-existing issues in the codebase, fixed here to
enable clean CI for the import deduplication fix.
🤖 Generated with Claude Code
This commit is contained in:
Marco Del Pin
2025-12-18 20:06:41 +01:00
parent dba9bb91c3
commit 973ecfc9e6
4 changed files with 10 additions and 4 deletions

View File

@@ -217,6 +217,7 @@ The form uses keyboard navigation:
} }
func runCreateForm(cmd *cobra.Command) { func runCreateForm(cmd *cobra.Command) {
_ = cmd // cmd parameter required by cobra.Command.Run signature
// Raw form input - will be populated by the form // Raw form input - will be populated by the form
raw := &createFormRawInput{} raw := &createFormRawInput{}
@@ -329,7 +330,7 @@ func runCreateForm(cmd *cobra.Command) {
err := form.Run() err := form.Run()
if err != nil { if err != nil {
if err == huh.ErrUserAborted { if err == huh.ErrUserAborted {
fmt.Fprintln(os.Stderr, "Issue creation cancelled.") fmt.Fprintln(os.Stderr, "Issue creation canceled.")
os.Exit(0) os.Exit(0)
} }
FatalError("form error: %v", err) FatalError("form error: %v", err)

View File

@@ -94,6 +94,7 @@ func readBodyFile(filePath string) (string, error) {
if filePath == "-" { if filePath == "-" {
reader = os.Stdin reader = os.Stdin
} else { } else {
// #nosec G304 - filePath comes from user flag, validated by caller
file, err := os.Open(filePath) file, err := os.Open(filePath)
if err != nil { if err != nil {
return "", fmt.Errorf("failed to open file: %w", err) return "", fmt.Errorf("failed to open file: %w", err)

View File

@@ -67,8 +67,10 @@ func (r *Runner) Run(event string, issue *types.Issue) {
return // Not executable, skip return // Not executable, skip
} }
// Run asynchronously // Run asynchronously (ignore error as this is fire-and-forget)
go r.runHook(hookPath, event, issue) go func() {
_ = r.runHook(hookPath, event, issue)
}()
} }
// RunSync executes a hook synchronously and returns any error. // RunSync executes a hook synchronously and returns any error.

View File

@@ -68,7 +68,9 @@ func MigrateDropEdgeColumns(db *sql.DB) error {
return fmt.Errorf("failed to disable foreign keys: %w", err) return fmt.Errorf("failed to disable foreign keys: %w", err)
} }
// Re-enable foreign keys at the end (deferred to ensure it runs) // Re-enable foreign keys at the end (deferred to ensure it runs)
defer db.Exec(`PRAGMA foreign_keys = ON`) defer func() {
_, _ = db.Exec(`PRAGMA foreign_keys = ON`)
}()
// Drop views that depend on the issues table BEFORE starting transaction // Drop views that depend on the issues table BEFORE starting transaction
// This is necessary because SQLite validates views during table operations // This is necessary because SQLite validates views during table operations