johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(gate): Use correct gh pr field name (mergedAt, not merged)

Browse Source 
The merged field does not exist in gh pr view output. The actual
fields are:
- state: OPEN, CLOSED, or MERGED
- mergedAt: timestamp string (empty if not merged)

Also simplified the switch statement since state already distinguishes
merged vs closed-without-merge PRs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-25 23:10:00 -08:00
parent 1c95ac9ae2
commit 9a508240d9
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
cmd/bd/gate.go
View File

@@ -762,12 +762,12 @@ func evalGHRunGate(gate *types.Issue) (bool, string) {
// ghPRStatus represents the JSON output of `gh pr view --json`
type ghPRStatus struct {
State string `json:"state"` // OPEN, CLOSED, MERGED
Merged bool `json:"merged"` // true if merged
State string `json:"state"` // OPEN, CLOSED, MERGED
MergedAt string `json:"mergedAt"` // non-empty if merged
}
// evalGHPRGate checks if a GitHub PR has been merged or closed.
// Uses `gh pr view <pr_number> --json state,merged` to check status.
// Uses `gh pr view <pr_number> --json state,mergedAt` to check status.
func evalGHPRGate(gate *types.Issue) (bool, string) {
prNumber := gate.AwaitID
if prNumber == "" {
@@ -775,7 +775,7 @@ func evalGHPRGate(gate *types.Issue) (bool, string) {
}
// Run gh CLI to get PR status
cmd := exec.Command("gh", "pr", "view", prNumber, "--json", "state,merged")
cmd := exec.Command("gh", "pr", "view", prNumber, "--json", "state,mergedAt")
output, err := cmd.Output()
if err != nil {
// gh CLI failed - could be network issue, invalid PR, or gh not installed
@@ -789,13 +789,11 @@ func evalGHPRGate(gate *types.Issue) (bool, string) {
}
// Close gate if PR is no longer OPEN
// State is "MERGED" for merged PRs, "CLOSED" for closed-without-merge
switch status.State {
case "MERGED":
return true, fmt.Sprintf("PR #%s merged", prNumber)
case "CLOSED":
if status.Merged {
return true, fmt.Sprintf("PR #%s merged", prNumber)
}
return true, fmt.Sprintf("PR #%s closed without merge", prNumber)
default:
// Still OPEN