refactor: remove all deletions.jsonl code (bd-fom)

Complete removal of the legacy deletions.jsonl manifest system.
Tombstones are now the sole deletion mechanism.

Removed:
- internal/deletions/ - entire package
- cmd/bd/deleted.go - deleted command
- cmd/bd/doctor/fix/deletions.go - HydrateDeletionsManifest
- Tests for all removed functionality

Cleaned:
- cmd/bd/sync.go - removed sanitize, auto-compact
- cmd/bd/delete.go - removed dual-writes
- cmd/bd/doctor.go - removed checkDeletionsManifest
- internal/importer/importer.go - removed deletions checks
- internal/syncbranch/worktree.go - removed deletions merge
- cmd/bd/integrity.go - updated validation (warn-only on decrease)

Files removed: 12
Lines removed: ~7500

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-16 14:20:32 -08:00
parent e0528de590
commit 9f76cfda01
32 changed files with 298 additions and 7534 deletions

View File

@@ -8,10 +8,59 @@ import (
"path/filepath"
"time"
"github.com/steveyegge/beads/internal/deletions"
"github.com/steveyegge/beads/internal/types"
)
// legacyDeletionRecord represents a single deletion entry from the legacy deletions.jsonl manifest.
// This is inlined here for migration purposes only - new code uses inline tombstones.
type legacyDeletionRecord struct {
ID string `json:"id"` // Issue ID that was deleted
Timestamp time.Time `json:"ts"` // When the deletion occurred
Actor string `json:"by"` // Who performed the deletion
Reason string `json:"reason,omitempty"` // Optional reason for deletion
}
// loadLegacyDeletions reads the legacy deletions.jsonl manifest.
// Returns a map of deletion records keyed by issue ID.
// This is inlined here for migration purposes only.
func loadLegacyDeletions(path string) (map[string]legacyDeletionRecord, error) {
records := make(map[string]legacyDeletionRecord)
f, err := os.Open(path) // #nosec G304 - controlled path from caller
if err != nil {
if os.IsNotExist(err) {
return records, nil
}
return nil, fmt.Errorf("failed to open deletions file: %w", err)
}
defer f.Close()
scanner := bufio.NewScanner(f)
scanner.Buffer(make([]byte, 0, 1024), 1024*1024)
for scanner.Scan() {
line := scanner.Text()
if line == "" {
continue
}
var record legacyDeletionRecord
if err := json.Unmarshal([]byte(line), &record); err != nil {
continue // Skip corrupt lines
}
if record.ID == "" {
continue // Skip records without ID
}
records[record.ID] = record
}
if err := scanner.Err(); err != nil {
return nil, fmt.Errorf("error reading deletions file: %w", err)
}
return records, nil
}
// MigrateTombstones converts legacy deletions.jsonl entries to inline tombstones.
// This is called by bd doctor --fix when legacy deletions are detected.
func MigrateTombstones(path string) error {
@@ -30,12 +79,12 @@ func MigrateTombstones(path string) error {
}
// Load deletions
loadResult, err := deletions.LoadDeletions(deletionsPath)
records, err := loadLegacyDeletions(deletionsPath)
if err != nil {
return fmt.Errorf("failed to load deletions: %w", err)
}
if len(loadResult.Records) == 0 {
if len(records) == 0 {
fmt.Println(" deletions.jsonl is empty - nothing to migrate")
return nil
}
@@ -60,9 +109,9 @@ func MigrateTombstones(path string) error {
}
// Convert deletions to tombstones
var toMigrate []deletions.DeletionRecord
var toMigrate []legacyDeletionRecord
var skipped int
for _, record := range loadResult.Records {
for _, record := range records {
if existingTombstones[record.ID] {
skipped++
continue
@@ -81,7 +130,7 @@ func MigrateTombstones(path string) error {
defer file.Close()
for _, record := range toMigrate {
tombstone := convertDeletionToTombstone(record)
tombstone := convertLegacyDeletionToTombstone(record)
data, err := json.Marshal(tombstone)
if err != nil {
return fmt.Errorf("failed to marshal tombstone for %s: %w", record.ID, err)
@@ -106,8 +155,8 @@ func MigrateTombstones(path string) error {
return nil
}
// convertDeletionToTombstone converts a DeletionRecord to a tombstone Issue.
func convertDeletionToTombstone(record deletions.DeletionRecord) *types.Issue {
// convertLegacyDeletionToTombstone converts a legacy DeletionRecord to a tombstone Issue.
func convertLegacyDeletionToTombstone(record legacyDeletionRecord) *types.Issue {
now := time.Now()
deletedAt := record.Timestamp
if deletedAt.IsZero() {