Implement daemon auto-start with comprehensive improvements (bd-124)
- Auto-starts daemon on first bd command (unless --no-daemon or BEADS_AUTO_START_DAEMON=false) - Exponential backoff on failures: 5s, 10s, 20s, 40s, 80s, 120s (max) - Lockfile prevents race conditions when multiple commands start daemon simultaneously - Stdio redirected to /dev/null to prevent daemon output in foreground - Uses os.Executable() for security (prevents PATH hijacking) - Socket readiness verified with actual connection test - Accepts multiple falsy values: false, 0, no, off (case-insensitive) - Working directory set to database directory for local daemon context - Comprehensive test coverage including backoff math and concurrent starts Fixes: - Closes bd-1 (won't fix - compaction keeps DBs small) - Closes bd-124 (daemon auto-start implemented) Documentation updated in README.md and AGENTS.md Amp-Thread-ID: https://ampcode.com/threads/T-b10fe866-ab85-417f-9c4c-5d1f044c5796 Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
234
cmd/bd/autostart_test.go
Normal file
234
cmd/bd/autostart_test.go
Normal file
@@ -0,0 +1,234 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
func TestDaemonAutoStart(t *testing.T) {
|
||||
// Save original env
|
||||
origAutoStart := os.Getenv("BEADS_AUTO_START_DAEMON")
|
||||
defer func() {
|
||||
if origAutoStart != "" {
|
||||
os.Setenv("BEADS_AUTO_START_DAEMON", origAutoStart)
|
||||
} else {
|
||||
os.Unsetenv("BEADS_AUTO_START_DAEMON")
|
||||
}
|
||||
}()
|
||||
|
||||
t.Run("shouldAutoStartDaemon defaults to true", func(t *testing.T) {
|
||||
os.Unsetenv("BEADS_AUTO_START_DAEMON")
|
||||
if !shouldAutoStartDaemon() {
|
||||
t.Error("Expected auto-start to be enabled by default")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("shouldAutoStartDaemon respects false", func(t *testing.T) {
|
||||
os.Setenv("BEADS_AUTO_START_DAEMON", "false")
|
||||
if shouldAutoStartDaemon() {
|
||||
t.Error("Expected auto-start to be disabled when set to 'false'")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("shouldAutoStartDaemon respects 0", func(t *testing.T) {
|
||||
os.Setenv("BEADS_AUTO_START_DAEMON", "0")
|
||||
if shouldAutoStartDaemon() {
|
||||
t.Error("Expected auto-start to be disabled when set to '0'")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("shouldAutoStartDaemon respects no", func(t *testing.T) {
|
||||
os.Setenv("BEADS_AUTO_START_DAEMON", "no")
|
||||
if shouldAutoStartDaemon() {
|
||||
t.Error("Expected auto-start to be disabled when set to 'no'")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("shouldAutoStartDaemon respects off", func(t *testing.T) {
|
||||
os.Setenv("BEADS_AUTO_START_DAEMON", "off")
|
||||
if shouldAutoStartDaemon() {
|
||||
t.Error("Expected auto-start to be disabled when set to 'off'")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("shouldAutoStartDaemon handles case and whitespace", func(t *testing.T) {
|
||||
os.Setenv("BEADS_AUTO_START_DAEMON", " FALSE ")
|
||||
if shouldAutoStartDaemon() {
|
||||
t.Error("Expected auto-start to be disabled when set to ' FALSE '")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("shouldAutoStartDaemon respects true", func(t *testing.T) {
|
||||
os.Setenv("BEADS_AUTO_START_DAEMON", "true")
|
||||
if !shouldAutoStartDaemon() {
|
||||
t.Error("Expected auto-start to be enabled when set to 'true'")
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func TestDaemonStartFailureTracking(t *testing.T) {
|
||||
// Reset failure state
|
||||
daemonStartFailures = 0
|
||||
lastDaemonStartAttempt = time.Time{}
|
||||
|
||||
t.Run("canRetryDaemonStart allows first attempt", func(t *testing.T) {
|
||||
if !canRetryDaemonStart() {
|
||||
t.Error("Expected first attempt to be allowed")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("exponential backoff after failures", func(t *testing.T) {
|
||||
// Simulate first failure
|
||||
recordDaemonStartFailure()
|
||||
if daemonStartFailures != 1 {
|
||||
t.Errorf("Expected failure count 1, got %d", daemonStartFailures)
|
||||
}
|
||||
|
||||
// Should not allow immediate retry
|
||||
if canRetryDaemonStart() {
|
||||
t.Error("Expected retry to be blocked immediately after failure")
|
||||
}
|
||||
|
||||
// Wait for backoff period (5 seconds for first failure)
|
||||
lastDaemonStartAttempt = time.Now().Add(-6 * time.Second)
|
||||
if !canRetryDaemonStart() {
|
||||
t.Error("Expected retry to be allowed after backoff period")
|
||||
}
|
||||
|
||||
// Simulate second failure
|
||||
recordDaemonStartFailure()
|
||||
if daemonStartFailures != 2 {
|
||||
t.Errorf("Expected failure count 2, got %d", daemonStartFailures)
|
||||
}
|
||||
|
||||
// Should not allow immediate retry (10 second backoff)
|
||||
if canRetryDaemonStart() {
|
||||
t.Error("Expected retry to be blocked immediately after second failure")
|
||||
}
|
||||
|
||||
// Wait for longer backoff
|
||||
lastDaemonStartAttempt = time.Now().Add(-11 * time.Second)
|
||||
if !canRetryDaemonStart() {
|
||||
t.Error("Expected retry to be allowed after longer backoff period")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("exponential backoff durations are correct", func(t *testing.T) {
|
||||
testCases := []struct {
|
||||
failures int
|
||||
expected time.Duration
|
||||
}{
|
||||
{1, 5 * time.Second},
|
||||
{2, 10 * time.Second},
|
||||
{3, 20 * time.Second},
|
||||
{4, 40 * time.Second},
|
||||
{5, 80 * time.Second},
|
||||
{6, 120 * time.Second}, // Capped
|
||||
{10, 120 * time.Second}, // Still capped
|
||||
}
|
||||
|
||||
for _, tc := range testCases {
|
||||
daemonStartFailures = tc.failures
|
||||
lastDaemonStartAttempt = time.Now()
|
||||
|
||||
// Should not allow retry immediately
|
||||
if canRetryDaemonStart() {
|
||||
t.Errorf("Failures=%d: Expected immediate retry to be blocked", tc.failures)
|
||||
}
|
||||
|
||||
// Should allow retry after expected duration
|
||||
lastDaemonStartAttempt = time.Now().Add(-(tc.expected + time.Second))
|
||||
if !canRetryDaemonStart() {
|
||||
t.Errorf("Failures=%d: Expected retry after %v", tc.failures, tc.expected)
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("recordDaemonStartSuccess resets failures", func(t *testing.T) {
|
||||
daemonStartFailures = 10
|
||||
recordDaemonStartSuccess()
|
||||
if daemonStartFailures != 0 {
|
||||
t.Errorf("Expected failure count to reset to 0, got %d", daemonStartFailures)
|
||||
}
|
||||
})
|
||||
|
||||
// Reset state
|
||||
daemonStartFailures = 0
|
||||
lastDaemonStartAttempt = time.Time{}
|
||||
}
|
||||
|
||||
func TestGetSocketPath(t *testing.T) {
|
||||
// Create temp directory structure
|
||||
tmpDir := t.TempDir()
|
||||
beadsDir := filepath.Join(tmpDir, ".beads")
|
||||
if err := os.MkdirAll(beadsDir, 0755); err != nil {
|
||||
t.Fatalf("Failed to create temp directory: %v", err)
|
||||
}
|
||||
|
||||
// Set dbPath to temp location
|
||||
originalDbPath := dbPath
|
||||
dbPath = filepath.Join(beadsDir, "test.db")
|
||||
defer func() { dbPath = originalDbPath }()
|
||||
|
||||
t.Run("prefers local socket when it exists", func(t *testing.T) {
|
||||
localSocket := filepath.Join(beadsDir, "bd.sock")
|
||||
|
||||
// Create local socket file
|
||||
if err := os.WriteFile(localSocket, []byte{}, 0644); err != nil {
|
||||
t.Fatalf("Failed to create socket file: %v", err)
|
||||
}
|
||||
defer os.Remove(localSocket)
|
||||
|
||||
socketPath := getSocketPath()
|
||||
if socketPath != localSocket {
|
||||
t.Errorf("Expected local socket %s, got %s", localSocket, socketPath)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("falls back to global socket", func(t *testing.T) {
|
||||
// Ensure no local socket exists
|
||||
localSocket := filepath.Join(beadsDir, "bd.sock")
|
||||
os.Remove(localSocket)
|
||||
|
||||
// Create global socket
|
||||
home, err := os.UserHomeDir()
|
||||
if err != nil {
|
||||
t.Skip("Cannot get home directory")
|
||||
}
|
||||
globalBeadsDir := filepath.Join(home, ".beads")
|
||||
if err := os.MkdirAll(globalBeadsDir, 0755); err != nil {
|
||||
t.Fatalf("Failed to create global beads directory: %v", err)
|
||||
}
|
||||
globalSocket := filepath.Join(globalBeadsDir, "bd.sock")
|
||||
|
||||
if err := os.WriteFile(globalSocket, []byte{}, 0644); err != nil {
|
||||
t.Fatalf("Failed to create global socket file: %v", err)
|
||||
}
|
||||
defer os.Remove(globalSocket)
|
||||
|
||||
socketPath := getSocketPath()
|
||||
if socketPath != globalSocket {
|
||||
t.Errorf("Expected global socket %s, got %s", globalSocket, socketPath)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("defaults to local socket when none exist", func(t *testing.T) {
|
||||
// Ensure no sockets exist
|
||||
localSocket := filepath.Join(beadsDir, "bd.sock")
|
||||
os.Remove(localSocket)
|
||||
|
||||
home, err := os.UserHomeDir()
|
||||
if err != nil {
|
||||
t.Skip("Cannot get home directory")
|
||||
}
|
||||
globalSocket := filepath.Join(home, ".beads", "bd.sock")
|
||||
os.Remove(globalSocket)
|
||||
|
||||
socketPath := getSocketPath()
|
||||
if socketPath != localSocket {
|
||||
t.Errorf("Expected default to local socket %s, got %s", localSocket, socketPath)
|
||||
}
|
||||
})
|
||||
}
|
||||
Reference in New Issue
Block a user