test: fix config test environment pollution
Tests were failing when BD_ACTOR or other BD_/BEADS_ environment variables were set. Added envSnapshot helper to save, clear, and restore environment variables for proper test isolation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -3,10 +3,39 @@ package config
|
|||||||
import (
|
import (
|
||||||
"os"
|
"os"
|
||||||
"path/filepath"
|
"path/filepath"
|
||||||
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// envSnapshot saves and clears BD_/BEADS_ environment variables.
|
||||||
|
// Returns a restore function that should be deferred.
|
||||||
|
func envSnapshot(t *testing.T) func() {
|
||||||
|
t.Helper()
|
||||||
|
saved := make(map[string]string)
|
||||||
|
for _, env := range os.Environ() {
|
||||||
|
if strings.HasPrefix(env, "BD_") || strings.HasPrefix(env, "BEADS_") {
|
||||||
|
parts := strings.SplitN(env, "=", 2)
|
||||||
|
key := parts[0]
|
||||||
|
saved[key] = os.Getenv(key)
|
||||||
|
os.Unsetenv(key)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return func() {
|
||||||
|
// Clear any test-set variables first
|
||||||
|
for _, env := range os.Environ() {
|
||||||
|
if strings.HasPrefix(env, "BD_") || strings.HasPrefix(env, "BEADS_") {
|
||||||
|
parts := strings.SplitN(env, "=", 2)
|
||||||
|
os.Unsetenv(parts[0])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// Restore original values
|
||||||
|
for key, val := range saved {
|
||||||
|
os.Setenv(key, val)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestInitialize(t *testing.T) {
|
func TestInitialize(t *testing.T) {
|
||||||
// Test that initialization doesn't error
|
// Test that initialization doesn't error
|
||||||
err := Initialize()
|
err := Initialize()
|
||||||
@@ -20,6 +49,10 @@ func TestInitialize(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func TestDefaults(t *testing.T) {
|
func TestDefaults(t *testing.T) {
|
||||||
|
// Isolate from environment variables
|
||||||
|
restore := envSnapshot(t)
|
||||||
|
defer restore()
|
||||||
|
|
||||||
// Reset viper for test isolation
|
// Reset viper for test isolation
|
||||||
err := Initialize()
|
err := Initialize()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -90,6 +123,10 @@ func TestEnvironmentBinding(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func TestConfigFile(t *testing.T) {
|
func TestConfigFile(t *testing.T) {
|
||||||
|
// Isolate from environment variables
|
||||||
|
restore := envSnapshot(t)
|
||||||
|
defer restore()
|
||||||
|
|
||||||
// Create a temporary directory for config file
|
// Create a temporary directory for config file
|
||||||
tmpDir := t.TempDir()
|
tmpDir := t.TempDir()
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user