johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bd-b245: Add migration registry and simplify New()

Browse Source
This commit is contained in:
Steve Yegge
2025-11-02 12:40:55 -08:00
parent 2ab65d2c79
commit a126debb99
2 changed files with 35 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
internal/storage/sqlite/migrations.go
View File

@@ -8,6 +8,37 @@ import (
"github.com/steveyegge/beads/internal/types"
)
// Migration represents a single database migration
type Migration struct {
Name string
Func func(*sql.DB) error
}
// migrations is the ordered list of all migrations to run
// Migrations are run in order during database initialization
var migrations = []Migration{
{"dirty_issues_table", migrateDirtyIssuesTable},
{"external_ref_column", migrateExternalRefColumn},
{"composite_indexes", migrateCompositeIndexes},
{"closed_at_constraint", migrateClosedAtConstraint},
{"compaction_columns", migrateCompactionColumns},
{"snapshots_table", migrateSnapshotsTable},
{"compaction_config", migrateCompactionConfig},
{"compacted_at_commit_column", migrateCompactedAtCommitColumn},
{"export_hashes_table", migrateExportHashesTable},
{"content_hash_column", migrateContentHashColumn},
}
// RunMigrations executes all registered migrations in order
func RunMigrations(db *sql.DB) error {
for _, migration := range migrations {
if err := migration.Func(db); err != nil {
return fmt.Errorf("migration %s failed: %w", migration.Name, err)
}
}
return nil
}
func migrateDirtyIssuesTable(db *sql.DB) error {
// Check if dirty_issues table exists
var tableName string

55
internal/storage/sqlite/sqlite.go
View File

@@ -71,54 +71,9 @@ func New(path string) (*SQLiteStorage, error) {
return nil, fmt.Errorf("failed to initialize schema: %w", err)
}
// Migrate existing databases to add dirty_issues table if missing
if err := migrateDirtyIssuesTable(db); err != nil {
return nil, fmt.Errorf("failed to migrate dirty_issues table: %w", err)
}
// Migrate existing databases to add external_ref column if missing
if err := migrateExternalRefColumn(db); err != nil {
return nil, fmt.Errorf("failed to migrate external_ref column: %w", err)
}
// Migrate existing databases to add composite index on dependencies
if err := migrateCompositeIndexes(db); err != nil {
return nil, fmt.Errorf("failed to migrate composite indexes: %w", err)
}
// Migrate existing databases to add status/closed_at CHECK constraint
if err := migrateClosedAtConstraint(db); err != nil {
return nil, fmt.Errorf("failed to migrate closed_at constraint: %w", err)
}
// Migrate existing databases to add compaction columns
if err := migrateCompactionColumns(db); err != nil {
return nil, fmt.Errorf("failed to migrate compaction columns: %w", err)
}
// Migrate existing databases to add issue_snapshots table
if err := migrateSnapshotsTable(db); err != nil {
return nil, fmt.Errorf("failed to migrate snapshots table: %w", err)
}
// Migrate existing databases to add compaction config defaults
if err := migrateCompactionConfig(db); err != nil {
return nil, fmt.Errorf("failed to migrate compaction config: %w", err)
}
// Migrate existing databases to add compacted_at_commit column
if err := migrateCompactedAtCommitColumn(db); err != nil {
return nil, fmt.Errorf("failed to migrate compacted_at_commit column: %w", err)
}
// Migrate existing databases to add export_hashes table (bd-164)
if err := migrateExportHashesTable(db); err != nil {
return nil, fmt.Errorf("failed to migrate export_hashes table: %w", err)
}
// Migrate existing databases to add content_hash column (bd-95)
if err := migrateContentHashColumn(db); err != nil {
return nil, fmt.Errorf("failed to migrate content_hash column: %w", err)
// Run all migrations
if err := RunMigrations(db); err != nil {
return nil, err
}
// Convert to absolute path for consistency
@@ -133,11 +88,9 @@ func New(path string) (*SQLiteStorage, error) {
}, nil
}
// migrateDirtyIssuesTable checks if the dirty_issues table exists and creates it if missing.
// This ensures existing databases created before the incremental export feature get migrated automatically.
// REMOVED (bd-8e05): getNextIDForPrefix and AllocateNextID - sequential ID generation
// no longer needed with hash-based IDs
// Migration functions moved to migrations.go (bd-fc2d)
// Migration functions moved to migrations.go (bd-fc2d, bd-b245)
// getNextChildNumber atomically generates the next child number for a parent ID
// Uses the child_counters table for atomic, cross-process child ID generation