test: improve internal/daemon test coverage to 60%

Adds fast unit tests for previously uncovered functions in the daemon package:

- checkDaemonErrorFile: tests reading daemon error files
- StopDaemon: tests error handling for non-running daemons
- KillAllDaemons: tests empty lists and non-alive daemons
- FindDaemonByWorkspace: tests not found case
- discoverDaemon: tests missing socket scenario
- CleanupStaleSockets: tests edge cases (already removed, alive daemon)
- Registry: tests corrupted file handling and unregistering non-existent entries

Coverage improved from 22.5% to 60.0% with only fast tests (<1s runtime).
All new tests work in -short mode and don't start actual daemons.

Fixes bd-3f80d9e0

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-11-08 01:16:53 -08:00
parent e95885f453
commit a140436db8
2 changed files with 191 additions and 1 deletions

View File

@@ -187,7 +187,7 @@ func TestRegistryStaleCleanup(t *testing.T) {
func TestRegistryEmptyArrayNotNull(t *testing.T) {
tmpDir := t.TempDir()
registryPath := filepath.Join(tmpDir, ".beads", "registry.json")
// Override the registry path for testing (platform-specific)
homeEnv := "HOME"
if runtime.GOOS == "windows" {
@@ -218,3 +218,61 @@ func TestRegistryEmptyArrayNotNull(t *testing.T) {
t.Errorf("Expected empty array [], got: %s", content)
}
}
func TestRegistryCorruptedFile(t *testing.T) {
tmpDir := t.TempDir()
registryPath := filepath.Join(tmpDir, ".beads", "registry.json")
homeEnv := "HOME"
if runtime.GOOS == "windows" {
homeEnv = "USERPROFILE"
}
oldHome := os.Getenv(homeEnv)
os.Setenv(homeEnv, tmpDir)
defer os.Setenv(homeEnv, oldHome)
registry, err := NewRegistry()
if err != nil {
t.Fatalf("Failed to create registry: %v", err)
}
// Create a corrupted registry file
os.MkdirAll(filepath.Dir(registryPath), 0755)
os.WriteFile(registryPath, []byte("invalid json{{{"), 0644)
// Reading should return an error
entries, err := registry.readEntries()
if err == nil {
t.Error("Expected error when reading corrupted registry")
}
if entries != nil {
t.Errorf("Expected nil entries on error, got %v", entries)
}
}
func TestRegistryUnregisterNonExistent(t *testing.T) {
tmpDir := t.TempDir()
oldHome := os.Getenv("HOME")
os.Setenv("HOME", tmpDir)
defer os.Setenv("HOME", oldHome)
registry, err := NewRegistry()
if err != nil {
t.Fatalf("Failed to create registry: %v", err)
}
// Unregister from empty registry should succeed
err = registry.Unregister("/nonexistent/workspace", 99999)
if err != nil {
t.Errorf("Unregister should succeed even if entry doesn't exist: %v", err)
}
// Verify registry is still empty
rawEntries, err := registry.readEntries()
if err != nil {
t.Fatalf("Failed to read entries: %v", err)
}
if len(rawEntries) != 0 {
t.Errorf("Expected empty registry, got %d entries", len(rawEntries))
}
}