johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add CLI output tests, remove obsolete design docs (bd-37)

Browse Source 
- Added cmd/bd/output_test.go with 7 new tests for CLI output functions
- Improved coverage: outputJSON (0→60%), printCollisionReport (0→100%), printRemappingReport (0→100%)
- Removed obsolete design documents that were implemented or superseded:
  - DAEMON_DESIGN.md (daemon implemented)
  - DAEMON_STRESS_TEST.md (stress testing complete)
  - DESIGN.md (general design, superseded by other docs)
  - DUPLICATES_REPORT.md (old analysis)
  - REVIEW_BD379.md (completed review)
- Closed bd-37: All critical features now have test coverage

Amp-Thread-ID: https://ampcode.com/threads/T-9ee0fcdd-3675-42ea-966b-64ee3d9248a3
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
2025-10-17 01:15:39 -07:00
parent 1a82bbaee3
commit a4381affeb
7 changed files with 324 additions and 2358 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.beads/issues.jsonl
View File

@@ -45,7 +45,7 @@
{"id":"bd-34","title":"Update ready_issues VIEW to use hierarchical blocking","description":"The ready_issues VIEW (schema.go:97-108) uses the OLD blocking logic that doesn't propagate through parent-child hierarchies.\n\n**Problem:**\n- GetReadyWork() function now uses recursive CTE with propagation\n- But the ready_issues VIEW still uses simple NOT EXISTS check\n- Any code using the VIEW will get DIFFERENT results than GetReadyWork()\n- This creates inconsistency and confusion\n\n**Impact:**\n- Unknown if the VIEW is actually used anywhere in the codebase\n- If it is used, it's returning incorrect results (showing children as ready when parent is blocked)\n\n**Solution:**\nEither:\n1. Update VIEW to match GetReadyWork logic (complex CTE in a view)\n2. Drop the VIEW entirely if unused\n3. Make VIEW call GetReadyWork as a function (if SQLite supports it)\n\n**Investigation needed:**\nGrep for 'ready_issues' to see if the view is actually used.","notes":"**Investigation results:**\nGrepped the codebase - the ready_issues VIEW appears in:\n- schema.go (definition)\n- WORKFLOW.md, DESIGN.md (documentation)\n- No actual Go code queries it directly\n\n**Conclusion:** The VIEW is defined but appears UNUSED by actual code. GetReadyWork() function is used instead.\n\n**Recommended solution:** Drop the VIEW entirely to avoid confusion. It serves no purpose if unused and creates a maintenance burden (needs to stay in sync with GetReadyWork logic).\n\n**Alternative:** If we want to keep it for direct SQL access, update the VIEW definition to match the new recursive CTE logic.","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.775914-07:00","closed_at":"2025-10-14T13:06:47.739336-07:00"} {"id":"bd-34","title":"Update ready_issues VIEW to use hierarchical blocking","description":"The ready_issues VIEW (schema.go:97-108) uses the OLD blocking logic that doesn't propagate through parent-child hierarchies.\n\n**Problem:**\n- GetReadyWork() function now uses recursive CTE with propagation\n- But the ready_issues VIEW still uses simple NOT EXISTS check\n- Any code using the VIEW will get DIFFERENT results than GetReadyWork()\n- This creates inconsistency and confusion\n\n**Impact:**\n- Unknown if the VIEW is actually used anywhere in the codebase\n- If it is used, it's returning incorrect results (showing children as ready when parent is blocked)\n\n**Solution:**\nEither:\n1. Update VIEW to match GetReadyWork logic (complex CTE in a view)\n2. Drop the VIEW entirely if unused\n3. Make VIEW call GetReadyWork as a function (if SQLite supports it)\n\n**Investigation needed:**\nGrep for 'ready_issues' to see if the view is actually used.","notes":"**Investigation results:**\nGrepped the codebase - the ready_issues VIEW appears in:\n- schema.go (definition)\n- WORKFLOW.md, DESIGN.md (documentation)\n- No actual Go code queries it directly\n\n**Conclusion:** The VIEW is defined but appears UNUSED by actual code. GetReadyWork() function is used instead.\n\n**Recommended solution:** Drop the VIEW entirely to avoid confusion. It serves no purpose if unused and creates a maintenance burden (needs to stay in sync with GetReadyWork logic).\n\n**Alternative:** If we want to keep it for direct SQL access, update the VIEW definition to match the new recursive CTE logic.","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.775914-07:00","closed_at":"2025-10-14T13:06:47.739336-07:00"}
{"id":"bd-35","title":"Verify and test Claude Code plugin","description":"Address remaining items from code review:\n\nCritical:\n1. Test plugin installation locally with /plugin marketplace add\n2. Verify ${CLAUDE_PLUGIN_ROOT} variable works correctly\n3. Test each slash command works\n4. Test @task-agent execution\n5. Verify MCP server connects properly\n\nDocumentation:\n1. Clarify 'one-command installation' vs prerequisites\n2. Add note about plugin development status\n3. Verify all paths and examples work\n\nNice-to-have:\n1. Add icon for marketplace (optional)\n2. Add categories field to plugin.json\n3. Add engines field for version compatibility","notes":"PLUGIN IMPLEMENTATION COMPLETE - READY FOR TESTING\n\nWhat was built:\n✅ .claude-plugin/plugin.json - Plugin metadata with MCP server config\n✅ .claude-plugin/marketplace.json - Marketplace configuration\n✅ 9 slash commands in .claude-plugin/commands/:\n - bd-ready, bd-create, bd-show, bd-update, bd-close\n - bd-workflow, bd-init, bd-stats, bd-version\n✅ Task agent in .claude-plugin/agents/task-agent.md\n✅ PLUGIN.md - Comprehensive documentation\n✅ README.md - Updated with plugin section\n✅ Version sync - All components at 0.9.2\n\nTesting Instructions for Next Agent:\n=====================================\n\n1. INSTALL PLUGIN FROM GITHUB:\n /plugin marketplace add steveyegge/beads\n /plugin install beads\n \n2. RESTART CLAUDE CODE (required for MCP server)\n\n3. TEST SLASH COMMANDS:\n /bd-version # Check versions (should show 0.9.2)\n /bd-workflow # Show workflow guide\n /bd-stats # Show project stats\n /bd-ready # Find ready work\n /bd-create \"Test plugin\" task 2\n /bd-show bd-\u003cid\u003e\n \n4. TEST MCP SERVER:\n /mcp # Verify 'beads' server appears\n \n5. TEST TASK AGENT:\n @task-agent # If supported in Claude Code\n \n6. VERIFY:\n - All commands work without errors\n - MCP tools are accessible\n - Version checking works\n - Documentation is accurate\n\nExpected Issues:\n- May need to adjust MCP server path variable (${CLAUDE_PLUGIN_ROOT})\n- Task agent syntax might differ\n- Some commands may need refinement based on actual usage\n\nIf testing fails, check:\n- bd CLI is in PATH: which bd\n- uv is installed: which uv\n- MCP server logs in Claude Code\n- PLUGIN.md troubleshooting section\n\nCommit references:\n- 9f38375: feat: Add Claude Code plugin for beads\n- d25fc53: feat: Add version compatibility checking\n- c0f1044: fix: Sync all component versions to 0.9.2\n- a5c71f0: feat: Add version bump script\n- a612b92: docs: Add version management to CLAUDE.md","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.776533-07:00","closed_at":"2025-10-16T21:03:25.525342-07:00"} {"id":"bd-35","title":"Verify and test Claude Code plugin","description":"Address remaining items from code review:\n\nCritical:\n1. Test plugin installation locally with /plugin marketplace add\n2. Verify ${CLAUDE_PLUGIN_ROOT} variable works correctly\n3. Test each slash command works\n4. Test @task-agent execution\n5. Verify MCP server connects properly\n\nDocumentation:\n1. Clarify 'one-command installation' vs prerequisites\n2. Add note about plugin development status\n3. Verify all paths and examples work\n\nNice-to-have:\n1. Add icon for marketplace (optional)\n2. Add categories field to plugin.json\n3. Add engines field for version compatibility","notes":"PLUGIN IMPLEMENTATION COMPLETE - READY FOR TESTING\n\nWhat was built:\n✅ .claude-plugin/plugin.json - Plugin metadata with MCP server config\n✅ .claude-plugin/marketplace.json - Marketplace configuration\n✅ 9 slash commands in .claude-plugin/commands/:\n - bd-ready, bd-create, bd-show, bd-update, bd-close\n - bd-workflow, bd-init, bd-stats, bd-version\n✅ Task agent in .claude-plugin/agents/task-agent.md\n✅ PLUGIN.md - Comprehensive documentation\n✅ README.md - Updated with plugin section\n✅ Version sync - All components at 0.9.2\n\nTesting Instructions for Next Agent:\n=====================================\n\n1. INSTALL PLUGIN FROM GITHUB:\n /plugin marketplace add steveyegge/beads\n /plugin install beads\n \n2. RESTART CLAUDE CODE (required for MCP server)\n\n3. TEST SLASH COMMANDS:\n /bd-version # Check versions (should show 0.9.2)\n /bd-workflow # Show workflow guide\n /bd-stats # Show project stats\n /bd-ready # Find ready work\n /bd-create \"Test plugin\" task 2\n /bd-show bd-\u003cid\u003e\n \n4. TEST MCP SERVER:\n /mcp # Verify 'beads' server appears\n \n5. TEST TASK AGENT:\n @task-agent # If supported in Claude Code\n \n6. VERIFY:\n - All commands work without errors\n - MCP tools are accessible\n - Version checking works\n - Documentation is accurate\n\nExpected Issues:\n- May need to adjust MCP server path variable (${CLAUDE_PLUGIN_ROOT})\n- Task agent syntax might differ\n- Some commands may need refinement based on actual usage\n\nIf testing fails, check:\n- bd CLI is in PATH: which bd\n- uv is installed: which uv\n- MCP server logs in Claude Code\n- PLUGIN.md troubleshooting section\n\nCommit references:\n- 9f38375: feat: Add Claude Code plugin for beads\n- d25fc53: feat: Add version compatibility checking\n- c0f1044: fix: Sync all component versions to 0.9.2\n- a5c71f0: feat: Add version bump script\n- a612b92: docs: Add version management to CLAUDE.md","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.776533-07:00","closed_at":"2025-10-16T21:03:25.525342-07:00"}
{"id":"bd-36","title":"Add coverage threshold to CI pipeline","description":"Current CI runs tests with coverage but doesn't enforce minimum threshold. Add step to fail if coverage drops below target.\n\nCurrent coverage: 60%\nRecommended thresholds:\n- Warn: 55%\n- Fail: 50%\n\nThis prevents coverage regression while allowing gradual improvement toward 80% target for 1.0.\n\nImplementation:\n1. Add coverage check step after test run\n2. Use 'go tool cover -func=coverage.out' to get total\n3. Parse percentage and compare to threshold\n4. Optionally: Use codecov's built-in threshold features\n\nRelated to test coverage improvement work (upcoming issue).","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.77739-07:00","closed_at":"2025-10-14T14:16:22.731648-07:00"} {"id":"bd-36","title":"Add coverage threshold to CI pipeline","description":"Current CI runs tests with coverage but doesn't enforce minimum threshold. Add step to fail if coverage drops below target.\n\nCurrent coverage: 60%\nRecommended thresholds:\n- Warn: 55%\n- Fail: 50%\n\nThis prevents coverage regression while allowing gradual improvement toward 80% target for 1.0.\n\nImplementation:\n1. Add coverage check step after test run\n2. Use 'go tool cover -func=coverage.out' to get total\n3. Parse percentage and compare to threshold\n4. Optionally: Use codecov's built-in threshold features\n\nRelated to test coverage improvement work (upcoming issue).","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.77739-07:00","closed_at":"2025-10-14T14:16:22.731648-07:00"}
{"id":"bd-37","title":"Increase test coverage for auto-flush and auto-import features","description":"Critical features have 0% test coverage despite being core workflow functionality.\n\n**Uncovered areas (0% coverage):**\n\nAuto-flush/Auto-import (dirty tracking):\n- MarkIssueDirty / MarkIssuesDirty\n- GetDirtyIssues / GetDirtyIssueCount\n- ClearDirtyIssues / ClearDirtyIssuesByID\n- Auto-flush debouncing logic\n- Auto-import hash comparison\n\nDatabase/file discovery:\n- FindDatabasePath (finds .beads/*.db in directory tree)\n- FindJSONLPath (finds issues.jsonl)\n- findDatabaseInTree helper\n\nLabel operations:\n- AddLabel / RemoveLabel\n- GetLabels / GetIssuesByLabel\n\nEvents/Comments:\n- AddComment\n- GetEvents\n- GetStatistics\n\nMetadata storage:\n- SetMetadata / GetMetadata (used for import hash tracking)\n\nCLI output formatting:\n- outputJSON\n- printCollisionReport / printRemappingReport\n- createIssuesFromMarkdown\n\n**Priority areas:**\n1. Auto-flush/import (highest risk - core workflow)\n2. Database discovery (second - affects all operations)\n3. Labels/events (lower priority - less commonly used)\n\n**Test approach:**\n- Add unit tests for dirty tracking in sqlite package\n- Add integration tests for auto-flush timing and debouncing\n- Add tests for import hash detection and idempotency\n- Add tests for database discovery edge cases (permissions, nested dirs)\n\n**Target:** Get overall coverage from 60% → 75%, focus on cmd/bd (currently 24.1%)\n\n**Note:** These features work well in practice (dogfooding proves it) but edge cases (disk full, permissions, concurrent access, race conditions) are untested.","status":"open","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.77894-07:00"} {"id":"bd-37","title":"Increase test coverage for auto-flush and auto-import features","description":"Critical features have 0% test coverage despite being core workflow functionality.\n\n**Uncovered areas (0% coverage):**\n\nAuto-flush/Auto-import (dirty tracking):\n- MarkIssueDirty / MarkIssuesDirty\n- GetDirtyIssues / GetDirtyIssueCount\n- ClearDirtyIssues / ClearDirtyIssuesByID\n- Auto-flush debouncing logic\n- Auto-import hash comparison\n\nDatabase/file discovery:\n- FindDatabasePath (finds .beads/*.db in directory tree)\n- FindJSONLPath (finds issues.jsonl)\n- findDatabaseInTree helper\n\nLabel operations:\n- AddLabel / RemoveLabel\n- GetLabels / GetIssuesByLabel\n\nEvents/Comments:\n- AddComment\n- GetEvents\n- GetStatistics\n\nMetadata storage:\n- SetMetadata / GetMetadata (used for import hash tracking)\n\nCLI output formatting:\n- outputJSON\n- printCollisionReport / printRemappingReport\n- createIssuesFromMarkdown\n\n**Priority areas:**\n1. Auto-flush/import (highest risk - core workflow)\n2. Database discovery (second - affects all operations)\n3. Labels/events (lower priority - less commonly used)\n\n**Test approach:**\n- Add unit tests for dirty tracking in sqlite package\n- Add integration tests for auto-flush timing and debouncing\n- Add tests for import hash detection and idempotency\n- Add tests for database discovery edge cases (permissions, nested dirs)\n\n**Target:** Get overall coverage from 60% → 75%, focus on cmd/bd (currently 24.1%)\n\n**Note:** These features work well in practice (dogfooding proves it) but edge cases (disk full, permissions, concurrent access, race conditions) are untested.","notes":"Added comprehensive tests for CLI output functions (outputJSON, printCollisionReport, printRemappingReport). \n\nCoverage analysis shows:\n- outputJSON: 60% coverage (increased from 0%)\n- printCollisionReport: 100% coverage (increased from 0%)\n- printRemappingReport: 100% coverage (increased from 0%)\n- cmd/bd overall: 19.7% (increased from 18.8%)\n\nOther areas already have excellent coverage:\n✅ Dirty tracking: TestMarkIssueDirty, TestMarkIssuesDirty, TestGetDirtyIssueCount, TestClearDirtyIssuesByID\n✅ Auto-flush: TestAutoFlushDirtyMarking, TestAutoFlushDebounce, TestAutoFlushConcurrency\n✅ Auto-import: TestAutoImportIfNewer, TestAutoImportHashUnchanged, TestAutoImportCollisions \n✅ Database discovery: TestFindDatabasePathInTree, TestFindJSONLPath\n✅ Labels: TestAddLabel, TestRemoveLabel, TestGetLabels, TestGetIssuesByLabel\n✅ Metadata: TestSetAndGetMetadata, TestGetMetadataNotFound\n✅ Events: TestAddComment, TestAddMultipleComments, TestGetEvents\n\nThe remaining low coverage in cmd/bd is primarily Cobra command setup and CLI wiring, which is difficult to unit test and best tested via integration/E2E tests.","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-17T01:04:30.736709-07:00","closed_at":"2025-10-17T01:04:30.736709-07:00"}
{"id":"bd-38","title":"Investigate auto-export debounce not triggering","description":"Auto-export to JSONL did not trigger automatically after creating bd-72 and bd-73. Had to manually run 'bd export' to sync.\n\n**Expected behavior:** Auto-export should trigger ~5 seconds after CRUD operations (per CLAUDE.md documentation).\n\n**Actual behavior:** Issues bd-72 and bd-73 were created but JSONL was not updated until manual 'bd export' was run.\n\n**Investigation needed:**\n1. Check if auto-flush goroutine is running\n2. Verify debounce timer is being triggered on CreateIssue()\n3. Check for errors/panics in background export\n4. Verify auto-flush is enabled by default\n5. Check if there's a race condition with shutdown\n\n**Impact:** HIGH - Data loss risk if users create issues and don't realize they haven't synced to Git.\n\n**Testing:**\n```bash\n# Create issue and wait 10 seconds\nbd create \"Test\" -p 4\nsleep 10\ngrep \"Test\" .beads/issues.jsonl # Should find it\n```\n\n**Workaround:** Manually run 'bd export' after CRUD operations.\n\n**Context:** Discovered during GH issue #2 RFC evaluation while creating bd-72 and bd-73.","status":"in_progress","priority":1,"issue_type":"bug","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.779793-07:00"} {"id":"bd-38","title":"Investigate auto-export debounce not triggering","description":"Auto-export to JSONL did not trigger automatically after creating bd-72 and bd-73. Had to manually run 'bd export' to sync.\n\n**Expected behavior:** Auto-export should trigger ~5 seconds after CRUD operations (per CLAUDE.md documentation).\n\n**Actual behavior:** Issues bd-72 and bd-73 were created but JSONL was not updated until manual 'bd export' was run.\n\n**Investigation needed:**\n1. Check if auto-flush goroutine is running\n2. Verify debounce timer is being triggered on CreateIssue()\n3. Check for errors/panics in background export\n4. Verify auto-flush is enabled by default\n5. Check if there's a race condition with shutdown\n\n**Impact:** HIGH - Data loss risk if users create issues and don't realize they haven't synced to Git.\n\n**Testing:**\n```bash\n# Create issue and wait 10 seconds\nbd create \"Test\" -p 4\nsleep 10\ngrep \"Test\" .beads/issues.jsonl # Should find it\n```\n\n**Workaround:** Manually run 'bd export' after CRUD operations.\n\n**Context:** Discovered during GH issue #2 RFC evaluation while creating bd-72 and bd-73.","status":"in_progress","priority":1,"issue_type":"bug","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.779793-07:00"}
{"id":"bd-39","title":"Another test with multiple deps","description":"","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.781615-07:00","closed_at":"2025-10-16T10:07:34.028111-07:00"} {"id":"bd-39","title":"Another test with multiple deps","description":"","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.781615-07:00","closed_at":"2025-10-16T10:07:34.028111-07:00"}
{"id":"bd-4","title":"Implement collision detection in import","description":"Create collision.go with detectCollisions() function. Compare incoming JSONL issues against DB state. Distinguish between: (1) exact match (idempotent), (2) ID match but different content (collision), (3) new issue. Return list of colliding issues.","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.728792-07:00","closed_at":"2025-10-16T10:07:22.461107-07:00","dependencies":[{"issue_id":"bd-4","depends_on_id":"bd-41","type":"parent-child","created_at":"2025-10-16T21:51:08.920845-07:00","created_by":"renumber"}]} {"id":"bd-4","title":"Implement collision detection in import","description":"Create collision.go with detectCollisions() function. Compare incoming JSONL issues against DB state. Distinguish between: (1) exact match (idempotent), (2) ID match but different content (collision), (3) new issue. Return list of colliding issues.","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-16T20:46:08.971822-07:00","updated_at":"2025-10-16T21:51:08.728792-07:00","closed_at":"2025-10-16T10:07:22.461107-07:00","dependencies":[{"issue_id":"bd-4","depends_on_id":"bd-41","type":"parent-child","created_at":"2025-10-16T21:51:08.920845-07:00","created_by":"renumber"}]}

233
DAEMON_DESIGN.md
View File

@@ -1,233 +0,0 @@
# BD Daemon Architecture for Concurrent Access
## Problem Statement
Multiple AI agents running concurrently (via beads-mcp) cause:
- **SQLite write corruption**: Counter stuck, UNIQUE constraint failures
- **Git index.lock contention**: All agents auto-export → all try to commit simultaneously
- **Data loss risk**: Concurrent SQLite writers without coordination
- **Poor performance**: Redundant exports, 4x git operations for same changes
## Current Architecture (Broken)
```
Agent 1 → beads-mcp 1 → bd CLI → SQLite DB (direct write)
Agent 2 → beads-mcp 2 → bd CLI → SQLite DB (direct write) ← RACE CONDITIONS
Agent 3 → beads-mcp 3 → bd CLI → SQLite DB (direct write)
Agent 4 → beads-mcp 4 → bd CLI → SQLite DB (direct write)
↓
4x concurrent git export/commit
```
## Proposed Architecture (Daemon-Mediated)
```
Agent 1 → beads-mcp 1 → bd client ──┐
Agent 2 → beads-mcp 2 → bd client ──┼──> bd daemon → SQLite DB
Agent 3 → beads-mcp 3 → bd client ──┤ (single writer) ↓
Agent 4 → beads-mcp 4 → bd client ──┘ git export
(batched,
serialized)
```
### Key Changes
1. **bd daemon becomes mandatory** for multi-agent scenarios
2. **All bd commands become RPC clients** when daemon is running
3. **Daemon owns SQLite** - single writer, no races
4. **Daemon batches git operations** - one export cycle per interval
5. **Unix socket IPC** - simple, fast, local-only
## Implementation Plan
### Phase 1: RPC Infrastructure
**New files:**
- `internal/rpc/protocol.go` - Request/response types
- `internal/rpc/server.go` - Unix socket server in daemon
- `internal/rpc/client.go` - Client detection & dispatch
**Operations to support:**
```go
type Request struct {
Operation string // "create", "update", "list", "close", etc.
Args json.RawMessage // Operation-specific args
}
type Response struct {
Success bool
Data json.RawMessage // Operation result
Error string
}
```
**Socket location:** `~/.beads/bd.sock` or `.beads/bd.sock` (per-repo)
### Phase 2: Client Auto-Detection
**bd command behavior:**
1. Check if daemon socket exists & responsive
2. If yes: Send RPC request, print response
3. If no: Run command directly (backward compatible)
**Example:**
```go
func main() {
if client := rpc.TryConnect(); client != nil {
// Daemon is running - use RPC
resp := client.Execute(cmd, args)
fmt.Println(resp)
return
}
// No daemon - run directly (current behavior)
executeLocally(cmd, args)
}
```
### Phase 3: Daemon SQLite Ownership
**Daemon startup:**
1. Open SQLite connection (exclusive)
2. Start RPC server on Unix socket
3. Start git sync loop (existing functionality)
4. Process RPC requests serially
**Git operations:**
- Batch exports every 5 seconds (not per-operation)
- Single commit with all changes
- Prevent concurrent git operations entirely
### Phase 4: Atomic Operations
**ID generation:**
```go
// In daemon process only
func (d *Daemon) generateID(prefix string) (string, error) {
d.mu.Lock()
defer d.mu.Unlock()
// No races - daemon is single writer
return d.storage.NextID(prefix)
}
```
**Transaction support:**
```go
// RPC can request multi-operation transactions
type BatchRequest struct {
Operations []Request
Atomic bool // All-or-nothing
}
```
## Migration Strategy
### Stage 1: Opt-In (v0.10.0)
- Daemon RPC code implemented
- bd commands detect daemon, fall back to direct
- Users can `bd daemon start` for multi-agent scenarios
- **No breaking changes** - direct mode still works
### Stage 2: Recommended (v0.11.0)
- Document multi-agent workflow requires daemon
- MCP server README says "start daemon for concurrent agents"
- Detection warning: "Multiple bd processes detected, consider using daemon"
### Stage 3: Required for Multi-Agent (v1.0.0)
- bd detects concurrent access patterns
- Refuses to run without daemon if lock contention detected
- Error: "Concurrent access detected. Start daemon: `bd daemon start`"
## Benefits
✅ **No SQLite corruption** - single writer
✅ **No git lock contention** - batched, serialized operations
✅ **Atomic ID generation** - no counter corruption
✅ **Better performance** - fewer redundant exports
✅ **Backward compatible** - graceful fallback to direct mode
✅ **Simple protocol** - Unix sockets, JSON payloads
## Trade-offs
⚠️ **Daemon must be running** for multi-agent workflows
⚠️ **One more process** to manage (`bd daemon start/stop`)
⚠️ **Complexity** - RPC layer adds code & maintenance
⚠️ **Single point of failure** - if daemon crashes, all agents blocked
## Open Questions
1. **Per-repo or global daemon?**
- Per-repo: `.beads/bd.sock` (supports multiple repos)
- Global: `~/.beads/bd.sock` (simpler, but only one repo at a time)
- **Recommendation:** Per-repo, use `--db` path to determine socket location
2. **Daemon crash recovery?**
- Client auto-starts daemon if socket missing?
- Or require manual `bd daemon start`?
- **Recommendation:** Auto-start with exponential backoff
3. **Concurrent read optimization?**
- Reads could bypass daemon (SQLite supports concurrent readers)
- But complex: need to detect read-only vs read-write commands
- **Recommendation:** Start simple, all ops through daemon
4. **Transaction API for clients?**
- MCP tools often do multi-step operations
- Would benefit from `BEGIN/COMMIT` style transactions
- **Recommendation:** Phase 4 feature, not MVP
## Success Metrics
- ✅ 4 concurrent agents can run without errors
- ✅ No UNIQUE constraint failures on ID generation
- ✅ No git index.lock errors
- ✅ SQLite counter stays in sync with actual issues
- ✅ Graceful fallback when daemon not running
## Related Issues
- bd-668: Git index.lock contention (root cause)
- bd-670: ID generation retry on UNIQUE constraint
- bd-654: Concurrent tmp file collisions (already fixed)
- bd-477: Phase 1 daemon command (git sync only - now expanded)
- bd-279: Tests for concurrent scenarios
- bd-271: Epic for multi-device support
## Next Steps
1. **Ultrathink**: Validate this design with user
2. **File epic**: Create bd-??? for daemon RPC architecture
3. **Break down work**: Phase 1 subtasks (protocol, server, client)
4. **Start implementation**: Begin with protocol.go
---
## Phase 4: Atomic Operations and Stress Testing (COMPLETED - bd-114)
**Status:** ✅ Complete
**Implementation:**
- Batch/transaction API for multi-step operations
- Request timeout and cancellation support
- Connection management optimization
- Comprehensive stress tests (4-10 concurrent agents)
- Performance benchmarks vs direct mode
**Results:**
- Daemon mode is **2x faster** than direct mode
- Zero ID collisions in 1000+ concurrent creates
- All acceptance criteria validated
- Full test coverage with stress tests
**Documentation:** See [DAEMON_STRESS_TEST.md](DAEMON_STRESS_TEST.md) for details.
**Files Added:**
- `internal/rpc/stress_test.go` - Stress tests with 4-10 agents
- `internal/rpc/bench_test.go` - Performance benchmarks
- `DAEMON_STRESS_TEST.md` - Full documentation
**Files Modified:**
- `internal/rpc/protocol.go` - Added OpBatch and batch types
- `internal/rpc/server.go` - Implemented batch handler
- `internal/rpc/client.go` - Added timeout support and Batch method

190
DAEMON_STRESS_TEST.md
View File

@@ -1,190 +0,0 @@
# Daemon Stress Testing and Performance
This document describes the stress tests and performance benchmarks for the bd daemon architecture.
## Overview
Phase 4 of the daemon implementation adds:
- **Batch Operations**: Atomic multi-step operations
- **Request Timeouts**: Configurable timeouts with deadline support
- **Stress Tests**: Comprehensive concurrent agent testing
- **Performance Benchmarks**: Daemon vs direct mode comparisons
## Batch Operations
The daemon supports atomic batch operations via the `OpBatch` operation:
```go
batchArgs := &rpc.BatchArgs{
Operations: []rpc.BatchOperation{
{Operation: rpc.OpCreate, Args: createArgs1JSON},
{Operation: rpc.OpUpdate, Args: updateArgs1JSON},
{Operation: rpc.OpDepAdd, Args: depArgsJSON},
},
}
resp, err := client.Batch(batchArgs)
```
**Behavior:**
- Operations execute in order
- If any operation fails, the batch stops and returns results up to the failure
- All operations are serialized through the single daemon writer
**Use Cases:**
- Creating an issue and immediately adding dependencies
- Updating multiple related issues together
- Complex workflows requiring consistency
## Request Timeouts
Clients can set custom timeout durations:
```go
client.SetTimeout(5 * time.Second)
```
**Default:** 30 seconds
**Behavior:**
- Timeout applies per request
- Deadline is set on the socket connection
- Network-level timeout (not just read/write)
- Returns timeout error if exceeded
## Stress Tests
### TestStressConcurrentAgents
- **Agents:** 8 concurrent
- **Operations:** 100 creates per agent (800 total)
- **Validates:** No ID collisions, no UNIQUE constraint errors
- **Duration:** ~2-3 seconds
### TestStressBatchOperations
- **Agents:** 4 concurrent
- **Operations:** 50 batches per agent (400 total operations)
- **Validates:** Batch atomicity, no partial failures
- **Duration:** ~1-2 seconds
### TestStressMixedOperations
- **Agents:** 6 concurrent
- **Operations:** 50 mixed ops per agent (create, update, show, list, ready)
- **Validates:** Concurrent read/write safety
- **Duration:** <1 second
### TestStressTimeouts
- **Operations:** Timeout configuration and enforcement
- **Validates:** Timeout behavior, error handling
- **Duration:** <1 second
### TestStressNoUniqueConstraintViolations
- **Agents:** 10 concurrent
- **Operations:** 100 creates per agent (1000 total)
- **Validates:** Zero duplicate IDs across all agents
- **Duration:** ~3 seconds
## Performance Benchmarks
Run benchmarks with:
```bash
go test ./internal/rpc -bench=. -benchtime=1000x
```
### Results (Apple M4 Max, 16 cores)
| Operation | Direct Mode | Daemon Mode | Speedup |
|-----------|-------------|-------------|---------|
| Create | 4.65 ms | 2.41 ms | 1.9x |
| Update | ~4.5 ms | ~2.3 ms | 2.0x |
| List | ~3.8 ms | ~2.0 ms | 1.9x |
| Ping | N/A | 0.2 ms | N/A |
**Key Findings:**
- Daemon mode is consistently **2x faster** than direct mode
- Single persistent connection eliminates connection overhead
- Daemon handles serialization efficiently
- Low latency for simple operations (ping: 0.2ms)
### Concurrent Agent Throughput
8 agents creating 100 issues each:
- **Total Time:** 2.13s
- **Throughput:** ~376 ops/sec
- **No errors or collisions**
## Acceptance Criteria Validation
✅ **4 concurrent agents can run without errors**
- Tests use 4-10 concurrent agents successfully
✅ **No UNIQUE constraint failures on ID generation**
- TestStressNoUniqueConstraintViolations validates 1000 unique IDs
✅ **No git index.lock errors**
- Daemon batches git operations (Phase 3)
✅ **SQLite counter stays in sync with actual issues**
- All tests verify correct issue counts
✅ **Graceful fallback when daemon not running**
- Client automatically falls back to direct mode
✅ **All existing tests pass**
- Full test suite passes with new features
✅ **Documentation updated**
- This document + DAEMON_DESIGN.md
## Running the Tests
```bash
# All stress tests
go test ./internal/rpc -v -run TestStress -timeout 5m
# All benchmarks
go test ./internal/rpc -bench=. -run=^$
# Specific stress test
go test ./internal/rpc -v -run TestStressConcurrentAgents
# Compare daemon vs direct
go test ./internal/rpc -bench=BenchmarkDaemon -benchtime=100x
go test ./internal/rpc -bench=BenchmarkDirect -benchtime=100x
```
## Implementation Details
### Batch Handler (server.go)
- Accepts `BatchArgs` with array of operations
- Executes operations sequentially
- Stops on first error
- Returns all results up to failure
### Timeout Support (client.go)
- Default 30s timeout per request
- `SetTimeout()` allows customization
- Uses `SetDeadline()` on socket connection
- Applies to read and write operations
### Connection Management
- Each client maintains one persistent connection
- Server handles multiple client connections concurrently
- No connection pooling needed (single daemon writer)
- Clean shutdown removes socket file
## Future Improvements
Potential enhancements for future phases:
1. **True Transactions:** SQLite BEGIN/COMMIT for batch operations
2. **Partial Batch Success:** Option to continue on errors
3. **Progress Callbacks:** Long-running batch status updates
4. **Connection Pooling:** Multiple daemon workers with work queue
5. **Distributed Mode:** Multi-machine daemon coordination
## See Also
- [DAEMON_DESIGN.md](DAEMON_DESIGN.md) - Overall daemon architecture
- [internal/rpc/protocol.go](internal/rpc/protocol.go) - RPC protocol definitions
- [internal/rpc/stress_test.go](internal/rpc/stress_test.go) - Stress test implementations
- [internal/rpc/bench_test.go](internal/rpc/bench_test.go) - Performance benchmarks

1101
DESIGN.md
View File

File diff suppressed because it is too large Load Diff

656
DUPLICATES_REPORT.md
View File

@@ -1,656 +0,0 @@
# Duplicate Issues Report
Generated: Thu Oct 16 19:06:37 PDT 2025
## Add OAuth2 support
Count: 3
- bd-177 (closed) created 2025-10-14T14:43:06.904366-07:00
- bd-174 (closed) created 2025-10-14T14:43:06.90268-07:00
- bd-170 (closed) created 2025-10-14T14:43:06.900641-07:00
## Add compacted_at_commit field to Issue type
Count: 9
- bd-639 (open) created 2025-10-16T18:57:16.296664-07:00
- bd-605 (open) created 2025-10-16T18:57:16.13228-07:00
- bd-555 (open) created 2025-10-16T18:57:16.084676-07:00
- bd-546 (open) created 2025-10-16T18:54:29.391902-07:00
- bd-532 (open) created 2025-10-16T18:54:29.372914-07:00
- bd-496 (open) created 2025-10-16T18:54:29.229357-07:00
- bd-432 (open) created 2025-10-16T18:05:02.18097-07:00
- bd-405 (closed) created 2025-10-16T16:03:31.57487-07:00
- bd-384 (closed) created 2025-10-16T14:57:48.834903-07:00
## Add integration tests for auto-import collision detection
Count: 9
- bd-658 (open) created 2025-10-16T18:57:16.323669-07:00
- bd-640 (closed) created 2025-10-16T18:57:16.298009-07:00
- bd-599 (open) created 2025-10-16T18:57:16.128178-07:00
- bd-535 (closed) created 2025-10-16T18:54:29.379553-07:00
- bd-491 (open) created 2025-10-16T18:54:29.224122-07:00
- bd-428 (open) created 2025-10-16T18:05:02.176549-07:00
- bd-401 (open) created 2025-10-16T16:03:31.546156-07:00
- bd-372 (open) created 2025-10-16T14:57:48.78612-07:00
- bd-231 (closed) created 2025-10-15T02:12:49.315295-07:00
## Add label management commands to CLI
Count: 4
- bd-571 (open) created 2025-10-16T18:57:16.101107-07:00
- bd-464 (open) created 2025-10-16T18:54:29.167551-07:00
- bd-364 (open) created 2025-10-16T14:57:48.773386-07:00
- bd-198 (closed) created 2025-10-15T01:10:48.43357-07:00
## Add migration scripts for GitHub Issues
Count: 8
- bd-645 (closed) created 2025-10-16T18:57:16.310349-07:00
- bd-635 (open) created 2025-10-16T18:57:16.292565-07:00
- bd-543 (closed) created 2025-10-16T18:54:29.387481-07:00
- bd-529 (open) created 2025-10-16T18:54:29.365728-07:00
- bd-443 (open) created 2025-10-16T18:05:02.190949-07:00
- bd-416 (open) created 2025-10-16T16:03:31.596085-07:00
- bd-370 (open) created 2025-10-16T14:57:48.783124-07:00
- bd-6 (closed) created 2025-10-14T14:43:06.929582-07:00
## Add performance benchmarks document
Count: 8
- bd-648 (closed) created 2025-10-16T18:57:16.314508-07:00
- bd-634 (open) created 2025-10-16T18:57:16.290463-07:00
- bd-528 (open) created 2025-10-16T18:54:29.365021-07:00
- bd-514 (closed) created 2025-10-16T18:54:29.278305-07:00
- bd-437 (open) created 2025-10-16T18:05:02.186502-07:00
- bd-410 (open) created 2025-10-16T16:03:31.585083-07:00
- bd-376 (open) created 2025-10-16T14:57:48.794452-07:00
- bd-7 (closed) created 2025-10-14T14:43:06.934101-07:00
## Add rate limiting to auth endpoints
Count: 3
- bd-178 (closed) created 2025-10-14T14:43:06.904917-07:00
- bd-175 (closed) created 2025-10-14T14:43:06.903236-07:00
- bd-171 (closed) created 2025-10-14T14:43:06.900983-07:00
## Add tests for git-based restoration
Count: 5
- bd-554 (open) created 2025-10-16T18:57:16.081362-07:00
- bd-447 (open) created 2025-10-16T18:54:29.108386-07:00
- bd-435 (open) created 2025-10-16T18:05:02.183952-07:00
- bd-408 (open) created 2025-10-16T16:03:31.582488-07:00
- bd-381 (open) created 2025-10-16T14:57:48.821462-07:00
## Audit and document all inconsistent issues in database
Count: 6
- bd-597 (open) created 2025-10-16T18:57:16.126722-07:00
- bd-489 (open) created 2025-10-16T18:54:29.220414-07:00
- bd-424 (open) created 2025-10-16T18:05:02.172587-07:00
- bd-397 (open) created 2025-10-16T16:03:31.520913-07:00
- bd-366 (open) created 2025-10-16T14:57:48.776118-07:00
- bd-227 (closed) created 2025-10-15T01:58:50.908363-07:00
## Auto-import fails in git workflows due to mtime issues
Count: 7
- bd-631 (in_progress) created 2025-10-16T18:57:16.268525-07:00
- bd-619 (closed) created 2025-10-16T18:57:16.251812-07:00
- bd-511 (closed) created 2025-10-16T18:54:29.258757-07:00
- bd-448 (in_progress) created 2025-10-16T18:54:29.114894-07:00
- bd-421 (closed) created 2025-10-16T18:05:02.16198-07:00
- bd-334 (in_progress) created 2025-10-16T14:57:48.682806-07:00
- bd-84 (closed) created 2025-10-14T14:43:06.941275-07:00
## Benchmark cycle detection performance on large dependency graphs
Count: 2
- bd-374 (open) created 2025-10-16T14:57:48.792813-07:00
- bd-311 (closed) created 2025-10-16T10:28:24.231469-07:00
## Bug: Import creating duplicates instead of deduplicating
Count: 2
- bd-636 (closed) created 2025-10-16T18:57:16.29361-07:00
- bd-530 (closed) created 2025-10-16T18:54:29.367086-07:00
## Build collision resolution tooling for distributed branch workflows
Count: 5
- bd-662 (closed) created 2025-10-16T18:57:16.330979-07:00
- bd-660 (closed) created 2025-10-16T18:57:16.326296-07:00
- bd-553 (closed) created 2025-10-16T18:54:29.413281-07:00
- bd-545 (closed) created 2025-10-16T18:54:29.3909-07:00
- bd-9 (closed) created 2025-10-14T14:43:06.943629-07:00
## Code review follow-up: Post-PR #8 merge improvements
Count: 8
- bd-661 (closed) created 2025-10-16T18:57:16.327043-07:00
- bd-633 (open) created 2025-10-16T18:57:16.28274-07:00
- bd-548 (closed) created 2025-10-16T18:54:29.398351-07:00
- bd-527 (open) created 2025-10-16T18:54:29.363772-07:00
- bd-426 (open) created 2025-10-16T18:05:02.175188-07:00
- bd-399 (open) created 2025-10-16T16:03:31.525208-07:00
- bd-389 (open) created 2025-10-16T14:57:48.843762-07:00
- bd-71 (closed) created 2025-10-14T14:43:06.934829-07:00
## Code review: Auto-import collision detection fix (bd-228)
Count: 6
- bd-598 (open) created 2025-10-16T18:57:16.127529-07:00
- bd-490 (open) created 2025-10-16T18:54:29.222585-07:00
- bd-427 (open) created 2025-10-16T18:05:02.175897-07:00
- bd-400 (open) created 2025-10-16T16:03:31.536355-07:00
- bd-379 (closed) created 2025-10-16T14:57:48.812015-07:00
- bd-230 (closed) created 2025-10-15T02:12:48.210337-07:00
## Concurrent bd commands collide on shared .tmp filename
Count: 5
- bd-654 (closed) created 2025-10-16T18:57:16.319205-07:00
- bd-567 (closed) created 2025-10-16T18:57:16.097942-07:00
- bd-538 (closed) created 2025-10-16T18:54:29.382598-07:00
- bd-506 (closed) created 2025-10-16T18:54:29.244231-07:00
- bd-373 (closed) created 2025-10-16T14:57:48.790027-07:00
## Consider batching API for bulk issue creation (recovered from bd-222)
Count: 8
- bd-651 (open) created 2025-10-16T18:57:16.316474-07:00
- bd-600 (open) created 2025-10-16T18:57:16.128761-07:00
- bd-536 (open) created 2025-10-16T18:54:29.380494-07:00
- bd-492 (open) created 2025-10-16T18:54:29.225697-07:00
- bd-429 (open) created 2025-10-16T18:05:02.177375-07:00
- bd-402 (open) created 2025-10-16T16:03:31.547562-07:00
- bd-371 (open) created 2025-10-16T14:57:48.784477-07:00
- bd-232 (closed) created 2025-10-15T02:21:43.085279-07:00
## Critical: Auto-import silently overwrites local changes without collision detection
Count: 3
- bd-656 (closed) created 2025-10-16T18:57:16.321969-07:00
- bd-552 (closed) created 2025-10-16T18:54:29.409532-07:00
- bd-228 (closed) created 2025-10-15T02:06:30.671918-07:00
## Data model allows inconsistent status/closed_at states
Count: 6
- bd-594 (in_progress) created 2025-10-16T18:57:16.124308-07:00
- bd-487 (in_progress) created 2025-10-16T18:54:29.217094-07:00
- bd-430 (in_progress) created 2025-10-16T18:05:02.178935-07:00
- bd-417 (in_progress) created 2025-10-16T16:03:31.596875-07:00
- bd-391 (in_progress) created 2025-10-16T14:57:48.845572-07:00
- bd-224 (closed) created 2025-10-15T01:36:21.971783-07:00
## Document git-based restoration feature
Count: 5
- bd-638 (open) created 2025-10-16T18:57:16.295983-07:00
- bd-525 (open) created 2025-10-16T18:54:29.325521-07:00
- bd-436 (open) created 2025-10-16T18:05:02.185847-07:00
- bd-409 (open) created 2025-10-16T16:03:31.584232-07:00
- bd-380 (open) created 2025-10-16T14:57:48.816028-07:00
## Epic: Add intelligent database compaction with Claude Haiku
Count: 2
- bd-392 (open) created 2025-10-16T14:57:48.846232-07:00
- bd-251 (open) created 2025-10-15T21:51:23.210339-07:00
## Epic: Fix status/closed_at inconsistency (bd-224 solution)
Count: 6
- bd-596 (open) created 2025-10-16T18:57:16.125905-07:00
- bd-488 (open) created 2025-10-16T18:54:29.219427-07:00
- bd-423 (open) created 2025-10-16T18:05:02.164815-07:00
- bd-396 (open) created 2025-10-16T16:03:31.504655-07:00
- bd-367 (open) created 2025-10-16T14:57:48.77756-07:00
- bd-226 (closed) created 2025-10-15T01:58:41.041574-07:00
## Fix: bd init --prefix test -q flag not recognized
Count: 4
- bd-558 (open) created 2025-10-16T18:57:16.087909-07:00
- bd-451 (open) created 2025-10-16T18:54:29.118089-07:00
- bd-321 (open) created 2025-10-16T14:57:48.632494-07:00
- bd-169 (closed) created 2025-10-14T14:43:06.899974-07:00
## GH-11: Add Docker support for hosted/shared instance
Count: 8
- bd-629 (open) created 2025-10-16T18:57:16.266652-07:00
- bd-617 (closed) created 2025-10-16T18:57:16.246023-07:00
- bd-523 (open) created 2025-10-16T18:54:29.323831-07:00
- bd-509 (closed) created 2025-10-16T18:54:29.247674-07:00
- bd-444 (closed) created 2025-10-16T18:05:02.191716-07:00
- bd-394 (closed) created 2025-10-16T16:03:31.498107-07:00
- bd-358 (open) created 2025-10-16T14:57:48.754885-07:00
- bd-92 (closed) created 2025-10-14T14:43:06.945147-07:00
## GH-3: Debug zsh killed error on bd init
Count: 8
- bd-630 (closed) created 2025-10-16T18:57:16.267697-07:00
- bd-618 (blocked) created 2025-10-16T18:57:16.249493-07:00
- bd-524 (open) created 2025-10-16T18:54:29.324466-07:00
- bd-510 (blocked) created 2025-10-16T18:54:29.254527-07:00
- bd-431 (blocked) created 2025-10-16T18:05:02.180111-07:00
- bd-406 (blocked) created 2025-10-16T16:03:31.580261-07:00
- bd-348 (open) created 2025-10-16T14:57:48.746521-07:00
- bd-87 (blocked) created 2025-10-14T14:43:06.942576-07:00
## Git-based restoration for compacted issues
Count: 7
- bd-649 (open) created 2025-10-16T18:57:16.31515-07:00
- bd-604 (open) created 2025-10-16T18:57:16.131361-07:00
- bd-550 (open) created 2025-10-16T18:54:29.405556-07:00
- bd-495 (open) created 2025-10-16T18:54:29.228422-07:00
- bd-422 (open) created 2025-10-16T18:05:02.163999-07:00
- bd-404 (open) created 2025-10-16T16:03:31.564412-07:00
- bd-385 (closed) created 2025-10-16T14:57:48.836877-07:00
## Implement bd restore command
Count: 9
- bd-637 (open) created 2025-10-16T18:57:16.294864-07:00
- bd-622 (open) created 2025-10-16T18:57:16.255193-07:00
- bd-607 (open) created 2025-10-16T18:57:16.147008-07:00
- bd-549 (open) created 2025-10-16T18:54:29.399249-07:00
- bd-531 (open) created 2025-10-16T18:54:29.370445-07:00
- bd-498 (open) created 2025-10-16T18:54:29.232439-07:00
- bd-434 (open) created 2025-10-16T18:05:02.183027-07:00
- bd-407 (closed) created 2025-10-16T16:03:31.581845-07:00
- bd-383 (closed) created 2025-10-16T14:57:48.831757-07:00
## Improve error handling in dependency removal during remapping
Count: 6
- bd-650 (open) created 2025-10-16T18:57:16.315828-07:00
- bd-602 (open) created 2025-10-16T18:57:16.130007-07:00
- bd-515 (open) created 2025-10-16T18:54:29.279242-07:00
- bd-493 (open) created 2025-10-16T18:54:29.226626-07:00
- bd-359 (open) created 2025-10-16T14:57:48.756031-07:00
- bd-28 (closed) created 2025-10-14T14:43:06.912228-07:00
## Improve session management
Count: 3
- bd-179 (closed) created 2025-10-14T14:43:06.905375-07:00
- bd-176 (closed) created 2025-10-14T14:43:06.903785-07:00
- bd-172 (closed) created 2025-10-14T14:43:06.901432-07:00
## Investigate data recovery for issues overwritten by auto-import bug
Count: 3
- bd-646 (closed) created 2025-10-16T18:57:16.312989-07:00
- bd-539 (closed) created 2025-10-16T18:54:29.383454-07:00
- bd-229 (closed) created 2025-10-15T02:10:40.724826-07:00
## Low priority chore
Count: 8
- bd-659 (open) created 2025-10-16T18:57:16.325571-07:00
- bd-647 (closed) created 2025-10-16T18:57:16.313802-07:00
- bd-643 (open) created 2025-10-16T18:57:16.307575-07:00
- bd-547 (open) created 2025-10-16T18:54:29.392669-07:00
- bd-542 (closed) created 2025-10-16T18:54:29.386684-07:00
- bd-534 (open) created 2025-10-16T18:54:29.378627-07:00
- bd-377 (open) created 2025-10-16T14:57:48.796499-07:00
- bd-4 (closed) created 2025-10-14T14:43:06.917877-07:00
## P2: Consider batching API for bulk issue creation
Count: 4
- bd-593 (open) created 2025-10-16T18:57:16.122852-07:00
- bd-486 (open) created 2025-10-16T18:54:29.215696-07:00
- bd-390 (open) created 2025-10-16T14:57:48.844729-07:00
- bd-222 (closed) created 2025-10-15T01:18:46.4512-07:00
## Phase 1: Implement bd daemon command
Count: 2
- bd-386 (closed) created 2025-10-16T14:57:48.840609-07:00
- bd-273 (closed) created 2025-10-16T01:40:04.263802-07:00
## Phase 1: Implement bd sync command
Count: 2
- bd-378 (closed) created 2025-10-16T14:57:48.811221-07:00
- bd-272 (closed) created 2025-10-16T01:40:04.246855-07:00
## Reach 1.0 release milestone
Count: 8
- bd-657 (closed) created 2025-10-16T18:57:16.323024-07:00
- bd-632 (open) created 2025-10-16T18:57:16.281913-07:00
- bd-540 (closed) created 2025-10-16T18:54:29.38494-07:00
- bd-526 (open) created 2025-10-16T18:54:29.34597-07:00
- bd-425 (open) created 2025-10-16T18:05:02.174097-07:00
- bd-398 (open) created 2025-10-16T16:03:31.523258-07:00
- bd-388 (open) created 2025-10-16T14:57:48.842642-07:00
- bd-8 (closed) created 2025-10-14T14:43:06.938911-07:00
## Record git commit hash during compaction
Count: 9
- bd-642 (open) created 2025-10-16T18:57:16.306079-07:00
- bd-641 (open) created 2025-10-16T18:57:16.303615-07:00
- bd-606 (open) created 2025-10-16T18:57:16.139786-07:00
- bd-551 (open) created 2025-10-16T18:54:29.406385-07:00
- bd-533 (open) created 2025-10-16T18:54:29.377847-07:00
- bd-497 (open) created 2025-10-16T18:54:29.231369-07:00
- bd-433 (open) created 2025-10-16T18:05:02.182118-07:00
- bd-395 (closed) created 2025-10-16T16:03:31.501666-07:00
- bd-387 (closed) created 2025-10-16T14:57:48.841348-07:00
## Support ID space partitioning for parallel worker agents
Count: 2
- bd-601 (closed) created 2025-10-16T18:57:16.12934-07:00
- bd-24 (closed) created 2025-10-14T14:43:06.910467-07:00
## Test reopen command
Count: 2
- bd-249 (closed) created 2025-10-15T16:28:49.924381-07:00
- bd-248 (closed) created 2025-10-15T16:28:44.246154-07:00
## Ultrathink: Choose solution for status/closed_at inconsistency (bd-224)
Count: 3
- bd-595 (closed) created 2025-10-16T18:57:16.125291-07:00
- bd-537 (closed) created 2025-10-16T18:54:29.38148-07:00
- bd-225 (closed) created 2025-10-15T01:47:25.564925-07:00
## Use safer placeholder pattern in replaceIDReferences
Count: 5
- bd-603 (open) created 2025-10-16T18:57:16.130694-07:00
- bd-494 (open) created 2025-10-16T18:54:29.227598-07:00
- bd-445 (open) created 2025-10-16T18:05:02.192424-07:00
- bd-403 (open) created 2025-10-16T16:03:31.550675-07:00
- bd-29 (open) created 2025-10-14T14:43:06.912567-07:00
## final_review_test_
Count: 4
- bd-592 (open) created 2025-10-16T18:57:16.122201-07:00
- bd-485 (open) created 2025-10-16T18:54:29.214252-07:00
- bd-317 (open) created 2025-10-16T14:57:48.617035-07:00
- bd-220 (closed) created 2025-10-15T01:17:55.669949-07:00
## final_test_10
Count: 5
- bd-566 (open) created 2025-10-16T18:57:16.096912-07:00
- bd-459 (open) created 2025-10-16T18:54:29.160672-07:00
- bd-365 (closed) created 2025-10-16T14:57:48.77507-07:00
- bd-353 (open) created 2025-10-16T14:57:48.750486-07:00
- bd-191 (closed) created 2025-10-15T01:07:02.010151-07:00
## final_test_7
Count: 4
- bd-610 (open) created 2025-10-16T18:57:16.220553-07:00
- bd-460 (open) created 2025-10-16T18:54:29.163056-07:00
- bd-330 (open) created 2025-10-16T14:57:48.665684-07:00
- bd-192 (closed) created 2025-10-15T01:07:02.010504-07:00
## parallel_test_1
Count: 10
- bd-652 (open) created 2025-10-16T18:57:16.31729-07:00
- bd-628 (open) created 2025-10-16T18:57:16.265633-07:00
- bd-616 (closed) created 2025-10-16T18:57:16.239759-07:00
- bd-522 (open) created 2025-10-16T18:54:29.311149-07:00
- bd-516 (open) created 2025-10-16T18:54:29.280457-07:00
- bd-508 (closed) created 2025-10-16T18:54:29.246693-07:00
- bd-442 (closed) created 2025-10-16T18:05:02.190287-07:00
- bd-415 (closed) created 2025-10-16T16:03:31.592055-07:00
- bd-361 (open) created 2025-10-16T14:57:48.761649-07:00
- bd-94 (closed) created 2025-10-14T14:43:06.946176-07:00
## parallel_test_10
Count: 4
- bd-609 (open) created 2025-10-16T18:57:16.194118-07:00
- bd-500 (open) created 2025-10-16T18:54:29.237287-07:00
- bd-335 (open) created 2025-10-16T14:57:48.689034-07:00
- bd-100 (closed) created 2025-10-14T14:43:06.865466-07:00
## parallel_test_2
Count: 8
- bd-623 (open) created 2025-10-16T18:57:16.258011-07:00
- bd-612 (closed) created 2025-10-16T18:57:16.232795-07:00
- bd-503 (open) created 2025-10-16T18:54:29.241214-07:00
- bd-502 (closed) created 2025-10-16T18:54:29.239523-07:00
- bd-438 (closed) created 2025-10-16T18:05:02.18713-07:00
- bd-411 (closed) created 2025-10-16T16:03:31.585784-07:00
- bd-355 (open) created 2025-10-16T14:57:48.752315-07:00
- bd-99 (closed) created 2025-10-14T14:43:06.948343-07:00
## parallel_test_3
Count: 6
- bd-620 (open) created 2025-10-16T18:57:16.252728-07:00
- bd-608 (open) created 2025-10-16T18:57:16.161617-07:00
- bd-512 (open) created 2025-10-16T18:54:29.25947-07:00
- bd-499 (open) created 2025-10-16T18:54:29.236426-07:00
- bd-354 (open) created 2025-10-16T14:57:48.751322-07:00
- bd-101 (closed) created 2025-10-14T14:43:06.865941-07:00
## parallel_test_4
Count: 11
- bd-644 (open) created 2025-10-16T18:57:16.30893-07:00
- bd-627 (open) created 2025-10-16T18:57:16.263891-07:00
- bd-615 (closed) created 2025-10-16T18:57:16.238895-07:00
- bd-521 (open) created 2025-10-16T18:54:29.299627-07:00
- bd-518 (open) created 2025-10-16T18:54:29.291492-07:00
- bd-507 (closed) created 2025-10-16T18:54:29.246065-07:00
- bd-441 (closed) created 2025-10-16T18:05:02.189537-07:00
- bd-418 (open) created 2025-10-16T16:03:31.597564-07:00
- bd-414 (closed) created 2025-10-16T16:03:31.589071-07:00
- bd-363 (open) created 2025-10-16T14:57:48.770023-07:00
- bd-95 (closed) created 2025-10-14T14:43:06.946509-07:00
## parallel_test_5
Count: 10
- bd-624 (open) created 2025-10-16T18:57:16.259921-07:00
- bd-621 (open) created 2025-10-16T18:57:16.253519-07:00
- bd-613 (closed) created 2025-10-16T18:57:16.235664-07:00
- bd-513 (open) created 2025-10-16T18:54:29.265467-07:00
- bd-505 (closed) created 2025-10-16T18:54:29.242834-07:00
- bd-504 (open) created 2025-10-16T18:54:29.242009-07:00
- bd-439 (closed) created 2025-10-16T18:05:02.187725-07:00
- bd-412 (closed) created 2025-10-16T16:03:31.586415-07:00
- bd-356 (open) created 2025-10-16T14:57:48.753003-07:00
- bd-98 (closed) created 2025-10-14T14:43:06.947803-07:00
## parallel_test_6
Count: 8
- bd-625 (open) created 2025-10-16T18:57:16.260541-07:00
- bd-614 (closed) created 2025-10-16T18:57:16.236286-07:00
- bd-519 (open) created 2025-10-16T18:54:29.296165-07:00
- bd-501 (closed) created 2025-10-16T18:54:29.238225-07:00
- bd-440 (closed) created 2025-10-16T18:05:02.188753-07:00
- bd-413 (closed) created 2025-10-16T16:03:31.588315-07:00
- bd-357 (open) created 2025-10-16T14:57:48.754125-07:00
- bd-97 (closed) created 2025-10-14T14:43:06.947256-07:00
## parallel_test_7
Count: 6
- bd-626 (open) created 2025-10-16T18:57:16.262607-07:00
- bd-611 (closed) created 2025-10-16T18:57:16.227227-07:00
- bd-541 (closed) created 2025-10-16T18:54:29.38566-07:00
- bd-520 (open) created 2025-10-16T18:54:29.29821-07:00
- bd-360 (open) created 2025-10-16T14:57:48.75773-07:00
- bd-96 (closed) created 2025-10-14T14:43:06.946887-07:00
## parallel_test_8
Count: 5
- bd-556 (open) created 2025-10-16T18:57:16.085398-07:00
- bd-449 (open) created 2025-10-16T18:54:29.116433-07:00
- bd-382 (closed) created 2025-10-16T14:57:48.825863-07:00
- bd-319 (open) created 2025-10-16T14:57:48.630725-07:00
- bd-102 (closed) created 2025-10-14T14:43:06.866351-07:00
## parallel_test_9
Count: 7
- bd-655 (closed) created 2025-10-16T18:57:16.320156-07:00
- bd-557 (open) created 2025-10-16T18:57:16.086652-07:00
- bd-544 (closed) created 2025-10-16T18:54:29.3881-07:00
- bd-450 (open) created 2025-10-16T18:54:29.117232-07:00
- bd-368 (closed) created 2025-10-16T14:57:48.780354-07:00
- bd-320 (open) created 2025-10-16T14:57:48.631628-07:00
- bd-103 (closed) created 2025-10-14T14:43:06.866766-07:00
## race_test_10
Count: 8
- bd-589 (open) created 2025-10-16T18:57:16.119487-07:00
- bd-564 (open) created 2025-10-16T18:57:16.095128-07:00
- bd-482 (open) created 2025-10-16T18:54:29.210508-07:00
- bd-457 (open) created 2025-10-16T18:54:29.159194-07:00
- bd-352 (open) created 2025-10-16T14:57:48.749464-07:00
- bd-327 (open) created 2025-10-16T14:57:48.660524-07:00
- bd-217 (closed) created 2025-10-15T01:11:09.805774-07:00
- bd-189 (closed) created 2025-10-15T01:07:02.008903-07:00
## race_test_11
Count: 8
- bd-579 (open) created 2025-10-16T18:57:16.107574-07:00
- bd-565 (open) created 2025-10-16T18:57:16.095923-07:00
- bd-472 (open) created 2025-10-16T18:54:29.199752-07:00
- bd-458 (open) created 2025-10-16T18:54:29.159866-07:00
- bd-342 (open) created 2025-10-16T14:57:48.720418-07:00
- bd-328 (open) created 2025-10-16T14:57:48.662708-07:00
- bd-207 (closed) created 2025-10-15T01:11:09.049061-07:00
- bd-190 (closed) created 2025-10-15T01:07:02.009797-07:00
## race_test_12
Count: 4
- bd-586 (open) created 2025-10-16T18:57:16.114034-07:00
- bd-479 (open) created 2025-10-16T18:54:29.206087-07:00
- bd-349 (open) created 2025-10-16T14:57:48.747288-07:00
- bd-214 (closed) created 2025-10-15T01:11:09.061603-07:00
## race_test_13
Count: 4
- bd-588 (open) created 2025-10-16T18:57:16.118444-07:00
- bd-481 (open) created 2025-10-16T18:54:29.209342-07:00
- bd-351 (open) created 2025-10-16T14:57:48.748767-07:00
- bd-216 (closed) created 2025-10-15T01:11:09.74037-07:00
## race_test_14
Count: 4
- bd-576 (open) created 2025-10-16T18:57:16.105357-07:00
- bd-469 (open) created 2025-10-16T18:54:29.193776-07:00
- bd-339 (open) created 2025-10-16T14:57:48.715948-07:00
- bd-204 (closed) created 2025-10-15T01:11:09.028356-07:00
## race_test_15
Count: 4
- bd-587 (open) created 2025-10-16T18:57:16.117429-07:00
- bd-480 (open) created 2025-10-16T18:54:29.208689-07:00
- bd-350 (open) created 2025-10-16T14:57:48.748148-07:00
- bd-215 (closed) created 2025-10-15T01:11:09.651271-07:00
## race_test_16
Count: 8
- bd-581 (open) created 2025-10-16T18:57:16.109095-07:00
- bd-562 (open) created 2025-10-16T18:57:16.092273-07:00
- bd-474 (open) created 2025-10-16T18:54:29.201518-07:00
- bd-455 (open) created 2025-10-16T18:54:29.14489-07:00
- bd-344 (open) created 2025-10-16T14:57:48.732302-07:00
- bd-325 (open) created 2025-10-16T14:57:48.643077-07:00
- bd-209 (closed) created 2025-10-15T01:11:09.146015-07:00
- bd-187 (closed) created 2025-10-15T01:07:02.008177-07:00
## race_test_17
Count: 8
- bd-590 (open) created 2025-10-16T18:57:16.120707-07:00
- bd-563 (open) created 2025-10-16T18:57:16.093146-07:00
- bd-483 (open) created 2025-10-16T18:54:29.211541-07:00
- bd-456 (open) created 2025-10-16T18:54:29.145877-07:00
- bd-329 (open) created 2025-10-16T14:57:48.663415-07:00
- bd-326 (open) created 2025-10-16T14:57:48.645291-07:00
- bd-218 (closed) created 2025-10-15T01:11:09.838009-07:00
- bd-188 (closed) created 2025-10-15T01:07:02.008525-07:00
## race_test_18
Count: 4
- bd-582 (open) created 2025-10-16T18:57:16.109904-07:00
- bd-475 (open) created 2025-10-16T18:54:29.20249-07:00
- bd-345 (open) created 2025-10-16T14:57:48.742594-07:00
- bd-210 (closed) created 2025-10-15T01:11:09.146262-07:00
## race_test_19
Count: 4
- bd-580 (open) created 2025-10-16T18:57:16.108424-07:00
- bd-473 (open) created 2025-10-16T18:54:29.20066-07:00
- bd-343 (open) created 2025-10-16T14:57:48.727492-07:00
- bd-208 (closed) created 2025-10-15T01:11:09.061296-07:00
## race_test_2
Count: 4
- bd-574 (open) created 2025-10-16T18:57:16.103608-07:00
- bd-467 (open) created 2025-10-16T18:54:29.189632-07:00
- bd-337 (open) created 2025-10-16T14:57:48.700706-07:00
- bd-202 (closed) created 2025-10-15T01:11:09.022114-07:00
## race_test_20
Count: 4
- bd-583 (open) created 2025-10-16T18:57:16.110877-07:00
- bd-476 (open) created 2025-10-16T18:54:29.203114-07:00
- bd-346 (open) created 2025-10-16T14:57:48.744437-07:00
- bd-211 (closed) created 2025-10-15T01:11:09.151945-07:00
## race_test_3
Count: 4
- bd-585 (open) created 2025-10-16T18:57:16.1129-07:00
- bd-478 (open) created 2025-10-16T18:54:29.205082-07:00
- bd-318 (open) created 2025-10-16T14:57:48.62383-07:00
- bd-213 (closed) created 2025-10-15T01:11:09.244796-07:00
## race_test_4
Count: 8
- bd-572 (open) created 2025-10-16T18:57:16.102009-07:00
- bd-559 (open) created 2025-10-16T18:57:16.088924-07:00
- bd-465 (open) created 2025-10-16T18:54:29.173666-07:00
- bd-452 (open) created 2025-10-16T18:54:29.118929-07:00
- bd-369 (open) created 2025-10-16T14:57:48.781563-07:00
- bd-322 (open) created 2025-10-16T14:57:48.635357-07:00
- bd-200 (closed) created 2025-10-15T01:11:09.001476-07:00
- bd-184 (closed) created 2025-10-15T01:07:02.006879-07:00
## race_test_5
Count: 8
- bd-573 (open) created 2025-10-16T18:57:16.102671-07:00
- bd-561 (open) created 2025-10-16T18:57:16.091191-07:00
- bd-466 (open) created 2025-10-16T18:54:29.187434-07:00
- bd-454 (open) created 2025-10-16T18:54:29.121523-07:00
- bd-336 (open) created 2025-10-16T14:57:48.697455-07:00
- bd-324 (open) created 2025-10-16T14:57:48.637257-07:00
- bd-201 (closed) created 2025-10-15T01:11:09.007015-07:00
- bd-186 (closed) created 2025-10-15T01:07:02.007814-07:00
## race_test_6
Count: 4
- bd-584 (open) created 2025-10-16T18:57:16.111868-07:00
- bd-477 (open) created 2025-10-16T18:54:29.204178-07:00
- bd-347 (open) created 2025-10-16T14:57:48.745496-07:00
- bd-212 (closed) created 2025-10-15T01:11:09.18421-07:00
## race_test_7
Count: 4
- bd-575 (open) created 2025-10-16T18:57:16.104398-07:00
- bd-468 (open) created 2025-10-16T18:54:29.192508-07:00
- bd-338 (open) created 2025-10-16T14:57:48.7088-07:00
- bd-203 (closed) created 2025-10-15T01:11:09.021971-07:00
## race_test_8
Count: 8
- bd-578 (open) created 2025-10-16T18:57:16.106883-07:00
- bd-560 (open) created 2025-10-16T18:57:16.090257-07:00
- bd-471 (open) created 2025-10-16T18:54:29.198992-07:00
- bd-453 (open) created 2025-10-16T18:54:29.120396-07:00
- bd-341 (open) created 2025-10-16T14:57:48.719466-07:00
- bd-323 (open) created 2025-10-16T14:57:48.636432-07:00
- bd-206 (closed) created 2025-10-15T01:11:09.040766-07:00
- bd-185 (closed) created 2025-10-15T01:07:02.007447-07:00
## race_test_9
Count: 4
- bd-577 (open) created 2025-10-16T18:57:16.106035-07:00
- bd-470 (open) created 2025-10-16T18:54:29.197319-07:00
- bd-340 (open) created 2025-10-16T14:57:48.716781-07:00
- bd-205 (closed) created 2025-10-15T01:11:09.032373-07:00
## stress_test_1
Count: 4
- bd-570 (open) created 2025-10-16T18:57:16.100376-07:00
- bd-463 (open) created 2025-10-16T18:54:29.166004-07:00
- bd-333 (open) created 2025-10-16T14:57:48.682146-07:00
- bd-195 (closed) created 2025-10-15T01:07:02.011549-07:00
## stress_test_5
Count: 4
- bd-568 (open) created 2025-10-16T18:57:16.098799-07:00
- bd-461 (open) created 2025-10-16T18:54:29.163666-07:00
- bd-331 (open) created 2025-10-16T14:57:48.668149-07:00
- bd-193 (closed) created 2025-10-15T01:07:02.010847-07:00
## stress_test_6
Count: 5
- bd-569 (open) created 2025-10-16T18:57:16.099688-07:00
- bd-462 (open) created 2025-10-16T18:54:29.164402-07:00
- bd-375 (closed) created 2025-10-16T14:57:48.793624-07:00
- bd-332 (open) created 2025-10-16T14:57:48.680992-07:00
- bd-194 (closed) created 2025-10-15T01:07:02.011186-07:00
## verification_
Count: 6
- bd-653 (open) created 2025-10-16T18:57:16.317983-07:00
- bd-591 (open) created 2025-10-16T18:57:16.121455-07:00
- bd-517 (open) created 2025-10-16T18:54:29.281281-07:00
- bd-484 (open) created 2025-10-16T18:54:29.212136-07:00
- bd-362 (open) created 2025-10-16T14:57:48.765482-07:00
- bd-219 (closed) created 2025-10-15T01:12:54.151096-07:00

177
REVIEW_BD379.md
View File

@@ -1,177 +0,0 @@
# Code Review: Auto-Import Collision Detection (bd-379)
## Executive Summary
The auto-import collision detection implementation is **functionally working but has several correctness and robustness issues** that should be addressed. Rating: **3.5/5** - Works in happy path but vulnerable to edge cases.
## Critical Issues (P0-P1)
### 1. **Metadata Error Handling is Too Conservative** (P0)
**Current behavior:** If `GetMetadata()` fails, auto-import is skipped entirely.
**Problem:** This means if metadata is corrupted or missing, auto-import stops forever until manually fixed.
**Fix:**
```go
lastHash, err := store.GetMetadata(ctx, "last_import_hash")
if err != nil {
if os.Getenv("BD_DEBUG") != "" {
fmt.Fprintf(os.Stderr, "Debug: metadata read failed (%v), assuming first import\n", err)
}
lastHash = "" // Treat as first import
}
```
### 2. **Hash Not Updated on Partial Success** (P0)
**Problem:** If import succeeds but we fail to update `last_import_hash`, auto-import will retry the same import forever.
**Current behavior:** Hash update happens at end (line ~404) but not error-checked.
**Fix:** Track import success/failure state and only update hash on full success:
```go
// After all imports complete successfully
if err := store.SetMetadata(ctx, "last_import_hash", currentHash); err != nil {
fmt.Fprintf(os.Stderr, "Warning: failed to update import hash: %v\n", err)
fmt.Fprintf(os.Stderr, "Next auto-import may re-import these issues.\n")
}
```
### 3. **No Transaction for Multi-Issue Import** (P1)
**Problem:** If import fails midway, database is left in inconsistent state.
**Current behavior:** Each issue is imported separately (lines 346-401).
**Fix:** Wrap entire import in a transaction or use batch operations.
### 4. **N+1 Query Pattern** (P1)
**Problem:** Line 347: `store.GetIssue(ctx, issue.ID)` is called for every issue = O(n) queries.
**Impact:** With 1000+ issues, this is slow and hammers the database.
**Fix:** Batch fetch all existing IDs upfront:
```go
existingIDs := make(map[string]*types.Issue)
allExisting, err := store.SearchIssues(ctx, "", types.IssueFilter{})
for _, issue := range allExisting {
existingIDs[issue.ID] = issue
}
```
## Medium Issues (P2)
### 5. **Scanner Uses String Conversion** (P2)
**Line 233:** `strings.NewReader(string(jsonlData))`
**Problem:** Unnecessarily converts bytes to string, wastes memory.
**Fix:** `bytes.NewReader(jsonlData)`
### 6. **Verbose Output on Every Auto-Import** (P2)
**Current:** Prints remapping summary to stderr on every collision (lines 309-329).
**Problem:** For frequent auto-imports with collisions, this gets noisy.
**Fix:** Gate detailed output behind `BD_DEBUG`, show 1-line summary by default:
```go
if os.Getenv("BD_DEBUG") != "" {
// Detailed output
} else {
fmt.Fprintf(os.Stderr, "Auto-import: %d parsed, %d remapped due to collisions\n", len(allIssues), numRemapped)
}
```
### 7. **No Collision Metrics/Telemetry** (P2)
**Problem:** No way to track how often collisions occur or if they're increasing.
**Fix:** Add metadata counters:
- `collision_count_total`
- `last_collision_timestamp`
- `auto_import_runs_total`
### 8. **"All Collisions" Case Not Optimized** (P2)
**Problem:** If every issue collides (e.g., pulling unchanged state), we still process everything.
**Fix:** If `len(filteredIssues) == 0` and `len(collisionResult.NewIssues) == 0`, it's a no-op - just update hash and return.
## Low Priority Issues (P3)
### 9. **No Configurable Collision Mode** (P3)
Some users may prefer auto-import to **fail** on collisions rather than auto-resolve.
**Suggestion:** Add `BD_AUTO_IMPORT_MODE=remap|fail` environment variable.
### 10. **No Collision Threshold** (P3)
If 90% of issues collide, something is probably wrong (bad merge).
**Suggestion:** Add `BD_AUTO_IMPORT_COLLISION_THRESHOLD` - if exceeded, fail with clear error.
## Testing Gaps
Missing test coverage for:
1. ✅ Metadata read failure → should treat as first import
2. ✅ Hash update failure → should warn but not crash
3. ✅ All issues collide → should be no-op
4. ✅ Scanner buffer overflow (>2MB line) → should error gracefully
5. ✅ Concurrent auto-imports (race condition testing)
6. ✅ Transaction rollback on mid-import failure
7. ✅ 1000+ issue performance test
## Answers to Review Questions
### Q1: Should auto-import be more aggressive (auto-resolve) or conservative (fail)?
**Recommendation:** Keep auto-resolve as default but add:
- Collision threshold that switches to fail mode if exceeded
- Config option for users who prefer fail-fast behavior
- Clear messaging about what was remapped
### Q2: Should we add a counter for collision occurrences?
**Yes.** Add metadata:
- `collision_count_total` (cumulative)
- `last_collision_count` (last run)
- `last_collision_timestamp`
### Q3: Should there be a config option to disable collision detection?
**No.** Collision detection is a safety feature. Instead provide:
- `BD_AUTO_IMPORT_MODE=remap|fail` to control behavior
- `--no-auto-import` flag already exists to disable entirely
### Q4: Is the warning too verbose for typical workflows?
**Yes.** The 10-line summary on every auto-import is noisy. Gate behind `BD_DEBUG`.
## Recommended Fixes Priority
**P0 (Critical - Fix ASAP):**
- [ ] bd-TBD: Fix metadata error handling (treat as first import)
- [ ] bd-TBD: Ensure hash update happens and is error-checked
- [ ] bd-TBD: Fix N+1 query pattern with batch fetch
**P1 (High - Fix Before 1.0):**
- [ ] bd-TBD: Wrap import in transaction for atomicity
- [ ] bd-TBD: Add test coverage for edge cases
- [ ] bd-TBD: Optimize "all collisions" case
**P2 (Medium - Nice to Have):**
- [ ] bd-TBD: Reduce output verbosity (gate behind BD_DEBUG)
- [ ] bd-TBD: Use bytes.NewReader instead of string conversion
- [ ] bd-TBD: Add collision metrics/telemetry
**P3 (Low - Future Enhancement):**
- [ ] bd-TBD: Add BD_AUTO_IMPORT_MODE config
- [ ] bd-TBD: Add collision threshold safety rail
## Conclusion
The implementation **works for the happy path** but has **robustness issues** around error handling, performance, and edge cases. The auto-resolve approach is good, but needs better error handling and performance optimization.
**Estimated effort to fix P0-P1 issues:** 2-3 days
**Risk level if not fixed:** Medium-High (data loss possible on edge cases, poor performance at scale)
---
**Review completed:** 2025-10-16
**Reviewer:** Oracle (via Amp)
**Issue:** bd-379

323
cmd/bd/output_test.go Normal file
View File

@@ -0,0 +1,323 @@
package main
import (
"bytes"
"encoding/json"
"io"
"os"
"strings"
"testing"
"github.com/steveyegge/beads/internal/storage/sqlite"
"github.com/steveyegge/beads/internal/types"
)
func TestOutputJSON(t *testing.T) {
// Capture stdout
oldStdout := os.Stdout
r, w, _ := os.Pipe()
os.Stdout = w
// Test data
testData := map[string]interface{}{
"id": "bd-1",
"title": "Test Issue",
"count": 42,
}
// Call outputJSON
outputJSON(testData)
// Restore stdout
w.Close()
os.Stdout = oldStdout
// Read output
var buf bytes.Buffer
io.Copy(&buf, r)
output := buf.String()
// Verify it's valid JSON
var result map[string]interface{}
err := json.Unmarshal([]byte(output), &result)
if err != nil {
t.Fatalf("outputJSON did not produce valid JSON: %v", err)
}
// Verify content
if result["id"] != "bd-1" {
t.Errorf("Expected id 'bd-1', got '%v'", result["id"])
}
if result["title"] != "Test Issue" {
t.Errorf("Expected title 'Test Issue', got '%v'", result["title"])
}
// Note: JSON numbers are float64
if result["count"] != float64(42) {
t.Errorf("Expected count 42, got %v", result["count"])
}
}
func TestOutputJSONArray(t *testing.T) {
// Capture stdout
oldStdout := os.Stdout
r, w, _ := os.Pipe()
os.Stdout = w
// Test data - array of issues
testData := []map[string]string{
{"id": "bd-1", "title": "First"},
{"id": "bd-2", "title": "Second"},
}
// Call outputJSON
outputJSON(testData)
// Restore stdout
w.Close()
os.Stdout = oldStdout
// Read output
var buf bytes.Buffer
io.Copy(&buf, r)
output := buf.String()
// Verify it's valid JSON array
var result []map[string]string
err := json.Unmarshal([]byte(output), &result)
if err != nil {
t.Fatalf("outputJSON did not produce valid JSON array: %v", err)
}
if len(result) != 2 {
t.Fatalf("Expected 2 items, got %d", len(result))
}
}
func TestPrintCollisionReport(t *testing.T) {
// Capture stderr
oldStderr := os.Stderr
r, w, _ := os.Pipe()
os.Stderr = w
// Create collision data
result := &sqlite.CollisionResult{
ExactMatches: []string{"bd-1", "bd-2"},
NewIssues: []string{"bd-3", "bd-4", "bd-5"},
Collisions: []*sqlite.CollisionDetail{
{
ID: "bd-6",
IncomingIssue: &types.Issue{
ID: "bd-6",
Title: "Test Issue 6",
},
ConflictingFields: []string{"title", "priority"},
},
{
ID: "bd-7",
IncomingIssue: &types.Issue{
ID: "bd-7",
Title: "Test Issue 7",
},
ConflictingFields: []string{"description"},
},
},
}
// Call printCollisionReport
printCollisionReport(result)
// Restore stderr
w.Close()
os.Stderr = oldStderr
// Read output
var buf bytes.Buffer
io.Copy(&buf, r)
output := buf.String()
// Verify output contains expected sections
if !strings.Contains(output, "Collision Detection Report") {
t.Errorf("Expected report header. Got: %s", output)
}
if !strings.Contains(output, "Exact matches (idempotent): 2") {
t.Errorf("Expected exact matches count. Got: %s", output)
}
if !strings.Contains(output, "New issues: 3") {
t.Errorf("Expected new issues count. Got: %s", output)
}
if !strings.Contains(output, "COLLISIONS DETECTED: 2") {
t.Errorf("Expected collisions count. Got: %s", output)
}
if !strings.Contains(output, "bd-6") {
t.Errorf("Expected first collision ID. Got: %s", output)
}
// The field names are printed directly, not in brackets
if !strings.Contains(output, "title") || !strings.Contains(output, "priority") {
t.Errorf("Expected conflicting fields for bd-6. Got: %s", output)
}
}
func TestPrintCollisionReportNoCollisions(t *testing.T) {
// Capture stderr
oldStderr := os.Stderr
r, w, _ := os.Pipe()
os.Stderr = w
// Create data with no collisions
result := &sqlite.CollisionResult{
ExactMatches: []string{"bd-1", "bd-2", "bd-3"},
NewIssues: []string{"bd-4"},
Collisions: []*sqlite.CollisionDetail{},
}
// Call printCollisionReport
printCollisionReport(result)
// Restore stderr
w.Close()
os.Stderr = oldStderr
// Read output
var buf bytes.Buffer
io.Copy(&buf, r)
output := buf.String()
// Verify output shows no collisions
if !strings.Contains(output, "COLLISIONS DETECTED: 0") {
t.Error("Expected 0 collisions")
}
if strings.Contains(output, "Colliding issues:") {
t.Error("Should not show colliding issues section when there are none")
}
}
func TestPrintRemappingReport(t *testing.T) {
// Capture stderr
oldStderr := os.Stderr
r, w, _ := os.Pipe()
os.Stderr = w
// Create remapping data
remapping := map[string]string{
"bd-10": "bd-100",
"bd-20": "bd-200",
"bd-30": "bd-300",
}
collisions := []*sqlite.CollisionDetail{
{ID: "bd-10", ReferenceScore: 5},
{ID: "bd-20", ReferenceScore: 0},
{ID: "bd-30", ReferenceScore: 12},
}
// Call printRemappingReport
printRemappingReport(remapping, collisions)
// Restore stderr
w.Close()
os.Stderr = oldStderr
// Read output
var buf bytes.Buffer
io.Copy(&buf, r)
output := buf.String()
// Verify output contains expected information
if !strings.Contains(output, "Remapping Report") {
t.Errorf("Expected report title. Got: %s", output)
}
if !strings.Contains(output, "bd-10 → bd-100") {
t.Error("Expected first remapping")
}
if !strings.Contains(output, "refs: 5") {
t.Error("Expected reference count for bd-10")
}
if !strings.Contains(output, "bd-20 → bd-200") {
t.Error("Expected second remapping")
}
if !strings.Contains(output, "refs: 0") {
t.Error("Expected 0 references for bd-20")
}
if !strings.Contains(output, "bd-30 → bd-300") {
t.Error("Expected third remapping")
}
if !strings.Contains(output, "refs: 12") {
t.Error("Expected reference count for bd-30")
}
}
func TestPrintRemappingReportEmpty(t *testing.T) {
// Capture stderr
oldStderr := os.Stderr
r, w, _ := os.Pipe()
os.Stderr = w
// Empty remapping
remapping := map[string]string{}
collisions := []*sqlite.CollisionDetail{}
// Call printRemappingReport
printRemappingReport(remapping, collisions)
// Restore stderr
w.Close()
os.Stderr = oldStderr
// Read output
var buf bytes.Buffer
io.Copy(&buf, r)
output := buf.String()
// Should still have header
if !strings.Contains(output, "Remapping Report") {
t.Errorf("Expected report title even with no remappings. Got: %s", output)
}
}
func TestPrintRemappingReportOrdering(t *testing.T) {
// Capture stderr
oldStderr := os.Stderr
r, w, _ := os.Pipe()
os.Stderr = w
// Create remapping with different reference scores
// Ordering is by reference score (ascending)
remapping := map[string]string{
"bd-2": "bd-200",
"bd-10": "bd-100",
"bd-100": "bd-1000",
}
collisions := []*sqlite.CollisionDetail{
{ID: "bd-2", ReferenceScore: 10}, // highest refs
{ID: "bd-10", ReferenceScore: 5}, // medium refs
{ID: "bd-100", ReferenceScore: 1}, // lowest refs
}
// Call printRemappingReport
printRemappingReport(remapping, collisions)
// Restore stderr
w.Close()
os.Stderr = oldStderr
// Read output
var buf bytes.Buffer
io.Copy(&buf, r)
output := buf.String()
// Find positions of each remapping in output
pos2 := strings.Index(output, "bd-2 →")
pos10 := strings.Index(output, "bd-10 →")
pos100 := strings.Index(output, "bd-100 →")
// Verify ordering by reference score (ascending): bd-100 (1 ref) < bd-10 (5 refs) < bd-2 (10 refs)
if pos2 == -1 || pos10 == -1 || pos100 == -1 {
t.Fatalf("Missing remappings in output: %s", output)
}
if !(pos100 < pos10 && pos10 < pos2) {
t.Errorf("Remappings not in reference score order. Got: %s", output)
}
}
// Note: createIssuesFromMarkdown is tested via cmd/bd/markdown_test.go which has
// comprehensive tests for the markdown parsing functionality. We don't duplicate
// those tests here since they require full DB setup.