johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: improve issue ID prefix extraction for word-like suffixes

Browse Source 
Refine ExtractIssuePrefix to better distinguish hash IDs from English
words in multi-part issue IDs. Hash suffixes now require digits or be
exactly 3 chars, preventing "test", "gate", "part" from being treated
as hashes. This fixes prefix extraction for IDs like "vc-baseline-test".

Also updates git hooks to use -q flag and adds AGENTS.md documentation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-16 13:18:30 -08:00
parent c95bc6c21d
commit aed166fe85
9 changed files with 85 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
internal/storage/sqlite/sqlite_test.go
View File

@@ -404,12 +404,18 @@ func TestCreateIssues(t *testing.T) {
checkFunc: func(t *testing.T, h *createIssuesTestHelper, issues []*types.Issue) {},
},
{
name: "closed_at invariant - closed status without closed_at",
name: "closed_at invariant - closed status without closed_at auto-sets it (GH#523)",
issues: []*types.Issue{
h.newIssue("", "Missing closed_at", types.StatusClosed, 1, types.TypeTask, nil),
},
wantErr: true,
checkFunc: func(t *testing.T, h *createIssuesTestHelper, issues []*types.Issue) {},
wantErr: false, // Defensive fix auto-sets closed_at instead of rejecting
checkFunc: func(t *testing.T, h *createIssuesTestHelper, issues []*types.Issue) {
h.assertCount(issues, 1)
h.assertEqual(types.StatusClosed, issues[0].Status, "status")
if issues[0].ClosedAt == nil {
t.Error("ClosedAt should be auto-set for closed issues (GH#523 defensive fix)")
}
},
},
{
name: "nil item in batch",
@@ -807,17 +813,20 @@ func TestClosedAtInvariant(t *testing.T) {
}
})
t.Run("CreateIssue rejects closed issue without closed_at", func(t *testing.T) {
t.Run("CreateIssue auto-sets closed_at for closed issue (GH#523)", func(t *testing.T) {
issue := &types.Issue{
Title: "Test",
Status: types.StatusClosed,
Priority: 2,
IssueType: types.TypeTask,
ClosedAt: nil, // Invalid: closed without closed_at
ClosedAt: nil, // Defensive fix should auto-set this
}
err := store.CreateIssue(ctx, issue, "test-user")
if err == nil {
t.Error("CreateIssue should reject closed issue without closed_at")
if err != nil {
t.Errorf("CreateIssue should auto-set closed_at (GH#523 defensive fix), got error: %v", err)
}
if issue.ClosedAt == nil {
t.Error("ClosedAt should be auto-set for closed issues (GH#523 defensive fix)")
}
})