From b273465966e675615ef40dc543017262eaef3673 Mon Sep 17 00:00:00 2001 From: Steve Yegge Date: Tue, 30 Dec 2025 00:36:38 -0800 Subject: [PATCH] chore: remove stale TODOs for implemented Expand/ExpandVars (bd-qe7j) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Step.Expand and Step.ExpandVars are implemented in ApplyInlineExpansions (expand.go), but had stale TODO comments claiming they were not - Updated doc comments to reference the implementation - Updated bd-7zka to reflect which features are still not implemented (Step.Condition and Step.Gate remain as future work) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- internal/formula/types.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/formula/types.go b/internal/formula/types.go index 8c79fcb8..f7c542ba 100644 --- a/internal/formula/types.go +++ b/internal/formula/types.go @@ -166,12 +166,12 @@ type Step struct { Assignee string `json:"assignee,omitempty"` // Expand references an expansion formula to inline here. - // When set, this step is replaced by the expansion's steps. - // TODO(bd-7zka): Not yet implemented in bd cook. Filed as future work. + // When set, this step is replaced by the expansion's template steps. + // See ApplyInlineExpansions in expand.go for implementation. Expand string `json:"expand,omitempty"` // ExpandVars are variable overrides for the expansion. - // TODO(bd-7zka): Not yet implemented in bd cook. Filed as future work. + // Merged with the expansion formula's default vars during inline expansion. ExpandVars map[string]string `json:"expand_vars,omitempty"` // Condition makes this step optional based on a variable.