johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(unix): handle Statfs field types for disk space check (#646)

Browse Source 
* fix(unix): handle Statfs field types for disk space check

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

* fix(freebsd): build disk space check without type mismatch

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

---------

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This commit is contained in:
Jordan Hubbard
2025-12-19 17:50:14 -08:00
committed by GitHub
parent 13a471fe45
commit b69df499ea
5 changed files with 57 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
internal/rpc/limits_test.go
View File

@@ -36,7 +36,7 @@ func TestConnectionLimits(t *testing.T) {
}
defer store.Close()
socketPath := filepath.Join(tmpDir, "test.sock")
socketPath := newTestSocketPath(t)
// Set low connection limit for testing
os.Setenv("BEADS_DAEMON_MAX_CONNS", "5")
@@ -158,7 +158,7 @@ func TestRequestTimeout(t *testing.T) {
}
defer store.Close()
socketPath := filepath.Join(tmpDir, "test.sock")
socketPath := newTestSocketPath(t)
// Set very short timeout for testing
os.Setenv("BEADS_DAEMON_REQUEST_TIMEOUT", "100ms")
@@ -199,14 +199,9 @@ func TestRequestTimeout(t *testing.T) {
}
func TestHealthResponseIncludesLimits(t *testing.T) {
tmpDir, err := os.MkdirTemp("", "bd-limits-test-*")
if err != nil {
t.Fatal(err)
}
defer os.RemoveAll(tmpDir)
tmpDir := t.TempDir()
dbPath := filepath.Join(tmpDir, "test.db")
socketPath := filepath.Join(tmpDir, "test.sock")
socketPath := newTestSocketPath(t)
store, err := sqlite.New(context.Background(), dbPath)
if err != nil {

12
internal/rpc/status_test.go
View File

@@ -13,7 +13,7 @@ import (
func TestStatusEndpoint(t *testing.T) {
tmpDir := t.TempDir()
dbPath := filepath.Join(tmpDir, "test.db")
socketPath := filepath.Join(tmpDir, "test.sock")
socketPath := newTestSocketPath(t)
store, err := sqlite.New(context.Background(), dbPath)
if err != nil {
@@ -87,8 +87,7 @@ func TestStatusEndpoint(t *testing.T) {
func TestStatusEndpointWithConfig(t *testing.T) {
tmpDir := t.TempDir()
dbPath := filepath.Join(tmpDir, "test.db")
socketPath := filepath.Join(tmpDir, "test.sock")
socketPath := newTestSocketPath(t)
store, err := sqlite.New(context.Background(), dbPath)
if err != nil {
t.Fatalf("failed to create storage: %v", err)
@@ -146,8 +145,7 @@ func TestStatusEndpointWithConfig(t *testing.T) {
func TestStatusEndpointLocalMode(t *testing.T) {
tmpDir := t.TempDir()
dbPath := filepath.Join(tmpDir, "test.db")
socketPath := filepath.Join(tmpDir, "test.sock")
socketPath := newTestSocketPath(t)
store, err := sqlite.New(context.Background(), dbPath)
if err != nil {
t.Fatalf("failed to create storage: %v", err)
@@ -205,7 +203,7 @@ func TestStatusEndpointLocalMode(t *testing.T) {
func TestStatusEndpointDefaultConfig(t *testing.T) {
tmpDir := t.TempDir()
dbPath := filepath.Join(tmpDir, "test.db")
socketPath := filepath.Join(tmpDir, "test.sock")
socketPath := newTestSocketPath(t)
store, err := sqlite.New(context.Background(), dbPath)
if err != nil {
@@ -262,7 +260,7 @@ func TestStatusEndpointDefaultConfig(t *testing.T) {
func TestSetConfigConcurrency(t *testing.T) {
tmpDir := t.TempDir()
dbPath := filepath.Join(tmpDir, "test.db")
socketPath := filepath.Join(tmpDir, "test.sock")
socketPath := newTestSocketPath(t)
store, err := sqlite.New(context.Background(), dbPath)
if err != nil {

21
internal/rpc/test_helpers.go
View File

@@ -2,6 +2,9 @@ package rpc
import (
"context"
"os"
"path/filepath"
"runtime"
"testing"
"github.com/steveyegge/beads/internal/storage/sqlite"
@@ -23,6 +26,22 @@ func newTestStore(t *testing.T, dbPath string) *sqlite.SQLiteStorage {
_ = store.Close()
t.Fatalf("Failed to set issue_prefix: %v", err)
}
return store
}
func newTestSocketPath(t *testing.T) string {
t.Helper()
// On unix, AF_UNIX socket paths have small length limits (notably on darwin).
// Prefer a short base dir when available.
if runtime.GOOS != "windows" {
d, err := os.MkdirTemp("/tmp", "beads-sock-")
if err == nil {
t.Cleanup(func() { _ = os.RemoveAll(d) })
return filepath.Join(d, "rpc.sock")
}
}
return filepath.Join(t.TempDir(), "rpc.sock")
}