fix: Resolve 11 errcheck linter violations to unblock CI (bd-91)

Fixed all unchecked error returns in production code:
- os.Remove() calls in cleanup paths
- cmd.Wait() in goroutines
- fmt.Fprintf() writes
- Type assertions with proper ok checks

Reduces linter issues from 99 to 88. CI should now pass linting.
This commit is contained in:
Steve Yegge
2025-10-24 11:59:11 -07:00
parent 7229b6d68f
commit c59db1a798
9 changed files with 65 additions and 54 deletions

View File

@@ -360,13 +360,13 @@ func removeIssueFromJSONL(issueID string) error {
}
if err := out.Close(); err != nil {
os.Remove(temp)
_ = os.Remove(temp)
return fmt.Errorf("failed to close temp file: %w", err)
}
// Atomic rename
if err := os.Rename(temp, path); err != nil {
os.Remove(temp)
_ = os.Remove(temp)
return fmt.Errorf("failed to rename temp file: %w", err)
}