fix: Resolve 11 errcheck linter violations to unblock CI (bd-91)

Fixed all unchecked error returns in production code:
- os.Remove() calls in cleanup paths
- cmd.Wait() in goroutines
- fmt.Fprintf() writes
- Type assertions with proper ok checks

Reduces linter issues from 99 to 88. CI should now pass linting.
This commit is contained in:
Steve Yegge
2025-10-24 11:59:11 -07:00
parent 7229b6d68f
commit c59db1a798
9 changed files with 65 additions and 54 deletions

View File

@@ -146,10 +146,10 @@ Output to stdout by default, or use -o flag for file output.`,
// Ensure cleanup on failure
defer func() {
if tempFile != nil {
tempFile.Close()
os.Remove(tempPath) // Clean up temp file if we haven't renamed it
}
if tempFile != nil {
_ = tempFile.Close()
_ = os.Remove(tempPath) // Clean up temp file if we haven't renamed it
}
}()
out = tempFile
@@ -189,9 +189,9 @@ Output to stdout by default, or use -o flag for file output.`,
// Atomically replace the target file
if err := os.Rename(tempPath, finalPath); err != nil {
os.Remove(tempPath) // Clean up on failure
fmt.Fprintf(os.Stderr, "Error replacing output file: %v\n", err)
os.Exit(1)
_ = os.Remove(tempPath) // Clean up on failure
fmt.Fprintf(os.Stderr, "Error replacing output file: %v\n", err)
os.Exit(1)
}
// Set appropriate file permissions (0644: rw-r--r--)