fix(npm): Windows postinstall file locking issue (GH#670)

- Move write stream creation after redirect handling to avoid orphan
  streams that keep file handles open
- Add 100ms delay after file.close() on Windows to ensure handle release
- Fixes "The process cannot access the file" error during extraction

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-25 19:47:01 -08:00
parent bbe1980b6c
commit c64ad028b7
2 changed files with 29 additions and 10 deletions

View File

@@ -50,14 +50,18 @@ function getPlatformInfo() {
return { platformName, archName, binaryName };
}
// Small delay helper for Windows file handle release
function delay(ms) {
return new Promise(resolve => setTimeout(resolve, ms));
}
// Download file from URL
function downloadFile(url, dest) {
return new Promise((resolve, reject) => {
console.log(`Downloading from: ${url}`);
const file = fs.createWriteStream(dest);
const request = https.get(url, (response) => {
// Handle redirects
// Handle redirects - must happen BEFORE creating write stream
if (response.statusCode === 301 || response.statusCode === 302) {
const redirectUrl = response.headers.location;
console.log(`Following redirect to: ${redirectUrl}`);
@@ -70,27 +74,37 @@ function downloadFile(url, dest) {
return;
}
// Only create write stream after we know we have the final URL
const file = fs.createWriteStream(dest);
response.pipe(file);
file.on('finish', () => {
// Wait for file.close() to complete before resolving
// This is critical on Windows where the file may still be locked
file.close((err) => {
if (err) reject(err);
else resolve();
file.close(async (err) => {
if (err) {
reject(err);
return;
}
// On Windows, add a small delay to ensure file handle is fully released
if (os.platform() === 'win32') {
await delay(100);
}
resolve();
});
});
file.on('error', (err) => {
fs.unlink(dest, () => {});
reject(err);
});
});
request.on('error', (err) => {
fs.unlink(dest, () => {});
reject(err);
});
file.on('error', (err) => {
fs.unlink(dest, () => {});
reject(err);
});
});
}