From c64c129bbf14e6d2313a6d36ffdb2319b5d3537e Mon Sep 17 00:00:00 2001 From: Steve Yegge Date: Tue, 30 Dec 2025 17:14:29 -0800 Subject: [PATCH] bd sync: 2025-12-30 17:14:29 --- .beads/issues.jsonl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.beads/issues.jsonl b/.beads/issues.jsonl index 557b253f..b459a724 100644 --- a/.beads/issues.jsonl +++ b/.beads/issues.jsonl @@ -146,6 +146,7 @@ {"id":"bd-6s61","title":"Version Bump: {{version}}","description":"Release checklist for version {{version}}. This molecule ensures all release steps are completed properly.","status":"tombstone","priority":1,"issue_type":"epic","created_at":"2025-12-19T22:55:42.487701-08:00","updated_at":"2025-12-25T13:27:50.789625-08:00","labels":["molecule","template"],"deleted_at":"2025-12-24T16:25:31.251346-08:00","deleted_by":"daemon","delete_reason":"delete","original_type":"epic"} {"id":"bd-6sm6","title":"Improve test coverage for internal/export (37.1% → 60%)","description":"The export package has only 37.1% test coverage. Export functionality needs good coverage to ensure data integrity.\n\nCurrent coverage: 37.1%\nTarget coverage: 60%","status":"closed","priority":2,"issue_type":"task","created_at":"2025-12-13T20:43:06.802277-08:00","updated_at":"2025-12-23T22:32:29.16846-08:00","closed_at":"2025-12-23T22:32:29.16846-08:00"} {"id":"bd-6ss","title":"Improve test coverage","description":"The test suite reports less than 45% code coverage. Identify the specific uncovered areas of the codebase, including modules, functions, or features. Rank them by potential impact on system reliability and business value, from most to least, and provide actionable recommendations for improving coverage in each area.","status":"closed","priority":2,"issue_type":"task","created_at":"2025-12-18T06:54:23.036822442-07:00","updated_at":"2025-12-18T07:17:49.245940799-07:00","closed_at":"2025-12-18T07:17:49.245940799-07:00"} +{"id":"bd-6vnu","title":"Merge: opal-1767142018955","description":"branch: polecat/opal-1767142018955\ntarget: main\nsource_issue: opal-1767142018955\nrig: beads","status":"open","priority":2,"issue_type":"merge-request","created_at":"2025-12-30T17:14:02.067823-08:00","created_by":"beads/polecats/opal","updated_at":"2025-12-30T17:14:02.067823-08:00"} {"id":"bd-6x6g","title":"Add multi-repo target repo switching in bd create","description":"In cmd/bd/create.go:164, there's a TODO to switch to the target repo for multi-repo support when creating issues. Currently the code may not properly handle creating issues in a different repo than the current one.\n\nFile: cmd/bd/create.go:164","status":"hooked","priority":3,"issue_type":"feature","created_at":"2025-12-28T16:32:37.130679-08:00","created_by":"stevey","updated_at":"2025-12-30T15:44:43.361095-08:00"} {"id":"bd-70an","title":"test pin","status":"closed","priority":2,"issue_type":"task","created_at":"2025-12-21T11:19:16.760214-08:00","updated_at":"2025-12-21T11:19:46.500688-08:00","closed_at":"2025-12-21T11:19:46.500688-08:00"} {"id":"bd-70c4","title":"Gate await fields cleared by --no-daemon CLI access (not multi-repo)","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-12-25T23:30:38.648182-08:00","updated_at":"2025-12-26T23:38:47.972075-08:00","closed_at":"2025-12-26T23:38:47.972075-08:00","comments":[{"id":3,"issue_id":"bd-70c4","author":"mayor","text":"## Summary\nGate await fields (await_type, await_id, timeout_ns, waiters) are cleared when a CLI command accesses the database directly (--no-daemon) while the daemon is running. This is separate from the multi-repo issue fixed in bd-gr4q.\n\n## Reproduction\n1. Start daemon: bd daemon --start\n2. Create gate: bd gate create --await timer:5s (fields stored correctly)\n3. Verify: sqlite3 .beads/beads.db shows timer|5s\n4. Run CLI with --no-daemon: bd show \u003cid\u003e --no-daemon --no-auto-import --no-auto-flush\n5. Check again: fields are now empty\n\n## Investigation Notes\n- NOT caused by autoImportIfNewer (verified with --no-auto-import flag)\n- NOT caused by HydrateFromMultiRepo (no multi-repo config, returns early)\n- NOT caused by molecule loader (only creates new issues)\n- NOT caused by migrations (gate_columns only adds columns)\n- No database triggers found\n\nThe clearing happens somewhere in sqlite.NewWithTimeout() initialization or command execution path.\n\n## Related\n- bd-gr4q fixed the multi-repo path but this is a different code path\n- The fix pattern (COALESCE/NULLIF) may need to be applied elsewhere","created_at":"2025-12-26T07:30:49Z"}]} @@ -496,7 +497,7 @@ {"id":"bd-likt","title":"Add daemon RPC support for gate commands","description":"Add daemon RPC support for gate commands.\n\n## Current State\nGate commands require --no-daemon flag because they use direct SQLite access:\n- Gate create needs to write await_type, await_id, timeout_ns, waiters fields\n- Gate wait needs to update waiters JSON array\n- Daemon RPC doesnt have methods for these operations\n\n## Implementation\n\n### 1. Add RPC methods to internal/rpc/protocol.go\n\n```go\n// Gate operations\ntype GateCreateArgs struct {\n Title string \\`json:\"title\"\\`\n AwaitType string \\`json:\"await_type\"\\`\n AwaitID string \\`json:\"await_id\"\\`\n Timeout time.Duration \\`json:\"timeout\"\\`\n Waiters []string \\`json:\"waiters\"\\`\n}\n\ntype GateCreateResult struct {\n Issue *types.Issue \\`json:\"issue\"\\`\n}\n\ntype GateListArgs struct {\n All bool \\`json:\"all\"\\` // Include closed gates\n}\n\ntype GateListResult struct {\n Gates []*types.Issue \\`json:\"gates\"\\`\n}\n\ntype GateWaitArgs struct {\n GateID string \\`json:\"gate_id\"\\`\n Waiters []string \\`json:\"waiters\"\\` // Additional waiters to add\n}\n\ntype GateWaitResult struct {\n Gate *types.Issue \\`json:\"gate\"\\`\n AddedCount int \\`json:\"added_count\"\\`\n}\n```\n\n### 2. Add handler methods to internal/daemon/rpc_handler.go\n\n```go\nfunc (h *RPCHandler) GateCreate(ctx context.Context, args *rpc.GateCreateArgs) (*rpc.GateCreateResult, error) {\n now := time.Now()\n gate := \u0026types.Issue{\n Title: args.Title,\n IssueType: types.TypeGate,\n Status: types.StatusOpen,\n Priority: 1,\n Assignee: \"deacon/\",\n Wisp: true,\n AwaitType: args.AwaitType,\n AwaitID: args.AwaitID,\n Timeout: args.Timeout,\n Waiters: args.Waiters,\n CreatedAt: now,\n UpdatedAt: now,\n }\n gate.ContentHash = gate.ComputeContentHash()\n \n if err := h.store.CreateIssue(ctx, gate, h.actor); err != nil {\n return nil, err\n }\n \n return \u0026rpc.GateCreateResult{Issue: gate}, nil\n}\n\nfunc (h *RPCHandler) GateList(ctx context.Context, args *rpc.GateListArgs) (*rpc.GateListResult, error) {\n gateType := types.TypeGate\n filter := types.IssueFilter{IssueType: \u0026gateType}\n if !args.All {\n openStatus := types.StatusOpen\n filter.Status = \u0026openStatus\n }\n \n gates, err := h.store.SearchIssues(ctx, \"\", filter)\n if err != nil {\n return nil, err\n }\n \n return \u0026rpc.GateListResult{Gates: gates}, nil\n}\n\nfunc (h *RPCHandler) GateWait(ctx context.Context, args *rpc.GateWaitArgs) (*rpc.GateWaitResult, error) {\n gate, err := h.store.GetIssue(ctx, args.GateID)\n if err != nil {\n return nil, err\n }\n if gate.IssueType != types.TypeGate {\n return nil, fmt.Errorf(\"%s is not a gate\", args.GateID)\n }\n \n // Merge waiters (dedupe)\n waiterSet := make(map[string]bool)\n for _, w := range gate.Waiters {\n waiterSet[w] = true\n }\n added := 0\n for _, w := range args.Waiters {\n if !waiterSet[w] {\n gate.Waiters = append(gate.Waiters, w)\n waiterSet[w] = true\n added++\n }\n }\n \n if added \u003e 0 {\n // Update via store\n updates := map[string]interface{}{\n \"waiters\": gate.Waiters,\n }\n if err := h.store.UpdateIssue(ctx, args.GateID, updates, h.actor); err != nil {\n return nil, err\n }\n }\n \n return \u0026rpc.GateWaitResult{Gate: gate, AddedCount: added}, nil\n}\n```\n\n### 3. Register methods in daemon\n\nIn internal/daemon/server.go, register the new methods:\n```go\nrpc.RegisterMethod(\"gate.create\", h.GateCreate)\nrpc.RegisterMethod(\"gate.list\", h.GateList)\nrpc.RegisterMethod(\"gate.wait\", h.GateWait)\n```\n\n### 4. Add client methods to internal/rpc/client.go\n\n```go\nfunc (c *Client) GateCreate(ctx context.Context, args *GateCreateArgs) (*GateCreateResult, error) {\n var result GateCreateResult\n err := c.Call(ctx, \"gate.create\", args, \u0026result)\n return \u0026result, err\n}\n\nfunc (c *Client) GateList(ctx context.Context, args *GateListArgs) (*GateListResult, error) {\n var result GateListResult\n err := c.Call(ctx, \"gate.list\", args, \u0026result)\n return \u0026result, err\n}\n\nfunc (c *Client) GateWait(ctx context.Context, args *GateWaitArgs) (*GateWaitResult, error) {\n var result GateWaitResult\n err := c.Call(ctx, \"gate.wait\", args, \u0026result)\n return \u0026result, err\n}\n```\n\n### 5. Update cmd/bd/gate.go to use daemon\n\n```go\n// In gateCreateCmd Run:\nif daemonClient != nil {\n result, err := daemonClient.GateCreate(ctx, \u0026rpc.GateCreateArgs{\n Title: title,\n AwaitType: awaitType,\n AwaitID: awaitID,\n Timeout: timeout,\n Waiters: notifyAddrs,\n })\n if err != nil {\n FatalError(\"gate create: %v\", err)\n }\n gate = result.Issue\n} else {\n // Existing direct store code\n}\n```\n\n## Files to Modify\n\n1. **internal/rpc/protocol.go** - Add Gate*Args/Result types\n2. **internal/daemon/rpc_handler.go** - Add handler methods\n3. **internal/daemon/server.go** - Register methods\n4. **internal/rpc/client.go** - Add client methods\n5. **cmd/bd/gate.go** - Use daemon client when available\n\n## Testing\n\n```bash\n# Start daemon\nbd daemon start\n\n# Test via daemon (should work without --no-daemon)\nbd gate create --await timer:5m --notify beads/dave\nbd gate list\nbd gate wait \u003cid\u003e --notify beads/alice\n\n# Verify daemon handled it\nbd daemons logs . | grep gate\n```\n\n## Success Criteria\n- All gate commands work without --no-daemon\n- Same behavior in daemon vs direct mode\n- Waiters array updates correctly via RPC\n- Tests pass for RPC gate operations","status":"closed","priority":3,"issue_type":"task","created_at":"2025-12-23T12:13:25.778412-08:00","updated_at":"2025-12-23T13:45:58.398604-08:00","closed_at":"2025-12-23T13:45:58.398604-08:00","dependencies":[{"issue_id":"bd-likt","depends_on_id":"bd-udsi","type":"discovered-from","created_at":"2025-12-23T12:13:36.174822-08:00","created_by":"daemon"},{"issue_id":"bd-likt","depends_on_id":"bd-iz5t","type":"parent-child","created_at":"2025-12-23T12:44:07.891992-08:00","created_by":"daemon"}]} {"id":"bd-lk39","title":"Add composite index (issue_id, event_type) on events table","description":"GetCloseReason and GetCloseReasonsForIssues filter by both issue_id and event_type.\n\n**Query (queries.go:355-358):**\n```sql\nSELECT comment FROM events\nWHERE issue_id = ? AND event_type = ?\nORDER BY created_at DESC LIMIT 1\n```\n\n**Problem:** Currently uses idx_events_issue but must filter event_type in memory.\n\n**Solution:** Add migration:\n```sql\nCREATE INDEX IF NOT EXISTS idx_events_issue_type ON events(issue_id, event_type);\n```\n\n**Priority:** Low - events table is typically small relative to issues.","status":"closed","priority":4,"issue_type":"task","created_at":"2025-12-22T22:58:54.070587-08:00","updated_at":"2025-12-22T23:15:13.841988-08:00","closed_at":"2025-12-22T23:15:13.841988-08:00","dependencies":[{"issue_id":"bd-lk39","depends_on_id":"bd-h0we","type":"discovered-from","created_at":"2025-12-22T22:58:54.071286-08:00","created_by":"daemon"}]} {"id":"bd-ll2n","title":"Move relate/unrelate under dep command","description":"Make relate and unrelate subcommands of dep (dep relate, dep unrelate). They're dependency operations and belong there.","status":"closed","priority":2,"issue_type":"task","created_at":"2025-12-28T12:59:10.379321-08:00","created_by":"stevey","updated_at":"2025-12-28T13:04:02.520266-08:00","closed_at":"2025-12-28T13:04:02.520266-08:00"} -{"id":"bd-llfl","title":"Improve test coverage for cmd/bd CLI (26.2% → 50%)","description":"The main CLI package (cmd/bd) has only 26.2% test coverage. CLI commands should have at least 50% coverage to ensure reliability.\n\nKey areas with low/no coverage:\n- daemon_autostart.go (multiple 0% functions)\n- compact.go (several 0% functions)\n- Various command handlers\n\nCurrent coverage: 26.2%\nTarget coverage: 50%","notes":"## Progress Update (2025-12-23)\n\n### Tests Added\nAdded 683 lines of new tests across 3 files:\n- cmd/bd/daemon_config_test.go (144 lines)\n- cmd/bd/utils_test.go (484 lines) \n- cmd/bd/autostart_test.go (55 additional lines)\n\n### Functions Now Tested\n- daemon_config.go: ensureBeadsDir, getPIDFilePath, getLogFilePath, getSocketPathForPID\n- daemon_autostart.go: determineSocketPath, isDaemonRunningQuiet\n- activity.go: printEvent\n- cleanup.go: showCleanupDeprecationHint\n- upgrade.go: pluralize\n- wisp.go: formatTimeAgo\n- list.go: pinIndicator, sortIssues\n- hooks.go: FormatHookWarnings, isRebaseInProgress, hasBeadsJSONL\n- template.go: extractIDSuffix\n- thanks.go: getContributorsSorted\n\n### Coverage Results\n- Before: 22.5%\n- After: 23.1%\n- Delta: +0.6%\n\n### Remaining Work\nMost remaining untested code (77%) involves:\n1. Daemon/RPC operations (runDaemonLoop, tryAutoStartDaemon, etc.)\n2. Command handlers that require database/daemon setup\n3. Git operations (runPreCommitHook, runPostMergeHook, etc.)\n\nTo reach 50%, would need to:\n- Add integration tests with mocked daemon\n- Add scripttest tests for command handlers\n- Add more database-dependent tests\n\nCommit: 4f949c19","status":"hooked","priority":2,"issue_type":"task","assignee":"beads/polecats/opal","created_at":"2025-12-13T20:43:03.123341-08:00","updated_at":"2025-12-30T16:47:00.427047-08:00"} +{"id":"bd-llfl","title":"Improve test coverage for cmd/bd CLI (26.2% → 50%)","description":"The main CLI package (cmd/bd) has only 26.2% test coverage. CLI commands should have at least 50% coverage to ensure reliability.\n\nKey areas with low/no coverage:\n- daemon_autostart.go (multiple 0% functions)\n- compact.go (several 0% functions)\n- Various command handlers\n\nCurrent coverage: 26.2%\nTarget coverage: 50%","notes":"## Progress Update (2025-12-30 - Session 2)\n\n### Tests Added\nAdded 479 lines of new tests across 4 files:\n- cmd/bd/utils_unit_test.go (214 lines) - NEW\n - TestTruncateString, TestPluralize, TestFormatTimeAgo\n - TestContainsLabel, TestGetContributorsSorted, TestExtractIDSuffix \n - TestTruncate, TestTruncateDescription\n - TestShowCleanupDeprecationHint, TestClearAutoFlushState\n\n- cmd/bd/hooks_test.go (117 lines added)\n - TestFormatHookWarnings, TestIsRebaseInProgress, TestHasBeadsJSONL\n\n- cmd/bd/list_test.go (140 lines added)\n - TestFormatIssueLong, TestFormatIssueCompact\n\n- cmd/bd/version_tracking_test.go (8 lines)\n - Fixed flaky tests by setting BEADS_DIR env var\n\n### Coverage Results\n- Before: 21.6%\n- After: 22.0%\n- Delta: +0.4%\n\n### Remaining Work\nCoverage is still at 22% vs target 50%. The remaining 78% involves:\n1. Daemon/RPC operations (runDaemonLoop, tryAutoStartDaemon, etc.)\n2. Command handlers requiring database/daemon setup\n3. Git operations (runPreCommitHook, runPostMergeHook, etc.)\n\nTo reach 50%, would need:\n- Integration tests with mocked daemon (use -tags=integration)\n- scripttest tests for command handlers\n- More database-dependent tests\n\nCommit: 8c7d94d3","status":"hooked","priority":2,"issue_type":"task","assignee":"beads/polecats/opal","created_at":"2025-12-13T20:43:03.123341-08:00","updated_at":"2025-12-30T17:13:19.888243-08:00"} {"id":"bd-lo4","title":"Test pinned issue","status":"tombstone","priority":2,"issue_type":"task","created_at":"2025-12-18T21:44:49.031385-08:00","updated_at":"2025-12-18T21:47:25.055109-08:00","deleted_at":"2025-12-18T21:47:25.055109-08:00","deleted_by":"daemon","delete_reason":"delete","original_type":"task"} {"id":"bd-lrj8","title":"Technical debt: Scattered TODOs should be tracked as issues","description":"Multiple TODO comments exist in the codebase that should be tracked as proper issues:\n\n1. cmd/bd/migrate_hash_ids.go:24 - 'Consider integrating into bd doctor migration detection'\n2. cmd/bd/migrate_tombstones.go:72 - Same\n3. cmd/bd/migrate_sync.go:16 - Same\n4. cmd/bd/migrate_issues.go:15 - Same\n5. cmd/bd/create.go:164 - 'Switch to target repo for multi-repo support'\n6. cmd/bd/create.go:208 - 'Add RPC method to get config in daemon mode'\n7. cmd/bd/daemon_logger.go:131 - 'Remove this once all callers are updated'\n8. cmd/bd/mol_stale.go:67 - 'Add RPC endpoint for stale check'\n9. cmd/bd/sync_test.go:444 - 'Refactor to use direct import logic'\n10. cmd/bd/jira.go:633 - 'In a full implementation, fetch Jira issue and compare timestamps'\n11. internal/formula/types.go:170,174,179,186,210 - Multiple 'Not yet implemented' TODOs\n12. internal/importer/importer_test.go:1010 - 'Test hangs due to database deadlock'\n\nConsider:\n1. Running 'grep -r TODO' periodically to find new ones\n2. Adding a lint rule to discourage inline TODOs\n3. Converting each to a bd issue with proper tracking\n\nLocation: Various files across codebase","status":"closed","priority":4,"issue_type":"chore","created_at":"2025-12-28T15:32:57.125279-08:00","created_by":"beads/crew/dave","updated_at":"2025-12-28T16:34:10.911155-08:00","closed_at":"2025-12-28T16:34:10.911155-08:00","dependencies":[{"issue_id":"bd-lrj8","depends_on_id":"bd-784c","type":"parent-child","created_at":"2025-12-28T15:38:04.33312-08:00","created_by":"daemon"}]} {"id":"bd-lsv4","title":"GH#444: Fix inconsistent status naming in_progress vs in-progress","description":"Documentation uses in-progress (hyphen) but code expects in_progress (underscore). Update all docs to use canonical in_progress. See GitHub issue #444.","status":"tombstone","priority":2,"issue_type":"bug","created_at":"2025-12-16T01:03:14.349425-08:00","updated_at":"2025-12-17T16:11:17.070763-08:00","deleted_at":"2025-12-17T16:11:17.070763-08:00","deleted_by":"batch delete","delete_reason":"batch delete","original_type":"bug"}