johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(validation): support hyphenated rig names in agent IDs (GH#854)

Browse Source 
Rewrites ValidateAgentID to scan right-to-left for known role tokens
instead of relying on fixed position parsing. This allows rig names
containing hyphens (e.g., ob-my-project-witness).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
wolf
2026-01-03 12:43:58 -08:00
committed by Steve Yegge
parent 079b346b5d
commit c6fe9d71ca
2 changed files with 51 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/validation/bead_test.go
View File

@@ -220,6 +220,14 @@ func TestValidateAgentID(t *testing.T) {
{"valid bd-beads-polecat-pearl", "bd-beads-polecat-pearl", false, ""},
{"valid bd-beads-witness", "bd-beads-witness", false, ""},
// Valid: hyphenated rig names (GH#854)
{"hyphenated rig witness", "ob-my-project-witness", false, ""},
{"hyphenated rig refinery", "gt-foo-bar-refinery", false, ""},
{"hyphenated rig crew", "bd-my-cool-project-crew-fang", false, ""},
{"hyphenated rig polecat", "gt-some-long-rig-name-polecat-nux", false, ""},
{"hyphenated rig and name", "gt-my-rig-polecat-war-boy", false, ""},
{"multi-hyphen rig crew", "ob-a-b-c-d-crew-dave", false, ""},
// Invalid: no prefix (missing hyphen)
{"no prefix", "mayor", true, "must have a prefix followed by '-'"},
@@ -230,8 +238,8 @@ func TestValidateAgentID(t *testing.T) {
{"unknown role", "gt-gastown-admin", true, "invalid agent format"},
// Invalid: town-level with rig (put role first)
{"mayor with rig suffix", "gt-gastown-mayor", true, "cannot have rig suffix"},
{"deacon with rig suffix", "gt-beads-deacon", true, "cannot have rig suffix"},
{"mayor with rig suffix", "gt-gastown-mayor", true, "cannot have rig/name suffixes"},
{"deacon with rig suffix", "gt-beads-deacon", true, "cannot have rig/name suffixes"},
// Invalid: per-rig role without rig
{"witness alone", "gt-witness", true, "requires rig"},