johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(types): use strings.Contains in federation tests

Browse Source 
Replace custom containsString/findSubstring helpers with stdlib.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
wickham
2026-01-21 10:40:39 -08:00
committed by Steve Yegge
parent 7cf67153de
commit cb46db603d
1 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
internal/types/federation_test.go
View File

@@ -1,6 +1,7 @@
package types package types
import ( import (
"strings"
"testing" "testing"
"time" "time"
) )
@@ -294,7 +295,7 @@ func TestFederatedMessageValidation(t *testing.T) {
if tt.wantErr { if tt.wantErr {
if err == nil { if err == nil {
t.Errorf("FederatedMessage.Validate() expected error containing %q, got nil", tt.errMsg) t.Errorf("FederatedMessage.Validate() expected error containing %q, got nil", tt.errMsg)
} else if tt.errMsg != "" && !containsString(err.Error(), tt.errMsg) { } else if tt.errMsg != "" && !strings.Contains(err.Error(), tt.errMsg) {
t.Errorf("FederatedMessage.Validate() error = %q, want error containing %q", err.Error(), tt.errMsg) t.Errorf("FederatedMessage.Validate() error = %q, want error containing %q", err.Error(), tt.errMsg)
} }
} else { } else {
@@ -350,17 +351,3 @@ func TestRejectCodeString(t *testing.T) {
} }
} }
// containsString checks if s contains substr
func containsString(s, substr string) bool {
return len(s) >= len(substr) && (s == substr || len(substr) == 0 ||
(len(s) > 0 && len(substr) > 0 && findSubstring(s, substr)))
}
func findSubstring(s, substr string) bool {
for i := 0; i <= len(s)-len(substr); i++ {
if s[i:i+len(substr)] == substr {
return true
}
}
return false
}