johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: replace string(rune()) with strconv.Itoa in tests (bd-fmc)

Browse Source 
Also updated CONFIG.md to clarify mass delete threshold requires >5 issues (bd-in6).

The string(rune('0'+i)) pattern produces incorrect characters when i >= 10.
Changed to strconv.Itoa(i) for reliable conversion.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Steve Yegge
2025-12-02 22:41:07 -08:00
parent a067796055
commit cd7830a5a6
7 changed files with 22 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cmd/bd/export_integrity_integration_test.go
View File

@@ -6,6 +6,7 @@ import (
"encoding/hex"
"os"
"path/filepath"
"strconv"
"testing"
"github.com/steveyegge/beads/internal/storage/sqlite"
@@ -42,9 +43,9 @@ func TestExportIntegrityAfterJSONLTruncation(t *testing.T) {
var allIssues []*types.Issue
for i := 1; i <= numIssues; i++ {
issue := &types.Issue{
ID: "bd-" + string(rune('0'+i)),
Title: "Test issue " + string(rune('0'+i)),
Description: "Description " + string(rune('0'+i)),
ID: "bd-" + strconv.Itoa(i),
Title: "Test issue " + strconv.Itoa(i),
Description: "Description " + strconv.Itoa(i),
Status: types.StatusOpen,
Priority: 1,
IssueType: types.TypeTask,
@@ -276,8 +277,8 @@ func TestMultipleExportsStayConsistent(t *testing.T) {
var issues []*types.Issue
for i := 1; i <= 5; i++ {
issue := &types.Issue{
ID: "bd-" + string(rune('0'+i)),
Title: "Issue " + string(rune('0'+i)),
ID: "bd-" + strconv.Itoa(i),
Title: "Issue " + strconv.Itoa(i),
Status: types.StatusOpen,
Priority: 1,
IssueType: types.TypeTask,

5
cmd/bd/stale_test.go
View File

@@ -3,6 +3,7 @@ package main
import (
"context"
"path/filepath"
"strconv"
"testing"
"time"
@@ -215,7 +216,7 @@ func TestStaleIssuesWithLimit(t *testing.T) {
for i := 1; i <= 5; i++ {
updatedAt := oldTime.Add(time.Duration(i) * time.Hour) // Slightly different times for sorting
issue := &types.Issue{
ID: "test-stale-limit-" + string(rune('0'+i)),
ID: "test-stale-limit-" + strconv.Itoa(i),
Title: "Stale issue",
Status: types.StatusOpen,
Priority: 1,
@@ -231,7 +232,7 @@ func TestStaleIssuesWithLimit(t *testing.T) {
// Update timestamps directly in DB using datetime() function
db := s.UnderlyingDB()
for i := 1; i <= 5; i++ {
id := "test-stale-limit-" + string(rune('0'+i))
id := "test-stale-limit-" + strconv.Itoa(i)
// Make each slightly different (40 days ago + i hours)
_, err := db.ExecContext(ctx, "UPDATE issues SET updated_at = datetime('now', '-40 days', '+' || ? || ' hours') WHERE id = ?", i, id)
if err != nil {