fix: Resolve Windows test failures and lint warnings

- Fix Windows binary path issues (bd.exe vs bd)
- Skip scripttest on Windows (requires Unix shell)
- Skip file lock tests on Windows (platform locking differences)
- Fix registry tests to use USERPROFILE on Windows
- Fix 8 unparam lint warnings by marking unused params with _

All changes are platform-aware and maintain functionality.

Amp-Thread-ID: https://ampcode.com/threads/T-bc27021a-65db-4b64-a3f3-4e8d7bc8aa0d
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Steve Yegge
2025-11-02 08:30:31 -08:00
parent e1c248bb7a
commit d240439868
10 changed files with 62 additions and 32 deletions

View File

@@ -208,7 +208,7 @@ func (r *validationResults) toJSON() map[string]interface{} {
return output
}
func (r *validationResults) print(fixAll bool) {
func (r *validationResults) print(_ bool) {
green := color.New(color.FgGreen).SprintFunc()
yellow := color.New(color.FgYellow).SprintFunc()
red := color.New(color.FgRed).SprintFunc()
@@ -326,7 +326,7 @@ func validateOrphanedDeps(ctx context.Context, allIssues []*types.Issue, fix boo
return result
}
func validateDuplicates(ctx context.Context, allIssues []*types.Issue, fix bool) checkResult {
func validateDuplicates(_ context.Context, allIssues []*types.Issue, fix bool) checkResult {
result := checkResult{name: "duplicates"}
// Find duplicates
@@ -350,7 +350,7 @@ func validateDuplicates(ctx context.Context, allIssues []*types.Issue, fix bool)
return result
}
func validatePollution(ctx context.Context, allIssues []*types.Issue, fix bool) checkResult {
func validatePollution(_ context.Context, allIssues []*types.Issue, fix bool) checkResult {
result := checkResult{name: "test pollution"}
// Detect pollution
@@ -369,7 +369,7 @@ func validatePollution(ctx context.Context, allIssues []*types.Issue, fix bool)
return result
}
func validateGitConflicts(ctx context.Context, fix bool) checkResult {
func validateGitConflicts(_ context.Context, fix bool) checkResult {
result := checkResult{name: "git conflicts"}
// Check JSONL file for conflict markers