feat(dates): add --due and --defer timestamp options with natural language parsing (#847)
* feat(dates): add due date schema and --due flag - Add due_at and defer_until columns to issues table via migration 035 - Implement --due flag on create command with ISO date parsing - Extend RPC protocol and daemon to pass DueAt from CLI to storage - Display DueAt and DeferUntil in show command output - Update Issue type with new date fields Users can now set due dates when creating issues, enabling deadline-based task management. * feat(dates): add compact duration parser (+6h, +1d, +2w) - Create internal/timeparsing package with layered parser architecture - Implement parseCompactDuration with regex pattern [+-]?\d+[hdwmy] - Add comprehensive test suite (22 cases) for duration parsing - Integrate into create.go with fallback to ISO format Supports hours (h), days (d), weeks (w), months (m), and years (y). Negative values allowed for past dates. * feat(dates): add NLP parsing for natural language dates Integrate olebedev/when library for natural language time expressions. The layered parser now handles: compact duration → absolute formats → NLP. Changes: - Add olebedev/when dependency for NLP parsing - Implement ParseNaturalLanguage and ParseRelativeTime functions - Reorder layers: absolute formats before NLP to avoid misinterpretation - Simplify create.go to use unified ParseRelativeTime - Add comprehensive NLP test coverage (22 test cases) Supports: tomorrow, next monday, in 3 days, 3 days ago * feat(dates): add --defer flag to create/update/defer commands Add time-based deferral support alongside existing status-based defer. Issues can now be hidden from bd ready until a specific time. Changes: - Add --defer flag to bd create (sets defer_until on creation) - Add --due and --defer flags to bd update (modify existing issues) - Add --until flag to bd defer (combines status=deferred with defer_until) - Add DueAt/DeferUntil fields to UpdateArgs in protocol.go Supports: +1h, tomorrow, next monday, 2025-01-15 * feat(dates): add defer_until filtering to ready command Add time-based deferral support to bd ready: - Add --include-deferred flag to show issues with future defer_until - Filter out issues where defer_until > now by default - Update undefer to clear defer_until alongside status change - Add IncludeDeferred to WorkFilter and RPC ReadyArgs Part of GH#820: Relative Date Parsing (Phase 5) * feat(dates): add polish and tests for relative date parsing Add user-facing warnings when defer date is in the past to help catch common mistakes. Expand help text with format examples and document the olebedev/when September parsing quirk. Tests: - TestCreateSuite/WithDueAt, WithDeferUntil, WithBothDueAndDefer - TestReadyWorkDeferUntil (ExcludesFutureDeferredByDefault, IncludeDeferredShowsAll) Docs: - CLAUDE.md quick reference updated with new flags - Help text examples for --due, --defer on create/update Closes: Phase 6 of beads-820-relative-dates spec * feat(list): add time-based query filters for defer/due dates Add --deferred, --defer-before, --defer-after, --due-before, --due-after, and --overdue flags to bd list command. All date filters now support relative time expressions (+6h, tomorrow, next monday) via the timeparsing package. Filters: - --deferred: issues with defer_until set - --defer-before/after: filter by defer_until date range - --due-before/after: filter by due_at date range - --overdue: due_at in past AND status != closed Existing date filters (--created-after, etc.) now also support relative time expressions through updated parseTimeFlag(). * build(nix): update vendorHash for olebedev/when dependency The olebedev/when library was added for natural language date parsing (GH#820). This changes go.sum, requiring an updated vendorHash in the Nix flake configuration.
This commit is contained in:
Peter Chanthamynavong
committed by
GitHub
GitHub
parent
e4042e3e1a
commit
d371baf2ca
@@ -602,16 +602,24 @@ func TestParseTimeFlag(t *testing.T) {
|
||||
input string
|
||||
wantErr bool
|
||||
}{
|
||||
// Absolute formats
|
||||
{"RFC3339", "2023-01-15T10:30:00Z", false},
|
||||
{"Date only", "2023-01-15", false},
|
||||
{"DateTime without zone", "2023-01-15T10:30:00", false},
|
||||
{"DateTime with space", "2023-01-15 10:30:00", false},
|
||||
{"Invalid format", "January 15, 2023", true},
|
||||
// Compact duration formats (GH#820)
|
||||
{"Compact hours", "+6h", false},
|
||||
{"Compact days", "+1d", false},
|
||||
{"Compact weeks", "+2w", false},
|
||||
{"Compact negative", "-3d", false},
|
||||
// Natural language (GH#820)
|
||||
{"Natural tomorrow", "tomorrow", false},
|
||||
{"Natural next monday", "next monday", false},
|
||||
// Invalid formats
|
||||
{"Invalid format", "not-a-date", true},
|
||||
{"Empty string", "", true},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
_, err := parseTimeFlag(tt.input)
|
||||
if (err != nil) != tt.wantErr {
|
||||
t.Errorf("parseTimeFlag(%q) error = %v, wantErr %v", tt.input, err, tt.wantErr)
|
||||
@@ -619,3 +627,177 @@ func TestParseTimeFlag(t *testing.T) {
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// TestListTimeBasedFilters tests the time-based scheduling filters (GH#820)
|
||||
func TestListTimeBasedFilters(t *testing.T) {
|
||||
tmpDir := t.TempDir()
|
||||
testDB := filepath.Join(tmpDir, ".beads", "beads.db")
|
||||
s := newTestStore(t, testDB)
|
||||
ctx := context.Background()
|
||||
|
||||
now := time.Now()
|
||||
yesterday := now.Add(-24 * time.Hour)
|
||||
tomorrow := now.Add(24 * time.Hour)
|
||||
nextWeek := now.Add(7 * 24 * time.Hour)
|
||||
|
||||
// Create test issues with varied due_at and defer_until values
|
||||
issueNoSchedule := &types.Issue{
|
||||
Title: "Issue without scheduling",
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
Status: types.StatusOpen,
|
||||
}
|
||||
issueDeferredFuture := &types.Issue{
|
||||
Title: "Deferred until tomorrow",
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
Status: types.StatusOpen,
|
||||
DeferUntil: &tomorrow,
|
||||
}
|
||||
issueDeferredPast := &types.Issue{
|
||||
Title: "Was deferred until yesterday",
|
||||
Priority: 2,
|
||||
IssueType: types.TypeTask,
|
||||
Status: types.StatusOpen,
|
||||
DeferUntil: &yesterday,
|
||||
}
|
||||
issueDueNextWeek := &types.Issue{
|
||||
Title: "Due next week",
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
Status: types.StatusOpen,
|
||||
DueAt: &nextWeek,
|
||||
}
|
||||
issueOverdue := &types.Issue{
|
||||
Title: "Overdue issue",
|
||||
Priority: 0,
|
||||
IssueType: types.TypeBug,
|
||||
Status: types.StatusOpen,
|
||||
DueAt: &yesterday,
|
||||
}
|
||||
issueOverdueClosed := &types.Issue{
|
||||
Title: "Overdue but closed",
|
||||
Priority: 0,
|
||||
IssueType: types.TypeBug,
|
||||
Status: types.StatusClosed,
|
||||
DueAt: &yesterday,
|
||||
ClosedAt: &now,
|
||||
}
|
||||
|
||||
for _, issue := range []*types.Issue{
|
||||
issueNoSchedule, issueDeferredFuture, issueDeferredPast,
|
||||
issueDueNextWeek, issueOverdue, issueOverdueClosed,
|
||||
} {
|
||||
if err := s.CreateIssue(ctx, issue, "test-user"); err != nil {
|
||||
t.Fatalf("Failed to create issue: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
t.Run("filter by deferred flag", func(t *testing.T) {
|
||||
results, err := s.SearchIssues(ctx, "", types.IssueFilter{
|
||||
Deferred: true,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Search failed: %v", err)
|
||||
}
|
||||
// Should find issues with defer_until set (future and past)
|
||||
if len(results) != 2 {
|
||||
t.Errorf("Expected 2 deferred issues, got %d", len(results))
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("filter by defer-after", func(t *testing.T) {
|
||||
results, err := s.SearchIssues(ctx, "", types.IssueFilter{
|
||||
DeferAfter: &now,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Search failed: %v", err)
|
||||
}
|
||||
// Should find issues deferred after now (tomorrow)
|
||||
if len(results) != 1 {
|
||||
t.Errorf("Expected 1 issue deferred after now, got %d", len(results))
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("filter by defer-before", func(t *testing.T) {
|
||||
results, err := s.SearchIssues(ctx, "", types.IssueFilter{
|
||||
DeferBefore: &now,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Search failed: %v", err)
|
||||
}
|
||||
// Should find issues deferred before now (yesterday)
|
||||
if len(results) != 1 {
|
||||
t.Errorf("Expected 1 issue deferred before now, got %d", len(results))
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("filter by due-after", func(t *testing.T) {
|
||||
results, err := s.SearchIssues(ctx, "", types.IssueFilter{
|
||||
DueAfter: &now,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Search failed: %v", err)
|
||||
}
|
||||
// Should find issues due after now (next week)
|
||||
if len(results) != 1 {
|
||||
t.Errorf("Expected 1 issue due after now, got %d", len(results))
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("filter by due-before", func(t *testing.T) {
|
||||
results, err := s.SearchIssues(ctx, "", types.IssueFilter{
|
||||
DueBefore: &now,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Search failed: %v", err)
|
||||
}
|
||||
// Should find issues due before now (overdue open + closed = 2)
|
||||
if len(results) != 2 {
|
||||
t.Errorf("Expected 2 issues due before now, got %d", len(results))
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("filter by overdue", func(t *testing.T) {
|
||||
results, err := s.SearchIssues(ctx, "", types.IssueFilter{
|
||||
Overdue: true,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Search failed: %v", err)
|
||||
}
|
||||
// Should find only the open overdue issue (not the closed one)
|
||||
if len(results) != 1 {
|
||||
t.Errorf("Expected 1 overdue issue, got %d", len(results))
|
||||
}
|
||||
if len(results) > 0 && results[0].ID != issueOverdue.ID {
|
||||
t.Errorf("Expected issue %s, got %s", issueOverdue.ID, results[0].ID)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("combined filters defer and due", func(t *testing.T) {
|
||||
// Issue with both defer_until and due_at
|
||||
bothSet := &types.Issue{
|
||||
Title: "Both deferred and due",
|
||||
Priority: 1,
|
||||
IssueType: types.TypeTask,
|
||||
Status: types.StatusOpen,
|
||||
DeferUntil: &tomorrow,
|
||||
DueAt: &nextWeek,
|
||||
}
|
||||
if err := s.CreateIssue(ctx, bothSet, "test-user"); err != nil {
|
||||
t.Fatalf("Failed to create issue: %v", err)
|
||||
}
|
||||
|
||||
results, err := s.SearchIssues(ctx, "", types.IssueFilter{
|
||||
Deferred: true,
|
||||
DueAfter: &now,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("Search failed: %v", err)
|
||||
}
|
||||
// Should find the issue with both defer_until set and due_at > now
|
||||
if len(results) != 1 {
|
||||
t.Errorf("Expected 1 issue with both filters, got %d", len(results))
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user