fix: DetectCycles SQL bug and add comprehensive tests

- Fix SQL query bug preventing cycle detection (bd-9f20)
  - Allow revisiting start node to complete cycle
  - Remove duplicate start_id concatenation in final SELECT
- Add cycle_detection_test.go with comprehensive test coverage (bd-cdf7)
  - Simple 2-node cycles
  - Complex multi-node cycles (4-node, 10-node)
  - Self-loops
  - Multiple independent cycles
  - Acyclic graphs (diamond, chain)
  - Empty graph and single node edge cases
  - Mixed dependency types

Improves sqlite package coverage: 68.2% → 69.1%
This commit is contained in:
Steve Yegge
2025-11-01 22:51:58 -07:00
parent e9bb1ac121
commit d86f359e63
3 changed files with 515 additions and 8 deletions

File diff suppressed because one or more lines are too long