Remove snapshot/restore functionality from compaction
Snapshots defeated the entire purpose of compaction - if we're keeping the original content, we're not actually saving any space. Compaction is about graceful memory decay for agentic databases, not reversible compression. Removed: - CreateSnapshot/GetSnapshots/RestoreFromSnapshot from storage - --restore flag and functionality from bd compact command - All snapshot-related tests - Snapshot struct and related code The database is ephemeral and meant to decay over time. Compaction actually reduces database size now. Closes bd-260 (won't fix - conceptually wrong) Closes bd-261 (already done in bd-259)
This commit is contained in:
Steve Yegge
@@ -3,7 +3,6 @@ package sqlite
|
||||
import (
|
||||
"context"
|
||||
"database/sql"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
@@ -315,236 +314,6 @@ func TestTier1NoCircularDeps(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateSnapshot(t *testing.T) {
|
||||
store, cleanup := setupTestDB(t)
|
||||
defer cleanup()
|
||||
ctx := context.Background()
|
||||
|
||||
issue := &types.Issue{
|
||||
ID: "bd-1",
|
||||
Title: "Test Issue",
|
||||
Description: "Original description",
|
||||
Design: "Design notes",
|
||||
Notes: "Additional notes",
|
||||
AcceptanceCriteria: "Must work",
|
||||
Status: "closed",
|
||||
Priority: 2,
|
||||
IssueType: "task",
|
||||
ClosedAt: timePtr(time.Now()),
|
||||
}
|
||||
if err := store.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatalf("Failed to create issue: %v", err)
|
||||
}
|
||||
|
||||
err := store.CreateSnapshot(ctx, issue, 1)
|
||||
if err != nil {
|
||||
t.Fatalf("CreateSnapshot failed: %v", err)
|
||||
}
|
||||
|
||||
snapshots, err := store.GetSnapshots(ctx, issue.ID)
|
||||
if err != nil {
|
||||
t.Fatalf("GetSnapshots failed: %v", err)
|
||||
}
|
||||
|
||||
if len(snapshots) != 1 {
|
||||
t.Fatalf("Expected 1 snapshot, got %d", len(snapshots))
|
||||
}
|
||||
|
||||
snapshot := snapshots[0]
|
||||
if snapshot.Description != issue.Description {
|
||||
t.Errorf("Expected description %q, got %q", issue.Description, snapshot.Description)
|
||||
}
|
||||
if snapshot.Design != issue.Design {
|
||||
t.Errorf("Expected design %q, got %q", issue.Design, snapshot.Design)
|
||||
}
|
||||
if snapshot.Notes != issue.Notes {
|
||||
t.Errorf("Expected notes %q, got %q", issue.Notes, snapshot.Notes)
|
||||
}
|
||||
if snapshot.AcceptanceCriteria != issue.AcceptanceCriteria {
|
||||
t.Errorf("Expected criteria %q, got %q", issue.AcceptanceCriteria, snapshot.AcceptanceCriteria)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateSnapshotUTF8(t *testing.T) {
|
||||
store, cleanup := setupTestDB(t)
|
||||
defer cleanup()
|
||||
ctx := context.Background()
|
||||
|
||||
issue := &types.Issue{
|
||||
ID: "bd-1",
|
||||
Title: "UTF-8 Test 🎉",
|
||||
Description: "Café, résumé, 日本語, emoji 🚀",
|
||||
Design: "Design with 中文 and émojis 🔥",
|
||||
Notes: "Notes: ñ, ü, é, à",
|
||||
AcceptanceCriteria: "Must handle UTF-8 correctly ✅",
|
||||
Status: "closed",
|
||||
Priority: 2,
|
||||
IssueType: "task",
|
||||
ClosedAt: timePtr(time.Now()),
|
||||
}
|
||||
if err := store.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatalf("Failed to create issue: %v", err)
|
||||
}
|
||||
|
||||
err := store.CreateSnapshot(ctx, issue, 1)
|
||||
if err != nil {
|
||||
t.Fatalf("CreateSnapshot failed: %v", err)
|
||||
}
|
||||
|
||||
snapshots, err := store.GetSnapshots(ctx, issue.ID)
|
||||
if err != nil {
|
||||
t.Fatalf("GetSnapshots failed: %v", err)
|
||||
}
|
||||
|
||||
if len(snapshots) != 1 {
|
||||
t.Fatalf("Expected 1 snapshot, got %d", len(snapshots))
|
||||
}
|
||||
|
||||
snapshot := snapshots[0]
|
||||
if snapshot.Title != issue.Title {
|
||||
t.Errorf("UTF-8 title not preserved: expected %q, got %q", issue.Title, snapshot.Title)
|
||||
}
|
||||
if snapshot.Description != issue.Description {
|
||||
t.Errorf("UTF-8 description not preserved: expected %q, got %q", issue.Description, snapshot.Description)
|
||||
}
|
||||
if snapshot.Design != issue.Design {
|
||||
t.Errorf("UTF-8 design not preserved: expected %q, got %q", issue.Design, snapshot.Design)
|
||||
}
|
||||
}
|
||||
|
||||
func TestCreateMultipleSnapshots(t *testing.T) {
|
||||
store, cleanup := setupTestDB(t)
|
||||
defer cleanup()
|
||||
ctx := context.Background()
|
||||
|
||||
issue := &types.Issue{
|
||||
ID: "bd-1",
|
||||
Title: "Test Issue",
|
||||
Description: "Original",
|
||||
Status: "closed",
|
||||
Priority: 2,
|
||||
IssueType: "task",
|
||||
ClosedAt: timePtr(time.Now()),
|
||||
}
|
||||
if err := store.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatalf("Failed to create issue: %v", err)
|
||||
}
|
||||
|
||||
if err := store.CreateSnapshot(ctx, issue, 1); err != nil {
|
||||
t.Fatalf("CreateSnapshot level 1 failed: %v", err)
|
||||
}
|
||||
|
||||
issue.Description = "Compacted once"
|
||||
if err := store.CreateSnapshot(ctx, issue, 2); err != nil {
|
||||
t.Fatalf("CreateSnapshot level 2 failed: %v", err)
|
||||
}
|
||||
|
||||
snapshots, err := store.GetSnapshots(ctx, issue.ID)
|
||||
if err != nil {
|
||||
t.Fatalf("GetSnapshots failed: %v", err)
|
||||
}
|
||||
|
||||
if len(snapshots) != 2 {
|
||||
t.Fatalf("Expected 2 snapshots, got %d", len(snapshots))
|
||||
}
|
||||
|
||||
if snapshots[0].CompactionLevel != 1 {
|
||||
t.Errorf("Expected first snapshot level 1, got %d", snapshots[0].CompactionLevel)
|
||||
}
|
||||
if snapshots[1].CompactionLevel != 2 {
|
||||
t.Errorf("Expected second snapshot level 2, got %d", snapshots[1].CompactionLevel)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRestoreFromSnapshot(t *testing.T) {
|
||||
store, cleanup := setupTestDB(t)
|
||||
defer cleanup()
|
||||
ctx := context.Background()
|
||||
|
||||
issue := &types.Issue{
|
||||
ID: "bd-1",
|
||||
Title: "Original Title",
|
||||
Description: "Original description",
|
||||
Design: "Original design",
|
||||
Notes: "Original notes",
|
||||
AcceptanceCriteria: "Original criteria",
|
||||
Status: "closed",
|
||||
Priority: 2,
|
||||
IssueType: "task",
|
||||
ClosedAt: timePtr(time.Now()),
|
||||
}
|
||||
if err := store.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatalf("Failed to create issue: %v", err)
|
||||
}
|
||||
|
||||
if err := store.CreateSnapshot(ctx, issue, 1); err != nil {
|
||||
t.Fatalf("CreateSnapshot failed: %v", err)
|
||||
}
|
||||
|
||||
_, err := store.db.ExecContext(ctx, `
|
||||
UPDATE issues
|
||||
SET description = 'Compacted',
|
||||
design = '',
|
||||
notes = '',
|
||||
acceptance_criteria = '',
|
||||
compaction_level = 1
|
||||
WHERE id = ?
|
||||
`, issue.ID)
|
||||
if err != nil {
|
||||
t.Fatalf("Failed to update issue: %v", err)
|
||||
}
|
||||
|
||||
err = store.RestoreFromSnapshot(ctx, issue.ID, 1)
|
||||
if err != nil {
|
||||
t.Fatalf("RestoreFromSnapshot failed: %v", err)
|
||||
}
|
||||
|
||||
restored, err := store.GetIssue(ctx, issue.ID)
|
||||
if err != nil {
|
||||
t.Fatalf("GetIssue failed: %v", err)
|
||||
}
|
||||
|
||||
if restored.Description != issue.Description {
|
||||
t.Errorf("Description not restored: expected %q, got %q", issue.Description, restored.Description)
|
||||
}
|
||||
if restored.Design != issue.Design {
|
||||
t.Errorf("Design not restored: expected %q, got %q", issue.Design, restored.Design)
|
||||
}
|
||||
if restored.Notes != issue.Notes {
|
||||
t.Errorf("Notes not restored: expected %q, got %q", issue.Notes, restored.Notes)
|
||||
}
|
||||
if restored.AcceptanceCriteria != issue.AcceptanceCriteria {
|
||||
t.Errorf("Criteria not restored: expected %q, got %q", issue.AcceptanceCriteria, restored.AcceptanceCriteria)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRestoreSnapshotNoSnapshot(t *testing.T) {
|
||||
store, cleanup := setupTestDB(t)
|
||||
defer cleanup()
|
||||
ctx := context.Background()
|
||||
|
||||
issue := &types.Issue{
|
||||
ID: "bd-1",
|
||||
Title: "Test",
|
||||
Description: "Test",
|
||||
Status: "closed",
|
||||
Priority: 2,
|
||||
IssueType: "task",
|
||||
ClosedAt: timePtr(time.Now()),
|
||||
}
|
||||
if err := store.CreateIssue(ctx, issue, "test"); err != nil {
|
||||
t.Fatalf("Failed to create issue: %v", err)
|
||||
}
|
||||
|
||||
err := store.RestoreFromSnapshot(ctx, issue.ID, 1)
|
||||
if err == nil {
|
||||
t.Fatal("Expected error when no snapshot exists")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "no snapshot found") {
|
||||
t.Errorf("Expected 'no snapshot found' error, got: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestApplyCompaction(t *testing.T) {
|
||||
store, cleanup := setupTestDB(t)
|
||||
defer cleanup()
|
||||
|
||||
Reference in New Issue
Block a user