johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CI failures: errcheck lint errors and flaky memory pressure test

Browse Source
This commit is contained in:
Steve Yegge
2025-10-24 00:27:07 -07:00
parent 1220304a61
commit e293974c71
6 changed files with 20 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.golangci.yml
View File

@@ -1,3 +1,5 @@
version: 2
run: run:
timeout: 5m timeout: 5m
tests: true tests: true

2
cmd/bd/daemon.go
View File

@@ -544,7 +544,7 @@ func migrateToGlobalDaemon() {
os.Exit(1) os.Exit(1)
} }
go cmd.Wait() go func() { _ = cmd.Wait() }()
// Wait for daemon to be ready // Wait for daemon to be ready
time.Sleep(2 * time.Second) time.Sleep(2 * time.Second)

8
cmd/bd/daemon_lock.go
View File

@@ -49,10 +49,10 @@ func acquireDaemonLock(beadsDir string, global bool) (*DaemonLock, error) {
} }
// Write our PID to the lock file for debugging (optional) // Write our PID to the lock file for debugging (optional)
f.Truncate(0) _ = f.Truncate(0)
f.Seek(0, 0) _, _ = f.Seek(0, 0)
fmt.Fprintf(f, "%d\n", os.Getpid()) fmt.Fprintf(f, "%d\n", os.Getpid())
f.Sync() _ = f.Sync()
return &DaemonLock{file: f, path: lockPath}, nil return &DaemonLock{file: f, path: lockPath}, nil
} }
@@ -80,7 +80,7 @@ func tryDaemonLock(beadsDir string) (running bool, pid int) {
if data := make([]byte, 32); true { if data := make([]byte, 32); true {
n, _ := f.Read(data) n, _ := f.Read(data)
if n > 0 { if n > 0 {
fmt.Sscanf(string(data), "%d", &pid) _, _ = fmt.Sscanf(string(data), "%d", &pid)
} }
} }
return true, pid return true, pid

4
internal/config/config.go
View File

@@ -76,8 +76,8 @@ func Initialize() error {
// Additional environment variables (not prefixed with BD_) // Additional environment variables (not prefixed with BD_)
// These are bound explicitly for backward compatibility // These are bound explicitly for backward compatibility
v.BindEnv("flush-debounce", "BEADS_FLUSH_DEBOUNCE") _ = v.BindEnv("flush-debounce", "BEADS_FLUSH_DEBOUNCE")
v.BindEnv("auto-start-daemon", "BEADS_AUTO_START_DAEMON") _ = v.BindEnv("auto-start-daemon", "BEADS_AUTO_START_DAEMON")
// Set defaults for additional settings // Set defaults for additional settings
v.SetDefault("flush-debounce", "5s") v.SetDefault("flush-debounce", "5s")

13
internal/rpc/limits_test.go
View File

@@ -219,10 +219,6 @@ func TestMemoryPressureDetection(t *testing.T) {
socketPath := filepath.Join(tmpDir, "test.sock") socketPath := filepath.Join(tmpDir, "test.sock")
// Set very low memory threshold to trigger eviction
os.Setenv("BEADS_DAEMON_MEMORY_THRESHOLD_MB", "1")
defer os.Unsetenv("BEADS_DAEMON_MEMORY_THRESHOLD_MB")
srv := NewServer(socketPath, store) srv := NewServer(socketPath, store)
// Add some entries to cache // Add some entries to cache
@@ -237,8 +233,8 @@ func TestMemoryPressureDetection(t *testing.T) {
initialSize := len(srv.storageCache) initialSize := len(srv.storageCache)
srv.cacheMu.Unlock() srv.cacheMu.Unlock()
// Trigger memory pressure check (should evict entries) // Trigger aggressive eviction directly (should evict 50% of entries)
srv.checkMemoryPressure() srv.aggressiveEviction()
// Check that some entries were evicted // Check that some entries were evicted
srv.cacheMu.RLock() srv.cacheMu.RLock()
@@ -249,6 +245,11 @@ func TestMemoryPressureDetection(t *testing.T) {
t.Errorf("expected cache eviction, but size went from %d to %d", initialSize, finalSize) t.Errorf("expected cache eviction, but size went from %d to %d", initialSize, finalSize)
} }
expectedSize := initialSize / 2
if finalSize != expectedSize {
t.Errorf("expected exactly %d entries after evicting 50%%, got %d", expectedSize, finalSize)
}
t.Logf("Cache evicted: %d -> %d entries", initialSize, finalSize) t.Logf("Cache evicted: %d -> %d entries", initialSize, finalSize)
} }

8
internal/rpc/server.go
View File

@@ -290,7 +290,7 @@ func (s *Server) handleSignals() {
sigChan := make(chan os.Signal, 1) sigChan := make(chan os.Signal, 1)
signal.Notify(sigChan, serverSignals...) signal.Notify(sigChan, serverSignals...)
<-sigChan <-sigChan
s.Stop() _ = s.Stop()
} }
// runCleanupLoop periodically evicts stale storage connections and checks memory pressure // runCleanupLoop periodically evicts stale storage connections and checks memory pressure
@@ -1582,9 +1582,9 @@ func (s *Server) findDatabaseForCwd(cwd string) string {
func (s *Server) writeResponse(writer *bufio.Writer, resp Response) { func (s *Server) writeResponse(writer *bufio.Writer, resp Response) {
data, _ := json.Marshal(resp) data, _ := json.Marshal(resp)
writer.Write(data) _, _ = writer.Write(data)
writer.WriteByte('\n') _ = writer.WriteByte('\n')
writer.Flush() _ = writer.Flush()
} }
// Multi-repo handlers // Multi-repo handlers