johno/beads
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bd sync: 2025-11-08 01:02:24

Browse Source
This commit is contained in:
Steve Yegge
2025-11-08 01:02:24 -08:00
parent 29a3dfe9a4
commit ef1634d850
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.beads/beads.jsonl
View File

@@ -51,7 +51,7 @@
{"id":"bd-2b34.7","content_hash":"64f698aef173b6ff3b70021be35c423aa14c853b2ef36a30e6ab41099e4b29c3","title":"Add tests for daemon config module","description":"","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-31T22:28:42.373684-07:00","updated_at":"2025-11-01T21:21:42.431252-07:00","closed_at":"2025-11-01T21:21:42.431252-07:00","source_repo":"."} {"id":"bd-2b34.7","content_hash":"64f698aef173b6ff3b70021be35c423aa14c853b2ef36a30e6ab41099e4b29c3","title":"Add tests for daemon config module","description":"","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-31T22:28:42.373684-07:00","updated_at":"2025-11-01T21:21:42.431252-07:00","closed_at":"2025-11-01T21:21:42.431252-07:00","source_repo":"."}
{"id":"bd-2b34.8","content_hash":"1a859e1791613917defac65bf2632904f5cc79017ad7aa83323027fd54fbd541","title":"Extract daemon lifecycle functions to daemon_lifecycle.go","description":"","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-31T22:28:42.382892-07:00","updated_at":"2025-11-01T21:02:58.350055-07:00","closed_at":"2025-11-01T21:02:58.350055-07:00","source_repo":"."} {"id":"bd-2b34.8","content_hash":"1a859e1791613917defac65bf2632904f5cc79017ad7aa83323027fd54fbd541","title":"Extract daemon lifecycle functions to daemon_lifecycle.go","description":"","status":"closed","priority":1,"issue_type":"task","created_at":"2025-10-31T22:28:42.382892-07:00","updated_at":"2025-11-01T21:02:58.350055-07:00","closed_at":"2025-11-01T21:02:58.350055-07:00","source_repo":"."}
{"id":"bd-2c5a","content_hash":"1f430d37e5ae77164b6773e61be6a21b3bf1914a8ae608747a84d5a7424e2f2d","title":"Investigate why test issues persist in database","description":"Test issues (bd-0do3, bd-cjxp, bd-phr2, etc.) keep appearing in ready/list output, cluttering real work. These appear to be leftover test data from test runs.\n\nNeed to investigate:\n1. Why are test issues not being cleaned up after tests?\n2. Are tests creating issues in the main database instead of test databases?\n3. Should we add better test isolation or cleanup hooks?\n4. Can we add a label/prefix to distinguish test issues from real issues?\n\nThese test issues have characteristics:\n- Empty descriptions\n- Generic titles like \"Test issue 0\", \"Bug P0\", \"Issue to reopen with reason\"\n- Created around 2025-11-07 19:00-19:07\n- Some assigned to test users like \"alice\", \"bob\", \"testuser\"","notes":"## Root Cause Analysis\n\n**Problem**: Python MCP integration tests created test issues in production `.beads/beads.db` instead of isolated test databases.\n\n**Evidence**:\n- 29 test issues created on Nov 7, 2025 at 19:00-19:07\n- Patterns: \"Bug P0\", \"Test issue X\", assignees \"alice\"/\"bob\"/\"testuser\"\n- Git commit 0e8936b shows test issues committed to .beads/beads.jsonl\n- Tests were being fixed for workspace isolation around the same time\n\n**Why It Happened**:\n1. Before commit 0e8936b, `test_client_lazy_initialization()` didn't set `BEADS_WORKING_DIR`\n2. Tests fell back to discovering `.beads/` in the project root directory\n3. Auto-sync committed test issues to production database\n\n**Resolution**:\n1. ✅ Closed 29 test pollution issues (bd-0do3, bd-cjxp, etc.)\n2. ✅ Added `failIfProductionDatabase()` guard in Go test helpers\n3. ✅ Added production pollution checks in RPC test setup\n4. ✅ Created `conftest.py` with pytest safety checks for Python tests\n5. ✅ Added `BEADS_TEST_MODE` env var to mark test execution\n6. ✅ Tests now fail fast if they detect production database usage\n\n**Prevention**:\n- All test helper functions now verify database paths are in temp directories\n- Python tests fail immediately if BEADS_DB points to production\n- BEADS_TEST_MODE flag helps identify test vs production execution\n- Clear error messages guide developers to use proper test isolation\n\n**Files Modified**:\n- cmd/bd/test_helpers_test.go - Added failIfProductionDatabase()\n- internal/rpc/rpc_test.go - Added temp directory verification\n- integrations/beads-mcp/tests/conftest.py - New file with pytest safeguards","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-11-07T21:31:34.845887-08:00","updated_at":"2025-11-07T21:57:30.892086-08:00","closed_at":"2025-11-07T21:57:30.892086-08:00","source_repo":"."} {"id":"bd-2c5a","content_hash":"1f430d37e5ae77164b6773e61be6a21b3bf1914a8ae608747a84d5a7424e2f2d","title":"Investigate why test issues persist in database","description":"Test issues (bd-0do3, bd-cjxp, bd-phr2, etc.) keep appearing in ready/list output, cluttering real work. These appear to be leftover test data from test runs.\n\nNeed to investigate:\n1. Why are test issues not being cleaned up after tests?\n2. Are tests creating issues in the main database instead of test databases?\n3. Should we add better test isolation or cleanup hooks?\n4. Can we add a label/prefix to distinguish test issues from real issues?\n\nThese test issues have characteristics:\n- Empty descriptions\n- Generic titles like \"Test issue 0\", \"Bug P0\", \"Issue to reopen with reason\"\n- Created around 2025-11-07 19:00-19:07\n- Some assigned to test users like \"alice\", \"bob\", \"testuser\"","notes":"## Root Cause Analysis\n\n**Problem**: Python MCP integration tests created test issues in production `.beads/beads.db` instead of isolated test databases.\n\n**Evidence**:\n- 29 test issues created on Nov 7, 2025 at 19:00-19:07\n- Patterns: \"Bug P0\", \"Test issue X\", assignees \"alice\"/\"bob\"/\"testuser\"\n- Git commit 0e8936b shows test issues committed to .beads/beads.jsonl\n- Tests were being fixed for workspace isolation around the same time\n\n**Why It Happened**:\n1. Before commit 0e8936b, `test_client_lazy_initialization()` didn't set `BEADS_WORKING_DIR`\n2. Tests fell back to discovering `.beads/` in the project root directory\n3. Auto-sync committed test issues to production database\n\n**Resolution**:\n1. ✅ Closed 29 test pollution issues (bd-0do3, bd-cjxp, etc.)\n2. ✅ Added `failIfProductionDatabase()` guard in Go test helpers\n3. ✅ Added production pollution checks in RPC test setup\n4. ✅ Created `conftest.py` with pytest safety checks for Python tests\n5. ✅ Added `BEADS_TEST_MODE` env var to mark test execution\n6. ✅ Tests now fail fast if they detect production database usage\n\n**Prevention**:\n- All test helper functions now verify database paths are in temp directories\n- Python tests fail immediately if BEADS_DB points to production\n- BEADS_TEST_MODE flag helps identify test vs production execution\n- Clear error messages guide developers to use proper test isolation\n\n**Files Modified**:\n- cmd/bd/test_helpers_test.go - Added failIfProductionDatabase()\n- internal/rpc/rpc_test.go - Added temp directory verification\n- integrations/beads-mcp/tests/conftest.py - New file with pytest safeguards","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-11-07T21:31:34.845887-08:00","updated_at":"2025-11-07T21:57:30.892086-08:00","closed_at":"2025-11-07T21:57:30.892086-08:00","source_repo":"."}
{"id":"bd-2cvu","content_hash":"f9ed8ea27ba7cd9c93c7a627af8541ab0702ab309295d529fbb07548c36482c9","title":"Update AGENTS.md with Agent Mail workflow","description":"Update agent workflow section to include Agent Mail coordination as optional step.\n\nAcceptance Criteria:\n- Add Agent Mail to recommended workflow\n- Show both with/without examples\n- Update \"Multi-Agent Patterns\" section\n- Cross-reference to AGENT_MAIL.md\n\nFile: AGENTS.md (lines 468-475)","status":"open","priority":1,"issue_type":"task","created_at":"2025-11-07T22:42:51.295729-08:00","updated_at":"2025-11-07T22:42:51.295729-08:00","source_repo":".","dependencies":[{"issue_id":"bd-2cvu","depends_on_id":"bd-xzrv","type":"blocks","created_at":"2025-11-07T23:04:09.773656-08:00","created_by":"daemon"}]} {"id":"bd-2cvu","content_hash":"f9ed8ea27ba7cd9c93c7a627af8541ab0702ab309295d529fbb07548c36482c9","title":"Update AGENTS.md with Agent Mail workflow","description":"Update agent workflow section to include Agent Mail coordination as optional step.\n\nAcceptance Criteria:\n- Add Agent Mail to recommended workflow\n- Show both with/without examples\n- Update \"Multi-Agent Patterns\" section\n- Cross-reference to AGENT_MAIL.md\n\nFile: AGENTS.md (lines 468-475)","status":"closed","priority":1,"issue_type":"task","created_at":"2025-11-07T22:42:51.295729-08:00","updated_at":"2025-11-08T00:52:34.288915-08:00","closed_at":"2025-11-08T00:52:34.288915-08:00","source_repo":".","dependencies":[{"issue_id":"bd-2cvu","depends_on_id":"bd-xzrv","type":"blocks","created_at":"2025-11-07T23:04:09.773656-08:00","created_by":"daemon"}]}
{"id":"bd-2e80","content_hash":"bb7de865be3d63a2c6c167cf1100a458bfcc4d04d85639bcbcf22f310477e408","title":"Document shared memory test isolation pattern in test_helpers.go","description":"Tests were failing because :memory: creates a shared database across all tests. The fix is to use \"file::memory:?mode=memory\u0026cache=private\" for test isolation.\n\nShould document this pattern in test_helpers.go and potentially update newTestStore to use private memory by default.","status":"closed","priority":3,"issue_type":"chore","created_at":"2025-11-01T22:40:58.993496-07:00","updated_at":"2025-11-02T16:27:39.02423-08:00","closed_at":"2025-11-02T16:27:39.024233-08:00","source_repo":"."} {"id":"bd-2e80","content_hash":"bb7de865be3d63a2c6c167cf1100a458bfcc4d04d85639bcbcf22f310477e408","title":"Document shared memory test isolation pattern in test_helpers.go","description":"Tests were failing because :memory: creates a shared database across all tests. The fix is to use \"file::memory:?mode=memory\u0026cache=private\" for test isolation.\n\nShould document this pattern in test_helpers.go and potentially update newTestStore to use private memory by default.","status":"closed","priority":3,"issue_type":"chore","created_at":"2025-11-01T22:40:58.993496-07:00","updated_at":"2025-11-02T16:27:39.02423-08:00","closed_at":"2025-11-02T16:27:39.024233-08:00","source_repo":"."}
{"id":"bd-2e94","content_hash":"1d40ab2be89b41469616c28ca4edef61c558d20656ae615007c822e84608639b","title":"Support --parent flag in daemon mode","description":"Added support for hierarchical child issue creation using --parent flag in daemon mode. Previously only worked in direct mode.","status":"closed","priority":1,"issue_type":"feature","created_at":"2025-11-05T13:55:47.415771-08:00","updated_at":"2025-11-05T13:55:53.252342-08:00","closed_at":"2025-11-05T13:55:53.252342-08:00","source_repo":"."} {"id":"bd-2e94","content_hash":"1d40ab2be89b41469616c28ca4edef61c558d20656ae615007c822e84608639b","title":"Support --parent flag in daemon mode","description":"Added support for hierarchical child issue creation using --parent flag in daemon mode. Previously only worked in direct mode.","status":"closed","priority":1,"issue_type":"feature","created_at":"2025-11-05T13:55:47.415771-08:00","updated_at":"2025-11-05T13:55:53.252342-08:00","closed_at":"2025-11-05T13:55:53.252342-08:00","source_repo":"."}
{"id":"bd-2ifg","content_hash":"1a32ca6b21a14e121fc8e1026d83d85683cd3ff3b500f56eb8a05398b89ebf51","title":"bd-hv01: Silent partial deletion failures cause DB inconsistency","description":"Problem: deletion_tracking.go:76-77 logs deletion errors as warnings but continues. If deletion fails midway (database locked, disk full), some issues delete but others don't. System thinks all deletions succeeded.\n\nImpact: Database diverges from JSONL, silent corruption, issues may resurrect on next sync.\n\nFix: Collect errors and fail the operation:\nvar deletionErrors []error\nfor _, id := range acceptedDeletions {\n if err := d.DeleteIssue(ctx, id); err != nil {\n deletionErrors = append(deletionErrors, fmt.Errorf(\"issue %s: %w\", id, err))\n }\n}\nif len(deletionErrors) \u003e 0 {\n return false, fmt.Errorf(\"deletion failures: %v\", deletionErrors)\n}\n\nFiles: cmd/bd/deletion_tracking.go:73-82","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-11-06T18:16:19.465137-08:00","updated_at":"2025-11-06T18:46:55.901973-08:00","closed_at":"2025-11-06T18:46:55.901973-08:00","source_repo":".","dependencies":[{"issue_id":"bd-2ifg","depends_on_id":"bd-rbxi","type":"parent-child","created_at":"2025-11-06T18:19:14.833477-08:00","created_by":"daemon"}]} {"id":"bd-2ifg","content_hash":"1a32ca6b21a14e121fc8e1026d83d85683cd3ff3b500f56eb8a05398b89ebf51","title":"bd-hv01: Silent partial deletion failures cause DB inconsistency","description":"Problem: deletion_tracking.go:76-77 logs deletion errors as warnings but continues. If deletion fails midway (database locked, disk full), some issues delete but others don't. System thinks all deletions succeeded.\n\nImpact: Database diverges from JSONL, silent corruption, issues may resurrect on next sync.\n\nFix: Collect errors and fail the operation:\nvar deletionErrors []error\nfor _, id := range acceptedDeletions {\n if err := d.DeleteIssue(ctx, id); err != nil {\n deletionErrors = append(deletionErrors, fmt.Errorf(\"issue %s: %w\", id, err))\n }\n}\nif len(deletionErrors) \u003e 0 {\n return false, fmt.Errorf(\"deletion failures: %v\", deletionErrors)\n}\n\nFiles: cmd/bd/deletion_tracking.go:73-82","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-11-06T18:16:19.465137-08:00","updated_at":"2025-11-06T18:46:55.901973-08:00","closed_at":"2025-11-06T18:46:55.901973-08:00","source_repo":".","dependencies":[{"issue_id":"bd-2ifg","depends_on_id":"bd-rbxi","type":"parent-child","created_at":"2025-11-06T18:19:14.833477-08:00","created_by":"daemon"}]}