feat(daemon): unify auto-sync config for simpler agent workflows (#904)
* feat(daemon): unify auto-sync config for simpler agent workflows ## Problem Agents running `bd sync` at session end caused delays in the Claude Code "event loop", slowing development. The daemon was already auto-exporting DB→JSONL instantly, but auto-commit and auto-push weren't enabled by default when sync-branch was configured - requiring manual `bd sync`. Additionally, having three separate config options (auto-commit, auto-push, auto-pull) was confusing and could get out of sync. ## Solution Simplify to two intuitive sync modes: 1. **Read/Write Mode** (`daemon.auto-sync: true` or `BEADS_AUTO_SYNC=true`) - Enables auto-commit + auto-push + auto-pull - Full bidirectional sync - eliminates need for manual `bd sync` - Default when sync-branch is configured 2. **Read-Only Mode** (`daemon.auto-pull: true` or `BEADS_AUTO_PULL=true`) - Only receives updates from team - Does NOT auto-publish changes - Useful for experimental work or manual review before sharing ## Benefits - **Faster agent workflows**: No more `bd sync` delays at session end - **Simpler config**: Two modes instead of three separate toggles - **Backward compatible**: Legacy auto_commit/auto_push settings still work (treated as auto-sync=true) - **Adaptive `bd prime`**: Session close protocol adapts when daemon is auto-syncing (shows simplified 4-step git workflow, no `bd sync`) - **Doctor warnings**: `bd doctor` warns about deprecated legacy config ## Changes - cmd/bd/daemon.go: Add loadDaemonAutoSettings() with unified config logic - cmd/bd/doctor.go: Add CheckLegacyDaemonConfig call - cmd/bd/doctor/daemon.go: Add CheckDaemonAutoSync, CheckLegacyDaemonConfig - cmd/bd/init_team.go: Use daemon.auto-sync in team wizard - cmd/bd/prime.go: Detect daemon auto-sync, adapt session close protocol - cmd/bd/prime_test.go: Add stubIsDaemonAutoSyncing for testing * docs: add comprehensive daemon technical analysis Add daemon-summary.md documenting the beads daemon architecture, memory analysis (explaining the 30-35MB footprint), platform support comparison, historical problems and fixes, and architectural guidance for other projects implementing similar daemon patterns. Key sections: - Architecture deep dive with component diagrams - Memory breakdown (SQLite WASM runtime is the main contributor) - Platform support matrix (macOS/Linux full, Windows partial) - Historical bugs and their fixes with reusable patterns - Analysis of daemon usefulness without database (verdict: low value) - Expert-reviewed improvement proposals (3 recommended, 3 skipped) - Technical design patterns for other implementations * feat: add cross-platform CI matrix and dual-mode test framework Cross-Platform CI: - Add Windows, macOS, Linux matrix to catch platform-specific bugs - Linux: full tests with race detector and coverage - macOS: full tests with race detector - Windows: full tests without race detector (performance) - Catches bugs like GH#880 (macOS path casing) and GH#387 (Windows daemon) Dual-Mode Test Framework (cmd/bd/dual_mode_test.go): - Runs tests in both direct mode and daemon mode - Prevents recurring bug pattern (GH#719, GH#751, bd-fu83) - Provides DualModeTestEnv with helper methods for common operations - Includes 5 example tests demonstrating the pattern Documentation: - Add dual-mode testing section to CONTRIBUTING.md - Document RunDualModeTest API and available helpers Test Fixes: - Fix sync_local_only_test.go gitPull/gitPush calls - Add gate_no_daemon_test.go for beads-70c4 investigation * fix(test): isolate TestFindBeadsDir tests with BEADS_DIR env var The tests were finding the real project's .beads directory instead of the temp directory because FindBeadsDir() walks up the directory tree. Using BEADS_DIR env var provides proper test isolation. * fix(test): stop daemon before running test suite guard The test suite guard checks that tests don't modify the real repo's .beads directory. However, a background daemon running auto-sync would touch issues.jsonl during test execution, causing false positives. Changes: - Set BEADS_NO_DAEMON=1 to prevent daemon auto-start from tests - Stop any running daemon for the repo before taking the "before" snapshot - Uses exec to call `bd daemon --stop` to avoid import cycle issues * chore: revert .beads/issues.jsonl to upstream/main Per CONTRIBUTING.md, .beads/issues.jsonl should not be modified in PRs.
This commit is contained in:
@@ -178,6 +178,56 @@ go test -race -coverprofile=coverage.out ./...
|
||||
- Use `t.Run()` for subtests to organize related test cases
|
||||
- Mark slow tests with `if testing.Short() { t.Skip("slow test") }`
|
||||
|
||||
### Dual-Mode Testing Pattern
|
||||
|
||||
**IMPORTANT**: bd supports two execution modes: *direct mode* (SQLite access) and *daemon mode* (RPC via background process). Commands must work identically in both modes. To prevent bugs like GH#719, GH#751, and bd-fu83, use the dual-mode test framework for testing commands.
|
||||
|
||||
```go
|
||||
// cmd/bd/dual_mode_test.go provides the framework
|
||||
|
||||
func TestMyCommand(t *testing.T) {
|
||||
// This test runs TWICE: once in direct mode, once with a live daemon
|
||||
RunDualModeTest(t, "my_test", func(t *testing.T, env *DualModeTestEnv) {
|
||||
// Create test data using mode-agnostic helpers
|
||||
issue := &types.Issue{
|
||||
Title: "Test issue",
|
||||
IssueType: types.TypeTask,
|
||||
Status: types.StatusOpen,
|
||||
Priority: 2,
|
||||
}
|
||||
if err := env.CreateIssue(issue); err != nil {
|
||||
t.Fatalf("[%s] CreateIssue failed: %v", env.Mode(), err)
|
||||
}
|
||||
|
||||
// Verify behavior - works in both modes
|
||||
got, err := env.GetIssue(issue.ID)
|
||||
if err != nil {
|
||||
t.Fatalf("[%s] GetIssue failed: %v", env.Mode(), err)
|
||||
}
|
||||
if got.Title != "Test issue" {
|
||||
t.Errorf("[%s] wrong title: got %q", env.Mode(), got.Title)
|
||||
}
|
||||
})
|
||||
}
|
||||
```
|
||||
|
||||
Available `DualModeTestEnv` helper methods:
|
||||
- `CreateIssue(issue)` - Create an issue
|
||||
- `GetIssue(id)` - Retrieve an issue by ID
|
||||
- `UpdateIssue(id, updates)` - Update issue fields
|
||||
- `DeleteIssue(id, force)` - Delete (tombstone) an issue
|
||||
- `AddDependency(from, to, type)` - Add a dependency
|
||||
- `ListIssues(filter)` - List issues matching filter
|
||||
- `GetReadyWork()` - Get issues ready for work
|
||||
- `AddLabel(id, label)` - Add a label to an issue
|
||||
- `Mode()` - Returns "direct" or "daemon" for error messages
|
||||
|
||||
Run dual-mode tests:
|
||||
```bash
|
||||
# Run dual-mode tests (requires integration tag)
|
||||
go test -v -tags integration -run "TestDualMode" ./cmd/bd/
|
||||
```
|
||||
|
||||
Example:
|
||||
|
||||
```go
|
||||
|
||||
Reference in New Issue
Block a user