beads

johno/beads

Fork 0

Commit Graph

Author	SHA1	Message	Date
Steve Yegge	14e14f647e	Fix goconst linter issues (bd-116) - Use windowsOS constant in reinit_test.go - Use testIssueBD1 constant in compact_test.go and counter_sync_test.go - Merged duplicate bd-126 into bd-116	2025-10-25 18:04:05 -07:00
Steve Yegge	c2c7eda14f	Fix 15 lint errors: dupl, gosec, revive, staticcheck, unparam Reduced golangci-lint issues from 56 to 41: Fixed: - dupl (2→0): Extracted parseLabelArgs helper, added nolint for cobra commands - gosec G104 (4→0): Handle unhandled errors with _ = assignments - gosec G302/G306 (4→0): Fixed file permissions from 0644 to 0600 - revive exported (4→0): Added proper godoc comments for all exported types - staticcheck SA1019 (1→0): Removed deprecated netErr.Temporary() call - staticcheck SA4003 (1→0): Removed impossible uint64 < 0 check - unparam (8→0): Removed unused params/returns, added nolint where needed Renamed types in compact package to avoid stuttering: - CompactConfig → Config - CompactResult → Result Remaining 41 issues are documented baseline: - gocyclo (24): High complexity in large functions - gosec G204/G115 (17): False positives for subprocess/conversions Closes bd-92 Amp-Thread-ID: https://ampcode.com/threads/T-1c136506-d703-4781-bcfa-eb605999545a Co-authored-by: Amp <amp@ampcode.com>	2025-10-24 12:40:56 -07:00
Steve Yegge	582bd6e183	Fix bd-49: Sync counters after deletions to prevent desync - Call SyncAllCounters() after DeleteIssue and DeleteIssues - Change SyncAllCounters to use excluded.last_id (allows counter to decrease) - Delete orphaned counter rows when no issues remain for a prefix - Add comprehensive tests in counter_sync_test.go Fixes the issue where deleting issues left counters at high values, causing new issues to skip IDs. Now counters accurately reflect the max existing ID. Closes bd-49 Amp-Thread-ID: https://ampcode.com/threads/T-c3bdb8b9-d67b-4de5-901e-7ea76fc9e399 Co-authored-by: Amp <amp@ampcode.com>	2025-10-21 23:33:01 -07:00

Author

SHA1

Message

Date

Steve Yegge

14e14f647e

Fix goconst linter issues (bd-116)

- Use windowsOS constant in reinit_test.go
- Use testIssueBD1 constant in compact_test.go and counter_sync_test.go
- Merged duplicate bd-126 into bd-116

2025-10-25 18:04:05 -07:00

Steve Yegge

c2c7eda14f

Fix 15 lint errors: dupl, gosec, revive, staticcheck, unparam

Reduced golangci-lint issues from 56 to 41:

Fixed:
- dupl (2→0): Extracted parseLabelArgs helper, added nolint for cobra commands
- gosec G104 (4→0): Handle unhandled errors with _ = assignments
- gosec G302/G306 (4→0): Fixed file permissions from 0644 to 0600
- revive exported (4→0): Added proper godoc comments for all exported types
- staticcheck SA1019 (1→0): Removed deprecated netErr.Temporary() call
- staticcheck SA4003 (1→0): Removed impossible uint64 < 0 check
- unparam (8→0): Removed unused params/returns, added nolint where needed

Renamed types in compact package to avoid stuttering:
- CompactConfig → Config
- CompactResult → Result

Remaining 41 issues are documented baseline:
- gocyclo (24): High complexity in large functions
- gosec G204/G115 (17): False positives for subprocess/conversions

Closes bd-92

Amp-Thread-ID: https://ampcode.com/threads/T-1c136506-d703-4781-bcfa-eb605999545a
Co-authored-by: Amp <amp@ampcode.com>

2025-10-24 12:40:56 -07:00

Steve Yegge

582bd6e183

Fix bd-49: Sync counters after deletions to prevent desync

- Call SyncAllCounters() after DeleteIssue and DeleteIssues
- Change SyncAllCounters to use excluded.last_id (allows counter to decrease)
- Delete orphaned counter rows when no issues remain for a prefix
- Add comprehensive tests in counter_sync_test.go

Fixes the issue where deleting issues left counters at high values, causing
new issues to skip IDs. Now counters accurately reflect the max existing ID.

Closes bd-49

Amp-Thread-ID: https://ampcode.com/threads/T-c3bdb8b9-d67b-4de5-901e-7ea76fc9e399
Co-authored-by: Amp <amp@ampcode.com>

2025-10-21 23:33:01 -07:00

3 Commits